Add StatementByGuidMap::addStatement

Author: JeroenDeDauw

src/Statement/StatementByGuidMap.php

@@ -10,7 +10,10 @@
 
 /**
  * Ordered and unique collection of Statement objects.
- * Provides indexed access by Statement GUID. Can only contain Statements that have a non-null GUID.
+ * Can only contain Statements that have a non-null GUID.
+ *
+ * Provides indexed access by Statement GUID.
+ * Does not provide complex modification functionality.
  *
  * @since 3.0
  *
@@ -31,7 +34,13 @@ public function __construct( $statements = array() ) {
 		}
 	}
 
-	private function addStatement( Statement $statement ) {
+	/**
+	 * If the provided statement has a GUID not yet in the map, it will be appended to the map.
+	 * If the GUID is already in the map, the statement with this guid will be replaced.
+	 *
+	 * @param Statement $statement
+	 */
+	public function addStatement( Statement $statement ) {
 		if ( $statement->getGuid() === null ) {
 			throw new InvalidArgumentException( 'Can only add statements that have a non-null GUID' );
 		}
@@ -91,6 +100,8 @@ public function count() {
 	}
 
 	/**
+	 * The iterator has the GUIDs of the statements as keys.
+	 *
 	 * @see IteratorAggregate::getIterator
 	 * @return Traversable
 	 */

tests/unit/Statement/StatementByGuidMapTest.php

@@ -161,4 +161,23 @@ public function testMapCanBeIteratedOver() {
 		$this->assertEquals( $expectedStatements, $iteratedStatements );
 	}
 
+	public function testGivenNotPresentStatement_addStatementAddsIt() {
+		$statements = new StatementByGuidMap();
+
+		$statements->addStatement( $this->newStatement( 1, 'some guid' ) );
+
+		$this->assertTrue( $statements->hasStatementWithGuid( 'some guid' ) );
+	}
+
+	public function testGivenStatementWithPresentGuid_addStatementReplacesThePresentStatement() {
+		$statement1 = $this->newStatement( 1, 'some guid' );
+		$statement2 = $this->newStatement( 2, 'some guid' );
+
+		$statements = new StatementByGuidMap( array( $statement1 ) );
+
+		$statements->addStatement( $statement2 );
+
+		$this->assertEquals( $statement2, $statements->getStatementByGuid( 'some guid' ) );
+	}
+
 }