Merge pull request #618 from wmde/referencelisttest

Add regression tests for ReferenceList

Author: JeroenDeDauw

tests/unit/ReferenceListTest.php

@@ -192,14 +192,11 @@ public function testAddReferenceAtIndexZero() {
 	}
 
 	public function testAddReferenceAtNegativeIndex() {
-		$reference1 = new Reference( array( new PropertyNoValueSnak( 1 ) ) );
-		$reference2 = new Reference( array( new PropertyNoValueSnak( 2 ) ) );
-		$reference3 = new Reference( array( new PropertyNoValueSnak( 3 ) ) );
-
-		$references = new ReferenceList( array( $reference1, $reference2 ) );
+		$reference = new Reference( array( new PropertyNoValueSnak( 1 ) ) );
+		$referenceList = new ReferenceList();
 
 		$this->setExpectedException( 'InvalidArgumentException' );
-		$references->addReference( $reference3, -1 );
+		$referenceList->addReference( $reference, -1 );
 	}
 
 	public function testGivenEmptyReference_addReferenceDoesNotAdd() {
@@ -239,6 +236,16 @@ public function testIndexOf( ReferenceList $array ) {
 		}
 	}
 
+	public function testIndexOf_falseForMissingReferences() {
+		$referenceList = new ReferenceList();
+		$reference = new Reference( array( new PropertyNoValueSnak( 1 ) ) );
+
+		$referenceList->addNewReference( new PropertyNoValueSnak( 1 ) );
+
+		$this->assertFalse( $referenceList->indexOf( new Reference() ) );
+		$this->assertFalse( $referenceList->indexOf( $reference ) );
+	}
+
 	/**
 	 * @dataProvider instanceProvider
 	 * @param ReferenceList $array