Merge pull request #451 from wmde/slPerf

Avoid looping Statement arrays twice

Author: Benestar

src/Statement/StatementList.php

@@ -130,15 +130,15 @@ public function getWithUniqueMainSnaks() {
 	 * @return StatementList
 	 */
 	public function getWithPropertyId( PropertyId $id ) {
-		$statements = array();
+		$statementList = new self();
 
 		foreach ( $this->statements as $statement ) {
 			if ( $statement->getPropertyId()->equals( $id ) ) {
-				$statements[] = $statement;
+				$statementList->addStatement( $statement );
 			}
 		}
 
-		return new self( $statements );
+		return $statementList;
 	}
 
 	/**
@@ -150,15 +150,15 @@ public function getWithPropertyId( PropertyId $id ) {
 	 */
 	public function getWithRank( $acceptableRanks ) {
 		$acceptableRanks = array_flip( (array)$acceptableRanks );
-		$statements = array();
+		$statementList = new self();
 
 		foreach ( $this->statements as $statement ) {
 			if ( array_key_exists( $statement->getRank(), $acceptableRanks ) ) {
-				$statements[] = $statement;
+				$statementList->addStatement( $statement );
 			}
 		}
 
-		return new self( $statements );
+		return $statementList;
 	}
 
 	/**