Skip to content

Commit 03644c4

Browse files
committed
Reduce line length and simplify PHPCS rule set
1 parent 946cc77 commit 03644c4

2 files changed

Lines changed: 3 additions & 7 deletions

File tree

.phpcs.xml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,22 +4,17 @@
44

55
<rule ref="Generic.Files.LineLength">
66
<properties>
7-
<property name="lineLimit" value="116" />
7+
<property name="lineLimit" value="115" />
88
</properties>
99
</rule>
1010

1111
<!-- Metrics are intentionally not part of the base Wikibase CodeSniffer rule set. -->
1212
<rule ref="Generic.Metrics.CyclomaticComplexity" />
1313
<rule ref="Generic.Metrics.NestingLevel" />
1414

15-
<rule ref="Generic.NamingConventions.CamelCapsFunctionName">
16-
<!-- Exclude test methods like "testGivenInvalidInput_methodThrowsException". -->
17-
<exclude-pattern>tests*Test*\.php</exclude-pattern>
18-
</rule>
1915
<rule ref="PSR1.Files.SideEffects">
2016
<exclude-pattern>WikibaseDataModel\.php</exclude-pattern>
2117
</rule>
22-
<rule ref="Squiz.Arrays.ArrayBracketSpacing" />
2318
<rule ref="Squiz.Strings.DoubleQuoteUsage">
2419
<exclude name="Squiz.Strings.DoubleQuoteUsage.ContainsVar" />
2520
</rule>

tests/unit/ReferenceListTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,8 @@ public function testGivenCloneOfReferenceInList_hasReferenceReturnsTrue() {
125125

126126
$this->assertTrue(
127127
$list->hasReference( $sameReference ),
128-
'hasReference should return true when a reference with the same value is present, even when its another instance'
128+
'hasReference should return true when a reference with the same value is present, even '
129+
. 'when its another instance'
129130
);
130131
}
131132

0 commit comments

Comments
 (0)