Skip to content

Commit 7667769

Browse files
committed
Remove unused CSS variables in shiki global styles, remove box shadows in uppy core styles
1 parent 3bd06e6 commit 7667769

4 files changed

Lines changed: 27 additions & 28 deletions

File tree

‎.vscode/settings.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,7 @@
119119
"Southam",
120120
"spriter",
121121
"squoosh",
122+
"srgb",
122123
"startdt",
123124
"tanabata",
124125
"TIMESTAMPTZ",

‎_TODO.md‎

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,3 +63,20 @@ https://vercel.com/kevin-browns-projects-dd474f73/astro-webstackbuilders-com/ai-
6363
We have E2E errors again testimonials slide on mobile chrome and safari. I think the problem is that we are pausing carousels when part of the carousel is outside of the viewport, and the testimonials are too large to display on mobile without being off viewport.
6464

6565
`test/e2e/specs/04-components/testimonials.spec.ts`:244:3 › Testimonials Component › @ready testimonials auto-rotate changes slide index
66+
67+
## Improve print layout by hiding header and footer for articles, add tracking
68+
69+
```typescript
70+
window.addEventListener('beforeprint', (event) => {
71+
console.log('Before print dialog opens, run this script.')
72+
// Example: change content or hide elements
73+
document.getElementById('hide-on-print').style.display = 'none'
74+
})
75+
76+
window.addEventListener('afterprint', (event) => {
77+
console.log('After print dialog closes, run this script to revert changes.')
78+
// Example: revert changes
79+
document.getElementById('hide-on-print').style.display = ''
80+
// You can also use this event to send an AJAX request to a server for print tracking.
81+
})
82+
```

‎src/components/Forms/Contact/uppy-core.css‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@
6464

6565
.uppy-c-textInput:focus {
6666
border-color: color-mix(in srgb, var(--color-secondary) 60%, transparent);
67-
box-shadow: 0 0 0 3px color-mix(in srgb, var(--color-secondary) 15%, transparent);
67+
box-shadow: none;
6868
outline: none;
6969
}
7070

@@ -149,7 +149,7 @@
149149
}
150150

151151
[data-uppy-theme="dark"] .uppy-c-btn-primary:focus {
152-
box-shadow: 0 0 0 2px color-mix(in srgb, var(--color-secondary) 85%, transparent);
152+
box-shadow: none;
153153
}
154154

155155
.uppy-c-btn-primary.uppy-c-btn--disabled {
@@ -170,7 +170,7 @@
170170
}
171171

172172
.uppy-c-btn-link:focus {
173-
box-shadow: 0 0 0 3px color-mix(in srgb, var(--color-secondary) 25%, transparent);
173+
box-shadow: none;
174174
outline: none;
175175
}
176176

‎src/styles/shiki.css‎

Lines changed: 6 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -4,39 +4,20 @@
44
* Supports dual themes configured in astro.config.mjs:
55
* - github-light for light mode
66
* - github-dark for dark mode
7-
*
8-
* The --shiki-theme CSS variable is available but Astro's Shiki integration
9-
* automatically handles theme switching via .shiki-light/.shiki-dark classes.
107
*/
118

12-
/*
13-
each line is wrapped in a <span class='line'> so line number
14-
can be done like this, here with a different starting number:
15-
<code style="--start: 13;">...</code>
16-
*/
17-
18-
/** CodeTabs custom CSS variables */
19-
:root {
20-
--astro-code-color-text: white;
21-
--astro-code-color-background: black;
22-
--astro-code-token-constant: plum;
23-
--astro-code-token-string: purple;
24-
--astro-code-token-comment: tomato;
25-
--astro-code-token-keyword: darkslategrey;
26-
--astro-code-token-parameter: coral;
27-
--astro-code-token-function: green;
28-
--astro-code-token-string-expression: chartreuse;
29-
--astro-code-token-punctuation: gray;
30-
--astro-code-token-link: firebrick;
31-
}
32-
9+
/**
10+
* Each line is wrapped in a <span class='line'> so line number can be done
11+
* like this, here with a different starting number:
12+
* <code style="--start: 13;">...</code>
13+
*/
3314
code {
3415
counter-increment: step calc(var(--start, 1) - 1);
3516
counter-reset: step;
3617
}
3718

3819
code .line::before {
39-
color: rgb(115 138 148 / 40%);
20+
color: rgb(from var(--color-content-active) r g b / 40%);
4021
content: counter(step);
4122
counter-increment: step;
4223
display: inline-block;

0 commit comments

Comments
 (0)