Skip to content

Commit 97e61e7

Browse files
Switch some classes to records, fix first page results
1 parent bb0012c commit 97e61e7

3 files changed

Lines changed: 5 additions & 7 deletions

File tree

src/Certify.Models/Hub/ManagedCertificateSummary.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ namespace Certify.Models.Hub
66
/// <summary>
77
/// Summary information for a managed certificate
88
/// </summary>
9-
public class ManagedCertificateSummary
9+
public record ManagedCertificateSummary
1010
{
1111
public string? InstanceId { get; set; } = string.Empty;
1212
public string? InstanceTitle { get; set; } = string.Empty;
@@ -64,7 +64,7 @@ public class ManagedCertificateSummary
6464
public bool HasCertificate { get; set; }
6565
}
6666

67-
public class ManagedCertificateSummaryResult
67+
public record ManagedCertificateSummaryResult
6868
{
6969
public IEnumerable<ManagedCertificateSummary> Results { get; set; } = new List<ManagedCertificateSummary>();
7070
public long TotalResults { get; set; }

src/Certify.Models/Hub/ManagedInstanceInfo.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,9 @@ public class ConnectionStatus
2929
public const string Disconnected = "disconnected";
3030
public const string Away = "away";
3131
}
32-
public class ManagedInstanceItems
32+
public record ManagedInstanceItems
3333
{
3434
public string InstanceId { get; set; } = string.Empty;
35-
public List<ManagedCertificate> Items { get; set; } = new List<ManagedCertificate>();
35+
public List<ManagedCertificate> Items { get; set; } = [];
3636
}
3737
}

src/Certify.Server/Certify.Server.Hub.Api/Controllers/internal/HubController.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,6 @@ public async Task<IActionResult> GetHubManagedItems(string? instanceId, string?
5858
var managedItems = _mgmtStateProvider.GetManagedInstanceItems();
5959
var instances = _mgmtStateProvider.GetConnectedInstances();
6060

61-
62-
6361
var list = new List<ManagedCertificateSummary>();
6462

6563
foreach (var remote in managedItems.Values)
@@ -103,7 +101,7 @@ public async Task<IActionResult> GetHubManagedItems(string? instanceId, string?
103101

104102
if (page != null && page > 0)
105103
{
106-
skip = ((int)page - 1) * (pageSize ?? 100);
104+
skip = (int)page * (pageSize ?? 100);
107105
}
108106

109107
result.Results = list.OrderBy(l => l.Title).Skip(skip).Take(pageSize ?? 100);

0 commit comments

Comments
 (0)