improve testing

Author: vvaezian

tests/initial_setup.sh

@@ -18,8 +18,12 @@ then
     exit 1
 fi
 
-# downloading metabase jar
-wget -q https://downloads.metabase.com/v$MB_VERSION/metabase.jar
+# cleaup (in case the script is not running for the first time)
+rm -f metabase.db.mv.db
+rm -f metabase.db.trace.db
+
+# downloading metabase jar file
+wget -O metabase.jar -q https://downloads.metabase.com/v$MB_VERSION/metabase.jar
 
 # starting metabase jar locally
 java -jar metabase.jar > logs 2>&1 &
@@ -81,7 +85,17 @@ json='{
     "visualization_settings": {},
     "collection_id": 2
 }'
-echo "$json" | curl -X POST http://localhost:3000/api/card -H "Content-Type: application/json" -H "X-Metabase-Session:$session_id" -d @- 
+echo "$json" | curl -X POST http://localhost:3000/api/card -H "Content-Type: application/json" -H "X-Metabase-Session:$session_id" -d @- > output
+
+# the order of the IDs assigned to columns is not based on the db column order
+grep -q ',73.*,72' output
+if [[ $? -eq 0 ]]; then 
+    col1_id=73;
+    col2_id=72; 
+else 
+    col1_id=72;
+    col2_id=73; 
+fi
 
 json='{
     "name":"test_card_2",
@@ -94,7 +108,7 @@ json='{
                     "name":"test_filter",
                     "display-name":"Test filter",
                     "type":"dimension",
-                    "dimension":["field",72,null],
+                    "dimension":["field",COL1_ID,null],
                     "widget-type":"string/=",
                     "default":null,
                     "id":"810912da-ead5-c87e-de32-6dc5723b9067"
@@ -115,6 +129,9 @@ json='{
     }],
     "collection_id":2
 }'
+# add the value of $col1_id (because of presense of single and double quotes in the json string, I decided to add the variable value in this way)
+json=$(echo "$json" | sed "s/COL1_ID/$col1_id/g")
+
 echo "$json" | curl -X POST http://localhost:3000/api/card -H "Content-Type: application/json" -H "X-Metabase-Session:$session_id" -d @- 
 
 json='{
@@ -123,13 +140,16 @@ json='{
         "type":"query",
         "query":{
             "source-table":9,
-            "filter":["=",["field",72,null],"row1 cell1","row3 cell1"]},
+            "filter":["=",["field",COL1_ID,null],"row1 cell1","row3 cell1"]},
             "database":2
         },
         "display":"table",
         "visualization_settings":{},
         "collection_id":2
 }'
+# add the value of $col1_id 
+json=$(echo "$json" | sed "s/COL1_ID/$col1_id/g")
+
 echo "$json" | curl -X POST http://localhost:3000/api/card -H "Content-Type: application/json" -H "X-Metabase-Session:$session_id" -d @- 
 
 json='{
@@ -139,8 +159,8 @@ json='{
         "database":2,
         "query":{
             "source-table":9,
-            "aggregation":[["avg",["field",73,null]]],
-            "breakout":[["field",72,null]],
+            "aggregation":[["avg",["field",COL2_ID,null]]],
+            "breakout":[["field",COL1_ID,null]],
             "order-by":[["desc",["aggregation",0,null]]]
             },
         "type":"query"
@@ -149,6 +169,9 @@ json='{
     "visualization_settings":{"table.pivot":false,"graph.dimensions":["col1"],"graph.metrics":["avg"]},
     "collection_id":2
 }'
+# add the value of $col1_id and $col2_id
+json=$(echo "$json" | sed "s/COL1_ID/$col1_id/g" | sed "s/COL2_ID/$col2_id/g")
+
 echo "$json" | curl -X POST http://localhost:3000/api/card -H "Content-Type: application/json" -H "X-Metabase-Session:$session_id" -d @- 
 
 # create a test dashboard

tests/test_metabase_api.py

@@ -125,11 +125,11 @@ def test_get_table_metadata(self):
 
 
   def test_get_columns_name_id(self):
-    name_id_mapping = mb.get_columns_name_id(table_id=9)
-    self.assertEqual(name_id_mapping['col1'], 72)
+    name_id_mapping = mb.get_columns_name_id(table_id=1)  # table with id 1 is the products table from sample dataset
+    self.assertEqual(name_id_mapping['CATEGORY'], 1)
 
-    id_name_mapping = mb.get_columns_name_id(table_id=9, column_id_name=True)
-    self.assertEqual(id_name_mapping[72], 'col1')
+    id_name_mapping = mb.get_columns_name_id(table_id=1, column_id_name=True)
+    self.assertEqual(id_name_mapping[1], 'CATEGORY')
 
 
 
@@ -278,15 +278,29 @@ def test_clone_card(self):
     # simple/custom question
     res2 = mb.clone_card(3, 9, 10, new_card_name='test_clone_simple1', new_card_collection_id=1, return_card=True)
     res3 = mb.clone_card(4, 9, 10, new_card_name='test_clone_simple2', new_card_collection_id=1, return_card=True)
-    expected_res3_query = { 'database': 2,
+    
+    # rewriting a value because it's not reliable
+    res3['dataset_query']['query']['order-by'] = ''
+    
+    expected_res3_query_version1 = { 'database': 2,
                             'query': {'source-table': 10,
                                       'aggregation': [['avg', ['field', 75, None]]],
                                       'breakout': [['field', 74, None]],
-                                      'order-by': [['desc', ['aggregation', 0, None]]]
+                                      'order-by': ''
                                     },
                             'type': 'query'
                           }
-    self.assertEqual(res3['dataset_query'], expected_res3_query)
+    # we have two versions because the assigned field id is not necessarily in the order of columns as they appear in db
+    expected_res3_query_version2 = { 'database': 2,
+                            'query': {'source-table': 10,
+                                      'aggregation': [['avg', ['field', 74, None]]],
+                                      'breakout': [['field', 75, None]],
+                                      'order-by': ''
+                                    },
+                            'type': 'query'
+                          }
+    
+    self.assertTrue(res3['dataset_query'] == expected_res3_query_version1 or res3['dataset_query'] == expected_res3_query_version2, res3['dataset_query'])
 
     # add to cleanup list
     Metabase_API_Test.cleanup_objects['card'].extend([res['id'], res2['id'], res3['id']])