bin/xbps-remove: fix memory leak in --clean-cache

Duncaen · Duncaen · commit 2ca426040401 · 2026-02-23T23:03:52.000+01:00
diff --git a/bin/xbps-remove/clean-cache.c b/bin/xbps-remove/clean-cache.c
@@ -181,7 +181,8 @@ clean_cachedir(struct xbps_handle *xhp, bool uninstalled, bool drun)
 			.uninstalled = uninstalled,
 		};
 		rv = xbps_array_foreach_cb_multi(xhp, array, NULL, cleaner_cb, (void*)&data);
-		xbps_object_release(array);
 	}
+
+	xbps_object_release(array);
 	return rv;
 }

Original file line number	Diff line number	Diff line change
`@@ -181,7 +181,8 @@ clean_cachedir(struct xbps_handle *xhp, bool uninstalled, bool drun)`
`181`	`181`	`.uninstalled = uninstalled,`
`182`	`182`	`};`
`183`	`183`	`rv = xbps_array_foreach_cb_multi(xhp, array, NULL, cleaner_cb, (void*)&data);`
`184`		`- xbps_object_release(array);`
`185`	`184`	`}`
	`185`	`+`
	`186`	`+ xbps_object_release(array);`
`186`	`187`	`return rv;`
`187`	`188`	`}`