Defer pool duration telemetry instruments#31
Conversation
Greptile SummaryThis PR defers registration of the
Confidence Score: 5/5Safe to merge — the change is narrow, well-tested, and the lazy-init path is exercised by both the stack and Swoole test runs. The logic change is confined to two Histogram::lazy() calls in setTelemetry(); all downstream record() call sites are untouched. The new tests verify the exact eager-vs-lazy boundary that this PR introduces, and the gauge behavior is unchanged. No correctness issues were found. No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "Defer pool duration telemetry instrument..." | Re-trigger Greptile |
Summary
utopia-php/telemetryto^0.4so pools can use lazy instrument factories.Testing
composer checkcomposer lint./vendor/bin/phpunit --configuration phpunit.xml --filter 'testPoolTelemetry|testPoolUseDurationTelemetryIsCreatedOnFirstUse'composer auditNotes
composer testexits with code 139 in the existingUtopia\Tests\Adapter\SwooleTest::testSwooleCoroutineStressTestafter the new telemetry tests pass in both Stack and Swoole runs.