From 4baf11983f71d48b5ec3875977c3b4cf5d2c09f8 Mon Sep 17 00:00:00 2001 From: KM Koushik Date: Mon, 13 Jul 2026 14:02:28 +1000 Subject: [PATCH 1/2] fix: type-check engagement event detection --- apps/web/src/server/service/ses-hook-parser.ts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/apps/web/src/server/service/ses-hook-parser.ts b/apps/web/src/server/service/ses-hook-parser.ts index 29075418..34d32c55 100644 --- a/apps/web/src/server/service/ses-hook-parser.ts +++ b/apps/web/src/server/service/ses-hook-parser.ts @@ -101,9 +101,8 @@ export async function parseSesHook(data: SesEvent) { return true; } - const isEngagementEvent = [EmailStatus.OPENED, EmailStatus.CLICKED].includes( - mailStatus, - ); + const isEngagementEvent = + mailStatus === EmailStatus.OPENED || mailStatus === EmailStatus.CLICKED; const existingMailEvent = email.campaignId || isEngagementEvent ? await db.emailEvent.findFirst({ From 255a718eba76066bec83d79b22388f2214777e3b Mon Sep 17 00:00:00 2001 From: KM Koushik Date: Mon, 13 Jul 2026 14:12:51 +1000 Subject: [PATCH 2/2] ci: add web type check --- .github/workflows/test-web.yml | 3 +++ apps/web/package.json | 1 + 2 files changed, 4 insertions(+) diff --git a/.github/workflows/test-web.yml b/.github/workflows/test-web.yml index 8ca3b507..aaf0374f 100644 --- a/.github/workflows/test-web.yml +++ b/.github/workflows/test-web.yml @@ -70,6 +70,9 @@ jobs: - name: Generate Prisma client run: pnpm --filter=web db:generate + - name: Type check + run: pnpm --filter=web typecheck + - name: Prepare test database schema run: pnpm --filter=web test:integration:prepare diff --git a/apps/web/package.json b/apps/web/package.json index c2d559db..4a5e7ebe 100644 --- a/apps/web/package.json +++ b/apps/web/package.json @@ -19,6 +19,7 @@ "test:integration": "RUN_INTEGRATION=true vitest run -c vitest.integration.config.ts", "test:integration:full": "pnpm test:integration:prepare:local && pnpm test:integration", "test:coverage": "vitest run -c vitest.default.config.ts --coverage", + "typecheck": "tsc --noEmit --pretty false", "db:post-install": "prisma generate", "db:generate": "prisma generate", "db:push": "prisma db push --skip-generate",