refactor: remove GetActiveTimelineClipInto() (#425)

* already moved to FilmInternalUtilities

Author: sindharta

Runtime/Scripts/Features/BasePlayableMixer.cs

@@ -1,4 +1,5 @@
 using System.Collections.Generic;
+using Unity.FilmInternalUtilities;
 using UnityEngine;
 using UnityEngine.Assertions;
 using UnityEngine.Playables;
@@ -35,7 +36,8 @@ public override void ProcessFrame(Playable playable, FrameData info, object play
             return;
         }
 
-        GetActiveTimelineClipInto(m_clips, m_playableDirector.time, out TimelineClip clip, out T activePlayableAsset);        
+        TimelineUtility.GetActiveTimelineClipInto(m_clips, m_playableDirector.time, out TimelineClip clip, 
+            out T activePlayableAsset);
         if (null == clip)
             return;
 
@@ -47,59 +49,6 @@ public override void ProcessFrame(Playable playable, FrameData info, object play
 
     #endregion IPlayableBehaviour interfaces
 
-
-//----------------------------------------------------------------------------------------------------------------------
-    
-    internal static void GetActiveTimelineClipInto( IList<TimelineClip> sortedClips, double directorTime, 
-        out TimelineClip outClip, out T outAsset) {
-
-        TimelineClip prevClipWithPostExtrapolation = null;
-        TimelineClip nextClipWithPreExtrapolation  = null;
-        bool         nextClipChecked               = false; 
-               
-        foreach (TimelineClip clip in sortedClips) {
-
-
-            if (directorTime < clip.start) {
-                //must check only once since we loop from the start
-                if (!nextClipChecked) { 
-                    //store next direct clip which has PreExtrapolation
-                    nextClipWithPreExtrapolation = clip.hasPreExtrapolation ? clip : null;
-                    nextClipChecked              = true;
-                }
-
-                continue;
-            }
-
-            if (clip.end < directorTime) {
-                //store prev direct clip which has PostExtrapolation
-                prevClipWithPostExtrapolation = clip.hasPostExtrapolation ? clip : null;
-                continue;                
-            }
-
-            outClip  = clip;
-            outAsset = clip.asset as T;
-            return;
-        }
-        
-        
-        //check for post-extrapolation
-        if (null != prevClipWithPostExtrapolation) {
-            outClip  = prevClipWithPostExtrapolation;
-            outAsset = prevClipWithPostExtrapolation.asset as T;
-            return;
-        }
-
-        //check pre-extrapolation for the first clip
-        if (null!=nextClipWithPreExtrapolation) {
-            outClip  = nextClipWithPreExtrapolation;
-            outAsset = nextClipWithPreExtrapolation.asset as T;
-            return;
-        }        
-        outClip  = null;
-        outAsset = null;
-    }
-    
 //----------------------------------------------------------------------------------------------------------------------
 
     internal void Init(GameObject go, PlayableDirector director, IEnumerable<TimelineClip> clips) {

Runtime/Scripts/Features/SIS/StreamingImageSequenceTrack.cs

@@ -115,7 +115,7 @@ private void ValidateClipDataCurves() {
     /// </returns>
     internal StreamingImageSequencePlayableAsset GetActivePlayableAsset() {
         double time = (null != m_trackMixer ) ? m_trackMixer.GetDirectorTime() : 0;
-        StreamingImageSequencePlayableMixer.GetActiveTimelineClipInto(m_Clips, time,
+        FilmInternalUtilities.TimelineUtility.GetActiveTimelineClipInto(m_Clips, time,
             out TimelineClip clip, out StreamingImageSequencePlayableAsset asset
         );
         return asset;