Fix units setup in vector projection Poisson test#227
Open
ss2098 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes
test_vector_projection_after_poisson_with_units()by setting model reference quantities before creating meshes andMeshVariableobjects with physical units.The test previously failed in strict units mode with:
What changed
Added reference quantity setup at the start of
test_vector_projection_after_poisson_with_units():Rationale
Strict units mode requires model reference quantities to be configured before creating variables with units. This updates the test setup to match the current units-system behavior. The Poisson solve and vector projection logic are unchanged.
Testing
Ran:
Output: