Skip to content
This repository was archived by the owner on Jan 6, 2026. It is now read-only.

Commit a1cb2a1

Browse files
committed
fix(transformers): more import problems...
1 parent 81d7b92 commit a1cb2a1

4 files changed

Lines changed: 38 additions & 36 deletions

File tree

emm/indexing/__init__.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,10 +61,9 @@
6161

6262
# Optional Sentence Transformer support
6363
try:
64-
import sentence_transformers
6564
from emm.indexing.pandas_sentence_transformer import PandasSentenceTransformerIndexer
6665
__all__.extend([
6766
"PandasSentenceTransformerIndexer"
6867
])
6968
except ImportError:
70-
pass
69+
pass # Transformer features unavailable

emm/models/sentence_transformer/__init__.py

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,12 @@
77
from __future__ import annotations
88

99
from emm.models.sentence_transformer.base import BaseSentenceTransformerComponent
10-
from emm.models.sentence_transformer.tuning import TuningConfig, SentenceTransformerTuner
1110

12-
__all__ = [
13-
"BaseSentenceTransformerComponent",
14-
"TuningConfig",
15-
"SentenceTransformerTuner"
16-
]
11+
__all__ = ["BaseSentenceTransformerComponent"]
12+
13+
# Move optional imports inside try block
14+
try:
15+
from emm.models.sentence_transformer.tuning import TuningConfig, SentenceTransformerTuner
16+
__all__ += ["TuningConfig", "SentenceTransformerTuner"]
17+
except ImportError:
18+
pass

emm/pipeline/pandas_entity_matching.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,14 @@
3636
from emm.indexing.pandas_cos_sim_matcher import PandasCosSimIndexer
3737
from emm.indexing.pandas_naive_indexer import PandasNaiveIndexer
3838
from emm.indexing.pandas_sni import PandasSortedNeighbourhoodIndexer
39-
from emm.indexing.pandas_sentence_transformer import PandasSentenceTransformerIndexer
39+
40+
# Make sentence transformer import optional
41+
try:
42+
from emm.indexing.pandas_sentence_transformer import PandasSentenceTransformerIndexer
43+
_HAS_SENTENCE_TRANSFORMER = True
44+
except ImportError:
45+
_HAS_SENTENCE_TRANSFORMER = False
46+
4047
from emm.loggers import Timer
4148
from emm.loggers.logger import logger
4249
from emm.parameters import DEFAULT_CARRY_ON_COLS, MODEL_PARAMS

pyproject.toml

Lines changed: 21 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -37,27 +37,30 @@ dependencies = [
3737
dynamic = ["version"]
3838

3939
[project.optional-dependencies]
40-
spark = [
41-
# In NumPy 1.24.0, np.bool has been removed.
42-
# https://issues.apache.org/jira/browse/SPARK-41718
43-
# 3.4 is needed for python 3.11
44-
# https://github.com/apache/spark/pull/38987
45-
"pyspark>=3.1; python_version < '3.11'",
46-
"numpy<1.24.0",
40+
transformers = [
41+
"sentence-transformers>=2.2.0",
42+
"torch>=1.11.0"
43+
]
44+
45+
tuning = [
46+
"lightning",
47+
"wandb",
48+
"sentence-transformers>=2.2.0", # Include transformer deps since tuning requires it
49+
"torch>=1.11.0"
4750
]
51+
4852
dev = [
49-
"pre-commit",
50-
"gitpython",
51-
"nbconvert",
52-
"jupyter_client>=5.2.3",
53-
"ipykernel>=5.1.3",
54-
"matplotlib",
55-
"pygments",
56-
"pandoc",
57-
"pympler",
58-
"sentence-transformers>=2.2.0",
59-
"torch>=1.11.0"
53+
"pre-commit",
54+
"gitpython",
55+
"nbconvert",
56+
"jupyter_client>=5.2.3",
57+
"ipykernel>=5.1.3",
58+
"matplotlib",
59+
"pygments",
60+
"pandoc",
61+
"pympler"
6062
]
63+
6164
test = [
6265
"pytest",
6366
"pytest-ordering",
@@ -97,15 +100,6 @@ doc = [
97100
"myst_parser"
98101
]
99102

100-
transformers = [
101-
"sentence-transformers",
102-
]
103-
104-
tuning = [
105-
"lightning",
106-
"wandb"
107-
]
108-
109103
[tool.pytest.ini_options]
110104
filterwarnings = [
111105
# DeprecationWarning: distutils Version classes are deprecated. Use packaging.version instead.

0 commit comments

Comments
 (0)