From 1ebf887357df5afc6e31ff19825eb9f4784a56a9 Mon Sep 17 00:00:00 2001 From: Matheus Aguiar Date: Wed, 17 Dec 2025 17:28:00 -0300 Subject: [PATCH 1/5] set version to 0.8.33 --- CMakeLists.txt | 2 +- Changelog.md | 9 +++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index f4d67e243bab..5792563eb3c0 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -21,7 +21,7 @@ include(EthPolicy) eth_policy() # project name and version should be set after cmake_policy CMP0048 -set(PROJECT_VERSION "0.8.32") +set(PROJECT_VERSION "0.8.33") # OSX target needed in order to support std::visit set(CMAKE_OSX_DEPLOYMENT_TARGET "10.14") project(solidity VERSION ${PROJECT_VERSION} LANGUAGES C CXX) diff --git a/Changelog.md b/Changelog.md index ad0916815d64..9f533332e147 100644 --- a/Changelog.md +++ b/Changelog.md @@ -1,3 +1,12 @@ +### 0.8.33 (unreleased) + +Language Features: + +Compiler Features: + +Bugfixes: + + ### 0.8.32 (2025-12-18) Important Bugfixes: From c6aecabaddc313dd81d28bc2a4e47434d4c1b95f Mon Sep 17 00:00:00 2001 From: rodiazet Date: Thu, 18 Dec 2025 14:51:27 +0100 Subject: [PATCH 2/5] Remove the sanity check. --- libsolidity/analysis/TypeChecker.cpp | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/libsolidity/analysis/TypeChecker.cpp b/libsolidity/analysis/TypeChecker.cpp index ab8f00a3082b..8556487ff4ca 100644 --- a/libsolidity/analysis/TypeChecker.cpp +++ b/libsolidity/analysis/TypeChecker.cpp @@ -3409,16 +3409,6 @@ bool TypeChecker::visit(MemberAccess const& _memberAccess) if (!annotation.isPure.set()) annotation.isPure = false; - if ( - auto const* funcType = dynamic_cast(annotation.type); - funcType && - funcType->kind() != FunctionType::Kind::Declaration && - funcType->kind() != FunctionType::Kind::Internal && - funcType->kind() != FunctionType::Kind::Error && - funcType->kind() != FunctionType::Kind::Event - ) - solAssert(funcType->isPure() == *annotation.isPure); - return false; } From 27af4dcfb9247707efe002d0ce6aac9185fdbd72 Mon Sep 17 00:00:00 2001 From: rodiazet Date: Thu, 18 Dec 2025 14:57:57 +0100 Subject: [PATCH 3/5] Add tests. --- .../syntaxTests/constants/access_via_getter.sol | 8 ++++++++ .../syntaxTests/immutable/access_via_getter.sol | 8 ++++++++ 2 files changed, 16 insertions(+) create mode 100644 test/libsolidity/syntaxTests/constants/access_via_getter.sol create mode 100644 test/libsolidity/syntaxTests/immutable/access_via_getter.sol diff --git a/test/libsolidity/syntaxTests/constants/access_via_getter.sol b/test/libsolidity/syntaxTests/constants/access_via_getter.sol new file mode 100644 index 000000000000..686c5a03927e --- /dev/null +++ b/test/libsolidity/syntaxTests/constants/access_via_getter.sol @@ -0,0 +1,8 @@ +contract Counter { + uint256 public constant MIN_LIQUIDITY = 1000; + + function run() view public { + this.MIN_LIQUIDITY(); + } +} +// ---- diff --git a/test/libsolidity/syntaxTests/immutable/access_via_getter.sol b/test/libsolidity/syntaxTests/immutable/access_via_getter.sol new file mode 100644 index 000000000000..6ce9e42c4301 --- /dev/null +++ b/test/libsolidity/syntaxTests/immutable/access_via_getter.sol @@ -0,0 +1,8 @@ +contract Counter { + uint256 public immutable MIN_LIQUIDITY = 1000; + + function run() view public { + this.MIN_LIQUIDITY(); + } +} +// ---- From 07bf6e13a88a6f831b2b0055214aa8bc6cf75f09 Mon Sep 17 00:00:00 2001 From: rodiazet Date: Thu, 18 Dec 2025 15:04:37 +0100 Subject: [PATCH 4/5] Update changelog. --- Changelog.md | 1 + 1 file changed, 1 insertion(+) diff --git a/Changelog.md b/Changelog.md index 9f533332e147..61bde4e259f7 100644 --- a/Changelog.md +++ b/Changelog.md @@ -5,6 +5,7 @@ Language Features: Compiler Features: Bugfixes: +* TypeChecker: Fix internal error when accessing getters of constant variables. ### 0.8.32 (2025-12-18) From c8ebb1104691ddcb463bcdbc5f9a5fa743de33ab Mon Sep 17 00:00:00 2001 From: Nikola Matic Date: Thu, 18 Dec 2025 17:36:49 +0100 Subject: [PATCH 5/5] Sort changelog and date for 0.8.33 --- Changelog.md | 6 +----- docs/bugs_by_version.json | 4 ++++ 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Changelog.md b/Changelog.md index 61bde4e259f7..cb78695bc5e3 100644 --- a/Changelog.md +++ b/Changelog.md @@ -1,8 +1,4 @@ -### 0.8.33 (unreleased) - -Language Features: - -Compiler Features: +### 0.8.33 (2025-12-18) Bugfixes: * TypeChecker: Fix internal error when accessing getters of constant variables. diff --git a/docs/bugs_by_version.json b/docs/bugs_by_version.json index 2ecc3c235606..8a4d2fe23b00 100644 --- a/docs/bugs_by_version.json +++ b/docs/bugs_by_version.json @@ -2053,6 +2053,10 @@ "bugs": [], "released": "2025-12-18" }, + "0.8.33": { + "bugs": [], + "released": "2025-12-18" + }, "0.8.4": { "bugs": [ "LostStorageArrayWriteOnSlotOverflow",