fix(webapp): drop Keep digging once the turn has already kept digging

Author: kathiekiwi

apps/webapp/app/components/dashboard-agent/DashboardAgentMessages.tsx

@@ -22,6 +22,7 @@ import { stripModelImages } from "./model-markdown";
 import { reportBlockFromToolPart } from "./report-block-adapter";
 import { shouldShowLiveTurnError } from "./turn-error";
 import type { ResolvedUri } from "./ReportView";
+import { answerContinuesAfter } from "./view-actions";
 import { ViewBlocks } from "./view-catalog";
 
 export type { TurnActivity };
@@ -240,6 +241,7 @@ const DashboardAgentTurn = memo(function DashboardAgentTurn({
               onIntent={onIntent}
               resolveUri={resolveUri}
               pagePaths={pagePaths}
+              answered={answerContinuesAfter(parts as never, i)}
             />
           </ChatCardSlot>
         );

apps/webapp/app/components/dashboard-agent/InvestigationCard.tsx

@@ -139,11 +139,14 @@ export function InvestigationCard({
   defaultExpanded = false,
   resolveUri,
   onIntent,
+  answered = false,
 }: {
   block: InvestigationBlock;
   defaultExpanded?: boolean;
   resolveUri?: ResolveUri;
   onIntent?: (intent: AgentIntent) => void;
+  /** The turn kept answering after this card, so "keep digging" has nothing to ask for. */
+  answered?: boolean;
 }) {
   const [expanded, setExpanded] = useState(defaultExpanded);
   const investigation = block.investigation;
@@ -237,7 +240,12 @@ export function InvestigationCard({
           ) : null}
         </div>
 
-        <InvestigationActions actions={block.capabilities?.actions ?? []} onIntent={onIntent} />
+        <InvestigationActions
+          actions={(block.capabilities?.actions ?? []).filter(
+            (action) => !answered || action.kind !== "ask_follow_up"
+          )}
+          onIntent={onIntent}
+        />
       </AgentCardBody>
     </AgentCard>
   );

apps/webapp/app/components/dashboard-agent/view-actions.test.ts

@@ -1,7 +1,7 @@
 import type { ActionsBlockAction } from "@internal/dashboard-agent-contracts";
 import { readFileSync } from "node:fs";
 import { describe, expect, it } from "vitest";
-import { renderableActions } from "./view-actions";
+import { answerContinuesAfter, renderableActions } from "./view-actions";
 
 const askAction: ActionsBlockAction = {
   label: "Investigate it",
@@ -32,6 +32,21 @@ describe("renderableActions", () => {
   });
 });
 
+describe("keep digging, only while there is digging left", () => {
+  const card = { type: "data-view" };
+  const text = (t: string) => ({ type: "text", text: t });
+
+  it("sees the answer the turn went on to give", () => {
+    expect(answerContinuesAfter([card, text("so here is why")] as never, 0)).toBe(true);
+  });
+
+  it("leaves a card the turn ended on", () => {
+    expect(answerContinuesAfter([text("looking"), card] as never, 1)).toBe(false);
+    // An empty trailing text part is not an answer.
+    expect(answerContinuesAfter([card, text("  ")] as never, 0)).toBe(false);
+  });
+});
+
 describe("ActionsBlock", () => {
   const source = readFileSync(new URL("./ActionsBlock.tsx", import.meta.url), "utf8");
 

apps/webapp/app/components/dashboard-agent/view-actions.ts

@@ -14,3 +14,14 @@ export function renderableActions<T extends CardAction>(actions: T[]): T[] {
     return intent.kind !== "navigate" || isTriggerUri(intent.target);
   });
 }
+
+/**
+ * "Keep digging" asks the agent to carry on — which is pointless once it already has.
+ * A turn that renders an inconclusive card and then keeps answering leaves the button
+ * offering work that is already done.
+ */
+export function answerContinuesAfter(parts: { type: string; text?: string }[], index: number) {
+  return parts
+    .slice(index + 1)
+    .some((part) => part.type === "text" && (part.text ?? "").trim().length > 0);
+}

apps/webapp/app/components/dashboard-agent/view-catalog.tsx

@@ -13,11 +13,14 @@ export function ViewBlocks({
   onIntent,
   resolveUri,
   pagePaths,
+  answered = false,
 }: {
   blocks: ViewBlock[];
   onIntent?: (intent: AgentIntent) => void;
   resolveUri?: (uri: string) => ResolvedUri | null;
   pagePaths?: Record<string, string>;
+  /** The turn kept answering after this card, so "keep digging" has nothing to ask for. */
+  answered?: boolean;
 }) {
   if (!Array.isArray(blocks)) return null;
   return (
@@ -41,6 +44,7 @@ export function ViewBlocks({
                 block={block}
                 resolveUri={resolveUri}
                 onIntent={onIntent}
+                answered={answered}
               />
             );
           case "report":