fix(supervisor,helm): validate the cell name in the chart and give the attempt-start test its own port

Author: myftija

apps/supervisor/src/workloadServer/workloadServer.attemptStart.test.ts

@@ -12,7 +12,7 @@ vi.mock("std-env", () => ({
 
 const { WorkloadServer } = await import("./index.js");
 
-const PORT = 18733;
+const PORT = 18734;
 const BASE = `http://127.0.0.1:${PORT}`;
 
 const startRunAttempt = vi.fn(async () => ({

hosting/k8s/helm/templates/supervisor.yaml

@@ -180,6 +180,9 @@ spec:
                 fieldRef:
                   fieldPath: spec.nodeName
             {{- if .Values.supervisor.config.cellName }}
+            {{- if not (regexMatch "^[A-Za-z0-9][A-Za-z0-9._-]{0,63}$" .Values.supervisor.config.cellName) }}
+            {{- fail "supervisor.config.cellName must be 1-64 characters of letters, digits, dots, underscores or dashes, starting with a letter or digit. The supervisor refuses anything else at boot." }}
+            {{- end }}
             - name: TRIGGER_WORKER_CELL_NAME
               value: {{ .Values.supervisor.config.cellName | quote }}
             {{- end }}