feat(alerts): evaluate alerts every minute

Alerts are now checked every minute instead of every 5–10 minutes, so
they raise and recover sooner.

Mono-RevId: f147b6afe8616cecb53c38a6da5d3a6758e7caf8

Author: kathiekiwi

.server-changes/alerts-cadence.md

@@ -0,0 +1,6 @@
+---
+area: webapp
+type: improvement
+---
+
+Alerts are now checked every minute instead of every 5–10 minutes, so they raise and recover sooner.

apps/webapp/app/env.server.ts

@@ -1092,7 +1092,7 @@ const EnvironmentSchema = z
 
     /** These enable the alerts feature in v3 */
     ALERT_EMAIL_TRANSPORT: z.enum(["resend", "smtp", "aws-ses"]).optional(),
-    ALERT_EVALUATION_CADENCE_CAP_SEC: z.coerce.number().int().positive().optional(),
+    ALERT_EVALUATION_CADENCE_CAP_SEC: z.coerce.number().int().positive().default(60),
     ALERT_FROM_EMAIL: z.string().optional(),
     ALERT_REPLY_TO_EMAIL: z.string().optional(),
     ALERT_RESEND_API_KEY: z.string().optional(),

apps/webapp/app/v3/services/alerts/engine/evaluateAlert.server.test.ts

@@ -154,6 +154,22 @@ describe("evaluateAlert", () => {
     expect(deliveries.every((d) => d.status === "pending")).toBe(true);
   });
 
+  it("schedules the next evaluation within a minute for a 600s capability", async () => {
+    await createAlert(db, {
+      ...BASE,
+      capabilityKey: "queue.oldest_age",
+      condition: { kind: "threshold", operator: ">", value: 100, windowSec: 600 },
+    });
+    const now = new Date();
+    const claimed = await claimOne(now);
+
+    await evaluateAlert(claimed, { db, evaluateBinding: bindingFor(notMetResult()) });
+
+    const next = (await getAlert(db, { id: claimed.id }))!.nextEvaluationAt!.getTime();
+    expect(next).toBeGreaterThan(now.getTime());
+    expect(next - now.getTime()).toBeLessThanOrEqual(60_000);
+  });
+
   it("stateful met->met writes nothing (no duplicate raise)", async () => {
     await createAlert(db, { ...BASE, attention: "needs_attention", observedCondition: "met" });
     const now = new Date();
@@ -1057,7 +1073,7 @@ describe("unavailable reason tracking", () => {
 
   it("successful evaluation schedules the next grid slot, not now + cadence", async () => {
     const alert = await createAlert(db, { ...BASE });
-    const cadenceMs = 300_000;
+    const cadenceMs = 60_000;
     const phase = alertPhaseOffsetMs(alert.id);
     const slot = Math.floor((Date.now() - phase) / cadenceMs) * cadenceMs + phase;
     const due = new Date(slot - cadenceMs);
@@ -1089,7 +1105,7 @@ describe("unavailable reason tracking", () => {
 
     const after = (await getAlert(db, { id: alert.id }))!;
     const phase = alertPhaseOffsetMs(alert.id);
-    const expected = (Math.floor((now.getTime() - phase) / 300_000) + 1) * 300_000 + phase;
+    const expected = (Math.floor((now.getTime() - phase) / 60_000) + 1) * 60_000 + phase;
     expect(after.nextEvaluationAt!.getTime()).toBe(expected);
   });
 

apps/webapp/app/v3/services/alerts/engine/evaluateAlertJob.server.test.ts

@@ -231,7 +231,7 @@ describe("runEvaluateAlertJob", () => {
       expect.objectContaining({ alertId: alert.id, capabilityKey: alert.capabilityKey }),
     ]);
     const nextAt = (await job(worker, alert.id))!.timestamp.getTime();
-    const cadenceMs = getCapability(alert.capabilityKey)!.minCadenceSec * 1000;
+    const cadenceMs = Math.min(getCapability(alert.capabilityKey)!.minCadenceSec, 60) * 1000;
     expect(nextAt).toBeGreaterThan(startedAt);
     expect((nextAt - alertPhaseOffsetMs(alert.id)) % cadenceMs).toBe(0);
     expect((await getAlert(db, { id: alert.id }))!.nextEvaluationAt!.getTime()).toBe(nextAt);