Add parameter and return type hints where possible

Author: chadicus

src/Authentication.php

@@ -41,16 +41,14 @@ private function __construct(callable $getTokenRequestFunc)
      * @return Authentication
      */
     public static function createClientCredentials(
-        $clientId,
-        $clientSecret,
-        $refreshResource = 'token',
-        $tokenResource = 'token'
+        string $clientId,
+        string $clientSecret,
+        string $refreshResource = 'token',
+        string $tokenResource = 'token'
     ) : Authentication {
-        Util::throwIfNotType(['string' => [$clientId, $clientSecret]], true);
-
         $getTokenRequestFunc = function (
-            $baseUrl,
-            $refreshToken
+            string $baseUrl,
+            string $refreshToken = null
         ) use (
             $clientId,
             $clientSecret,
@@ -92,18 +90,16 @@ public static function createClientCredentials(
      * @return Authentication
      */
     public static function createOwnerCredentials(
-        $clientId,
-        $clientSecret,
-        $username,
-        $password,
-        $refreshResource = 'token',
-        $tokenResource = 'token'
+        string $clientId,
+        string $clientSecret,
+        string $username,
+        string $password,
+        string $refreshResource = 'token',
+        string $tokenResource = 'token'
     ) : Authentication {
-        Util::throwIfNotType(['string' => [$clientId, $clientSecret, $username, $password]], true);
-
         $getTokenRequestFunc = function (
-            $baseUrl,
-            $refreshToken
+            string $baseUrl,
+            string $refreshToken = null
         ) use (
             $clientId,
             $clientSecret,
@@ -166,16 +162,13 @@ public static function parseTokenResponse(ResponseInterface $response)
     /**
      * Creates a Request object for obtaining a new token from the API
      *
-     * @param string $baseUrl The base url of the API
-     * @param string $refreshToken The refresh token of the API
+     * @param string      $baseUrl      The base url of the API
+     * @param string|null $refreshToken The refresh token of the API
      *
      * @return RequestInterface
      */
-    public function getTokenRequest($baseUrl, $refreshToken) : RequestInterface
+    public function getTokenRequest(string $baseUrl, string $refreshToken = null) : RequestInterface
     {
-        Util::throwIfNotType(['string' => [$baseUrl]], true);
-        Util::throwIfNotType(['string' => [$refreshToken]], true, true);
-
         return call_user_func($this->getTokenRequestFunc, $baseUrl, $refreshToken);
     }
 
@@ -192,11 +185,11 @@ public function getTokenRequest($baseUrl, $refreshToken) : RequestInterface
      * @return RequestInterface The built token refresh request
      */
     private static function getRefreshTokenRequest(
-        $baseUrl,
-        $clientId,
-        $clientSecret,
-        $refreshResource,
-        $refreshToken
+        string $baseUrl,
+        string $clientId,
+        string $clientSecret,
+        string $refreshResource,
+        string $refreshToken
     ) : RequestInterface {
         //NOTE client_id and client_secret are needed for Apigee but are not in the oauth2 spec
         $data = [

src/Collection.php

@@ -72,10 +72,8 @@ final class Collection implements \Iterator, \Countable
      * @param string $resource name of API resource to request
      * @param array $filters key value pair array of search filters
      */
-    public function __construct(ClientInterface $client, $resource, array $filters = [])
+    public function __construct(ClientInterface $client, string $resource, array $filters = [])
     {
-        Util::throwIfNotType(['string' => [$resource]], true);
-
         $this->client = $client;
         $this->resource = $resource;
         $this->filters = $filters;
@@ -85,9 +83,9 @@ public function __construct(ClientInterface $client, $resource, array $filters =
     /**
      * @see Countable::count()
      *
-     * @return int
+     * @return integer
      */
-    public function count()
+    public function count() : int
     {
         if ($this->position === -1) {
             $this->next();
@@ -113,9 +111,9 @@ public function rewind()
     /**
      * @see Iterator::key()
      *
-     * @return int
+     * @return integer
      */
-    public function key()
+    public function key() : int
     {
         if ($this->position === -1) {
             $this->next();
@@ -131,7 +129,7 @@ public function key()
      *
      * @return bool
      */
-    public function valid()
+    public function valid() : bool
     {
         if ($this->position === -1) {
             $this->next();
@@ -172,7 +170,7 @@ public function next()
      *
      * @return array
      */
-    public function current()
+    public function current() : array
     {
         if ($this->position === -1) {
             $this->next();
@@ -193,9 +191,9 @@ public function current()
      *
      * @param string $key The name of the field for which the values will be returned.
      *
-     * @return iterable
+     * @return \Iterator
      */
-    public function column($key)
+    public function column(string $key) : \Iterator
     {
         foreach ($this as $item) {
             yield Util\Arrays::get($item, $key);
@@ -209,7 +207,7 @@ public function column($key)
      *
      * @return \Generator
      */
-    public function select(array $keys)
+    public function select(array $keys) : \Iterator
     {
         foreach ($this as $item) {
             $result = array_fill_keys($keys, null);