Use field name as the error array key

Author: jncarver

src/Filterer.php

@@ -346,7 +346,7 @@ private static function assertIfAliasExists($alias, bool $overwrite)
     private static function checkForUnknowns(array $leftOverInput, array $errors) : array
     {
         foreach ($leftOverInput as $field => $value) {
-            $errors[] = "Field '{$field}' with value '" . trim(var_export($value, true), "'") . "' is unknown";
+            $errors[$field] = "Field '{$field}' with value '" . trim(var_export($value, true), "'") . "' is unknown";
         }
 
         return $errors;
@@ -364,7 +364,7 @@ private static function handleAllowUnknowns(bool $allowUnknowns, array $leftOver
     private static function handleRequiredFields(bool $required, string $field, array $errors) : array
     {
         if ($required) {
-            $errors[] = "Field '{$field}' was required and not present";
+            $errors[$field] = "Field '{$field}' was required and not present";
         }
         return $errors;
     }
@@ -402,7 +402,7 @@ private static function handleCustomError(
             );
         }
 
-        $errors[] = str_replace('{value}', trim(var_export($value, true), "'"), $error);
+        $errors[$field] = str_replace('{value}', trim(var_export($value, true), "'"), $error);
         return $errors;
     }
 

tests/FiltererTest.php

@@ -245,6 +245,26 @@ public function filterReturnsResponseType()
         $this->assertSame([], $result->unknowns);
     }
 
+    /**
+     * @test
+     * @covers ::filter
+     */
+    public function filterReturnsResponseTypeWithErrors()
+    {
+        $specification = ['name' => [['string']]];
+        $input = ['name' => 'foo', 'id' => 1];
+        $options = ['responseType' => Filterer::RESPONSE_TYPE_FILTER];
+
+        $result = Filterer::filter($specification, $input, $options);
+
+        $this->assertInstanceOf(FilterResponse::class, $result);
+        $this->assertSame(false, $result->success);
+        $this->assertSame(['name' => 'foo'], $result->filteredValue);
+        $this->assertSame(['id' => "Field 'id' with value '1' is unknown"], $result->errors);
+        $this->assertSame("Field 'id' with value '1' is unknown", $result->errorMessage);
+        $this->assertSame(['id' => 1], $result->unknowns);
+    }
+
     /**
      * @test
      * @covers ::filter