Merge pull request #77 from chadicus/master

chadicus · web-flow · commit a9949d3b2282 · 2018-12-12T09:43:05.000-05:00
Fix bug with custom error
diff --git a/src/Filterer.php b/src/Filterer.php
@@ -414,7 +414,7 @@ private static function assertFilterIsNotArray($filter, string $field)
         }
     }
 
-    private static function validateCustomError(array $filters, string $field)
+    private static function validateCustomError(array &$filters, string $field)
     {
         $customError = null;
         if (array_key_exists('error', $filters)) {
diff --git a/tests/FiltererTest.php b/tests/FiltererTest.php
@@ -405,8 +405,8 @@ public function filterWithCustomError()
         $result = Filterer::filter(
             [
                 'fieldOne' => [
+                    'error' => 'My custom error message',
                     ['\TraderInteractive\FiltererTest::failingFilter'],
-                    'error' => 'My custom error message'
                 ],
             ],
             ['fieldOne' => 'valueOne']

Original file line number	Diff line number	Diff line change
`@@ -414,7 +414,7 @@ private static function assertFilterIsNotArray($filter, string $field)`
`414`	`414`	`}`
`415`	`415`	`}`
`416`	`416`
`417`		`- private static function validateCustomError(array $filters, string $field)`
	`417`	`+ private static function validateCustomError(array &$filters, string $field)`
`418`	`418`	`{`
`419`	`419`	`$customError = null;`
`420`	`420`	`if (array_key_exists('error', $filters)) {`