Skip to content

Commit 7e2bd7e

Browse files
committed
Refactor uses to be filter specific
1 parent 1c78f3b commit 7e2bd7e

2 files changed

Lines changed: 5 additions & 4 deletions

File tree

src/Filterer.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,6 @@ public function execute(array $input) : FilterResponse
142142
unset($filters[FilterOptions::IS_REQUIRED]);//doesn't matter if required since we have this one
143143
unset($filters[FilterOptions::DEFAULT_VALUE]);//doesn't matter if there is a default since we have a value
144144
$conflicts = self::extractConflicts($filters, $field, $conflicts);
145-
$uses = self::extractUses($filters);
146145

147146
foreach ($filters as $filter) {
148147
self::assertFilterIsNotArray($filter, $field);
@@ -151,6 +150,8 @@ public function execute(array $input) : FilterResponse
151150
continue;
152151
}
153152

153+
$uses = self::extractUses($filter);
154+
154155
$function = array_shift($filter);
155156
$function = self::handleFilterAliases($function, $filterAliases);
156157

tests/FiltererTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -300,9 +300,9 @@ public function provideValidFilterData() : array
300300
'spec' => [
301301
'fieldOne' => [['uint']],
302302
'fieldTwo' => [
303-
FilterOptions::USES => ['fieldOne'],
304303
['uint'],
305304
[
305+
FilterOptions::USES => ['fieldOne'],
306306
function (int $input, int $fieldOneValue) : int {
307307
return $input * $fieldOneValue;
308308
},
@@ -328,9 +328,9 @@ function (int $input, int $fieldOneValue) : int {
328328
'spec' => [
329329
'fieldOne' => [['uint']],
330330
'fieldTwo' => [
331-
FilterOptions::USES => ['fieldOne'],
332331
['uint'],
333332
[
333+
FilterOptions::USES => ['fieldOne'],
334334
function (int $input, int $fieldOneValue) : int {
335335
return $input * $fieldOneValue;
336336
},
@@ -356,9 +356,9 @@ function (int $input, int $fieldOneValue) : int {
356356
'spec' => [
357357
'fieldOne' => [['uint']],
358358
'fieldTwo' => [
359-
FilterOptions::USES => ['fieldOne'],
360359
['uint'],
361360
[
361+
FilterOptions::USES => ['fieldOne'],
362362
function (int $input, int $fieldOneValue) : int {
363363
return $input * $fieldOneValue;
364364
},

0 commit comments

Comments
 (0)