Skip to content

Commit 91b26a8

Browse files
committed
Updated instructions in HACKING to include svn-python bindings; typo fixes and rewording in README
1 parent fce63fb commit 91b26a8

2 files changed

Lines changed: 36 additions & 22 deletions

File tree

HACKING

Lines changed: 30 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -2,30 +2,33 @@ YOU WANT TO CONTRIBUTE BUT YOU DON'T KNOW HOW? NO MORE SUCH EXCUSES
22

33
0. Install Trac
44

5-
On Mac OS X this is as easy as:
5+
In most cases this can be done via easy_install:
66

7-
# easy_install Trac
7+
# easy_install Trac==0.12
8+
9+
If you run into problems, see Trac documentation [1][2].
10+
11+
You will also need to install the Subversion python bindings. Some systems have packages for it (e.g. python-subversion on Debian)[3], but on OSX this means compiling them from source[4].
812

913
1. Create a test Trac install somewhere:
1014

11-
$ trac-admin <trac-name> initenv
15+
$ trac-admin <trac-name> initenv
1216

1317
The default offered values are good.
1418

15-
This will create a <trac-name> directory with the Trac install in the
16-
current directory.
19+
This will create a <trac-name> directory with the Trac install in the current directory.
1720

1821
2. Create a local SVN repo:
1922

20-
$ svnadmin create <repo-name>
23+
$ svnadmin create <repo-name>
2124

2225
3. Checkout the repo and add a dummy file:
2326

24-
$ svn co file://<full-path-to-svn-repo> # including leading slash, e.g. file:///home/username/svn-repo/
27+
$ svn co file://<full-path-to-svn-repo> # including leading slash, e.g. file:///home/username/svn-repo/
2528

2629
4. Add the repo in the trac.ini:
2730

28-
$ $EDITOR <trac-name>/conf/trac.ini
31+
$ $EDITOR <trac-name>/conf/trac.ini
2932

3033
Change:
3134

@@ -34,26 +37,37 @@ repository_type = svn
3437

3538
5. Create htpasswd file for Trac auth:
3639

37-
$ htpasswd -c <auth-file-name> <desired-username>
40+
$ htpasswd -c <auth-file-name> <desired-username>
3841

3942
Remember the file location.
4043

4144
6. Add yourself as admin:
4245

43-
$ $ trac-admin <trac-name> permission add <username> TRAC_ADMIN
46+
$ trac-admin <trac-name> permission add <username> TRAC_ADMIN
4447

4548
6. Run trac server:
4649

47-
$ tracd -s -r --port 8000 --basic-auth='<trac-name>,<full-path-to-auth-file-name>,<whatever-you-want>' <path-to-trac-folder> # see http://trac.edgewall.org/wiki/TracStandalone
50+
$ tracd -s -r --port 8000 --basic-auth='<trac-name>,<full-path-to-auth-file-name>,<whatever-you-want>' <path-to-trac-folder> # see http://trac.edgewall.org/wiki/TracStandalone
4851

4952
You should now have a working vanilla Trac at http://localhost:8000/, where you can log in and be an admin.
5053

51-
7. Checkout the plugin in R/W mode
54+
7. Checkout the plugin in R/W mode:
55+
56+
$ git clone git@github.com:Automattic/vip-trac-code-comments.git
57+
58+
8. From the plugin directory, deploy the plugin in development mode:
59+
60+
$ python setup.py develop -mxd <path-to-trac>/plugins
61+
62+
9. Restart Trac. Then in the Admin section in Trac, go to Plugins and enable all the components of the TracCodeComments plugin and also the CodeComments macro.
63+
64+
10. For debugging, you probably also want to enable logging in Trac by setting the log_type option to "file" in trac.ini.
5265

53-
$ git clone git@github.com:Automattic/vip-trac-code-comments.git
5466

55-
8. Deploy the plugin in development mode
5667

57-
$ python setup.py develop -mxd <path-to-trac>/plugins
68+
# Footnotes
5869

59-
9. Go to the Admin section in Trac, then Plugins and enable all the components of the TracCodeComments plugin and also the CodeComments macro
70+
[1] http://trac.edgewall.org/wiki/0.12/TracInstall
71+
[2] http://trac.edgewall.org/wiki/TracDev/DevelopmentEnvironmentSetup
72+
[3] http://trac.edgewall.org/wiki/TracSubversion#GettingSubversion
73+
[4] http://stackoverflow.com/questions/14538468/how-to-install-python-subversion-bindings-needed-by-hg-convert-on-mac-os-x-10-8/16950786#16950786

README.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ This plugin allows you to leave comments on top of files, changesets, and
1010
attachments. Once you've added all of your comments, you can send them to
1111
tickets. These include links to these comments and their description.
1212

13-
It's Github, in your Trac.
13+
It's GitHub, in your Trac.
1414

1515
Installation
1616
------------
@@ -55,23 +55,23 @@ Contributing
5555

5656
We'd love your help!
5757

58-
If you are a developer, feel free to fork the project here, on github and
58+
If you are a developer, feel free to fork the project here on GitHub, and
5959
submit a pull request with your changes.
6060

6161
If you are a designer and have UI suggestions, [open an issue](https://github.com/Automattic/trac-code-comments-plugin/issues), and we'll make sure to address your concerns.
6262

63-
If you want to help with copy, or just wanna say how great or sucky we are
63+
If you want to help with copy, or just wanna say how great or awful we are,
6464
[creating an issue](https://github.com/Automattic/trac-code-comments-plugin/issues) is the way to go.
6565

66-
You can find help with setting up a local development environment in the [`HACKING`](https://github.com/Automattic/trac-code-comments-plugin/blob/master/HACKING) file in this repostitory.
66+
You can find help with setting up a local development environment in the [`HACKING`](https://github.com/Automattic/trac-code-comments-plugin/blob/master/HACKING) file in this repository.
6767

6868
Roadmap
6969
-------
7070

7171
Nobody can predict the future, but here are some features on the roadmap:
7272

73-
* Line-level comments for changesets and diff atatchments, too
74-
* E-mail notifictaions
73+
* Line-level comments for changesets and diff attachments, too
74+
* E-mail notifications
7575

7676
License
7777
-------

0 commit comments

Comments
 (0)