Preserve rows below partial scroll regions#10
Open
jchristn wants to merge 3 commits into
Open
Conversation
c193f32 to
2532dce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IL/CSI Ps LandDL/CSI Ps Mwhen normal-buffer scrollback existsDL/CSI Ps Mwhen the cursor is outside the scroll region, matchingILWhy
Prompt-oriented terminal applications can reserve a bottom input/status row while scrolling output above it. A top-anchored partial scroll region must not promote the reserved row into scrollback.
The same visual artifact can occur after normal-buffer scrollback exists if insert/delete-line operations splice using viewport-relative
ScrollBottomrather thanYBase + ScrollBottom. In that case old scrollback rows can be edited instead of the active screen, allowing prompt/status content such as>or>to reappear higher in the viewport.DLalso needs the same scroll-region guard asIL; delete-line operations outside the active scroll region should be ignored so reserved prompt/status rows are not shifted.Tests
dotnet test src\XTerm.NET.slnx