Fix integration tests on windows

Author: rkoopmans

README.md

@@ -32,6 +32,14 @@ pip install -r requirements.txt -r test-requirements.txt
 nosetests
 ```
 
+To test more runtimes, tox can be used
+
+```
+tox
+```
+
+
+
 ### Integration tests
 
 ```

test/helper.py

@@ -1,6 +1,7 @@
 # -*- coding: utf-8 -*-
 from __future__ import absolute_import, division, print_function, unicode_literals
-
+from contextlib import contextmanager
+from tempfile import NamedTemporaryFile
 import json
 import sys
 import os
@@ -55,3 +56,18 @@ def assertJsonEqual(self, expected, actual):
     @property
     def request(self):
         return httpretty.last_request()
+
+
+
+@contextmanager
+def create_named_tmpfile():
+    #  Due to NamedTemporaryFile requiring to be closed when used on Windows
+    #   we create our own NamedTemporaryFile contextmanager
+    # See note: https://docs.python.org/3/library/tempfile.html#tempfile.NamedTemporaryFile
+
+    tmp = NamedTemporaryFile(delete=False)
+    try:
+        tmp.close()
+        yield tmp.name
+    finally:
+        os.unlink(tmp.name)

test/integration.py

@@ -1,4 +1,5 @@
 import sys, os
+from test.helper import create_named_tmpfile
 
 if not os.environ.get("TINIFY_KEY"):
     sys.exit("Set the TINIFY_KEY environment variable.")
@@ -13,11 +14,13 @@ class ClientIntegrationTest(unittest.TestCase):
     optimized = tinify.from_file(unoptimized_path)
 
     def test_should_compress_from_file(self):
-        with tempfile.NamedTemporaryFile() as tmp:
-            self.optimized.to_file(tmp.name)
+        with create_named_tmpfile() as tmp:
+            self.optimized.to_file(tmp)
 
-            size = os.path.getsize(tmp.name)
-            contents = tmp.read()
+            size = os.path.getsize(tmp)
+
+            with open(tmp, 'rb') as f:
+                contents = f.read()
 
             self.assertTrue(1000 < size < 1500)
 
@@ -27,11 +30,12 @@ def test_should_compress_from_file(self):
 
     def test_should_compress_from_url(self):
         source = tinify.from_url('https://raw.githubusercontent.com/tinify/tinify-python/master/test/examples/voormedia.png')
-        with tempfile.NamedTemporaryFile() as tmp:
-            source.to_file(tmp.name)
+        with create_named_tmpfile() as tmp:
+            source.to_file(tmp)
 
-            size = os.path.getsize(tmp.name)
-            contents = tmp.read()
+            size = os.path.getsize(tmp)
+            with open(tmp, 'rb') as f:
+                contents = f.read()
 
             self.assertTrue(1000 < size < 1500)
 
@@ -40,11 +44,12 @@ def test_should_compress_from_url(self):
             self.assertNotIn(b'Copyright Voormedia', contents)
 
     def test_should_resize(self):
-        with tempfile.NamedTemporaryFile() as tmp:
-            self.optimized.resize(method="fit", width=50, height=20).to_file(tmp.name)
+        with create_named_tmpfile() as tmp:
+            self.optimized.resize(method="fit", width=50, height=20).to_file(tmp)
 
-            size = os.path.getsize(tmp.name)
-            contents = tmp.read()
+            size = os.path.getsize(tmp)
+            with open(tmp, 'rb') as f:
+                contents = f.read()
 
             self.assertTrue(500 < size < 1000)
 
@@ -53,14 +58,15 @@ def test_should_resize(self):
             self.assertNotIn(b'Copyright Voormedia', contents)
 
     def test_should_preserve_metadata(self):
-        with tempfile.NamedTemporaryFile() as tmp:
-            self.optimized.preserve("copyright", "creation").to_file(tmp.name)
+        with create_named_tmpfile() as tmp:
+            self.optimized.preserve("copyright", "creation").to_file(tmp)
 
-            size = os.path.getsize(tmp.name)
-            contents = tmp.read()
+            size = os.path.getsize(tmp)
+            with open(tmp, 'rb') as f:
+                contents = f.read()
 
             self.assertTrue(1000 < size < 2000)
 
             # width == 137
             self.assertIn(b'\x00\x00\x00\x89', contents)
-            self.assertIn(b'Copyright Voormedia', contents)
+            self.assertIn(b'Copyright Voormedia', contents)

test/tinify_source_test.py

@@ -147,6 +147,7 @@ def test_to_file_with_path_should_store_image_data(self):
             self.assertEqual(b'compressed file', tmp.read())
 
     def test_to_file_with_file_object_should_store_image_data(self):
-        with tempfile.NamedTemporaryFile() as tmp:
-            Source.from_buffer('png file').to_file(tmp.name)
-            self.assertEqual(b'compressed file', tmp.read())
+        with create_named_tmpfile() as name:
+            Source.from_buffer('png file').to_file(name)
+            with open(name, 'rb') as f:
+                self.assertEqual(b'compressed file', f.read())