fix: use database version for update migrations and always reset maintenance mode

setVersion() was called with System::getVersion() (the installed code
version, e.g. 4.1.0) instead of the database version (e.g. 4.0.18).
This caused version_compare('4.1.0', '4.1.0-alpha', '<') to return
false, skipping all 4.1 database migrations and leaving the version
number unchanged at 4.0.18.

Additionally, maintenance mode is now reset to false in all error paths
and the catch block handles both phpMyFAQ\Core\Exception and \Exception,
preventing admin lockout when the database update fails.

Author: thorsten

phpmyfaq/src/phpMyFAQ/Controller/Administration/Api/UpdateController.php

@@ -245,16 +245,18 @@ public function updateDatabase(): JsonResponse
         $this->userHasPermission(PermissionType::CONFIGURATION_EDIT);
 
         $update = $this->container->get(id: 'phpmyfaq.setup.update');
-        $update->setVersion(System::getVersion());
+        $update->setVersion($this->configuration->get('main.currentVersion'));
 
         try {
             if ($update->applyUpdates()) {
                 $this->configuration->set('main.maintenanceMode', 'false');
                 return new JsonResponse(['success' => 'Database successfully updated.'], Response::HTTP_OK);
             }
 
+            $this->configuration->set('main.maintenanceMode', 'false');
             return new JsonResponse(['error' => 'Update database failed.'], Response::HTTP_BAD_GATEWAY);
-        } catch (Exception $exception) {
+        } catch (Exception|\Exception $exception) {
+            $this->configuration->set('main.maintenanceMode', 'false');
             return new JsonResponse([
                 'error' => 'Update database failed: ' . $exception->getMessage(),
             ], Response::HTTP_BAD_GATEWAY);

phpmyfaq/src/phpMyFAQ/Setup/UpdateRunner.php

@@ -204,7 +204,7 @@ private function taskInstallPackage(SymfonyStyle $io): int
     private function taskUpdateDatabase(SymfonyStyle $io): int
     {
         $update = new Update($this->system, $this->configuration);
-        $update->setVersion(System::getVersion());
+        $update->setVersion($this->configuration->get('main.currentVersion'));
 
         $progressBar = $io->createProgressBar(max: 100);
         $progressBar->start();
@@ -220,11 +220,13 @@ private function taskUpdateDatabase(SymfonyStyle $io): int
                 return Command::SUCCESS;
             }
 
+            $this->configuration->set(key: 'main.maintenanceMode', value: 'false');
             $io->error(message: 'Update database failed.');
             return Command::FAILURE;
-        } catch (Exception $exception) {
+        } catch (Exception|\Exception $exception) {
             $progressBar->finish();
             $io->newLine(count: 2);
+            $this->configuration->set(key: 'main.maintenanceMode', value: 'false');
             $io->error(message: 'Update database failed: ' . $exception->getMessage());
             return Command::FAILURE;
         }