build: added coverage report to GitHub pages

Author: thorsten

.github/workflows/coverage-to-pages.yml

@@ -0,0 +1,90 @@
+name: Code Coverage → GitHub Pages
+
+on:
+  push:
+    branches: [main]
+  # Optional: Manuelles Triggern über die GitHub UI
+  workflow_dispatch:
+
+# Sicherstellen, dass immer nur ein Deployment gleichzeitig läuft
+concurrency:
+  group: pages
+  cancel-in-progress: true
+
+permissions:
+  contents: read
+  pages: write
+  id-token: write
+
+jobs:
+  coverage:
+    name: Generate Coverage & Deploy
+    runs-on: ubuntu-latest
+
+    environment:
+      name: github-pages
+      url: ${{ steps.deployment.outputs.page_url }}
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: '8.5'
+          extensions: mbstring, xml, dom
+          coverage: pcov
+
+      - name: Validate composer.json
+        run: composer validate --strict
+
+      - name: Cache Composer packages
+        uses: actions/cache@v4
+        with:
+          path: vendor
+          key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
+          restore-keys: |
+            ${{ runner.os }}-composer-
+
+      - name: Install dependencies
+        run: composer install --no-interaction --prefer-dist
+
+      - name: Run tests with coverage
+        run: |
+          php -dxdebug.mode=coverage vendor/bin/phpunit \
+            --coverage-html build/coverage \
+            --coverage-clover build/coverage/clover.xml
+
+      # Optional: Coverage-Zusammenfassung in der GitHub Actions Summary anzeigen
+      - name: Coverage Summary
+        if: always()
+        run: |
+          if [ -f build/coverage/clover.xml ]; then
+            echo "## Code Coverage Report" >> $GITHUB_STEP_SUMMARY
+            echo "" >> $GITHUB_STEP_SUMMARY
+
+            # Gesamtabdeckung aus clover.xml extrahieren
+            COVERED=$(grep -oP 'coveredstatements="\K[0-9]+' build/coverage/clover.xml | tail -1)
+            TOTAL=$(grep -oP 'statements="\K[0-9]+' build/coverage/clover.xml | tail -1)
+
+            if [ -n "$COVERED" ] && [ -n "$TOTAL" ] && [ "$TOTAL" -gt 0 ]; then
+              PERCENT=$(awk "BEGIN { printf \"%.1f\", ($COVERED/$TOTAL)*100 }")
+              echo "**Gesamtabdeckung: ${PERCENT}%** (${COVERED}/${TOTAL} Statements)" >> $GITHUB_STEP_SUMMARY
+            fi
+
+            echo "" >> $GITHUB_STEP_SUMMARY
+            echo "📊 [Vollständiger Report](${{ steps.deployment.outputs.page_url }})" >> $GITHUB_STEP_SUMMARY
+          fi
+
+      - name: Setup Pages
+        uses: actions/configure-pages@v4
+
+      - name: Upload artifact
+        uses: actions/upload-pages-artifact@v3
+        with:
+          path: build/coverage
+
+      - name: Deploy to GitHub Pages
+        id: deployment
+        uses: actions/deploy-pages@v4

composer.lock

@@ -52,17 +52,17 @@
     "@babel/preset-env": "^7.29.0",
     "@commitlint/cli": "^20.4.4",
     "@commitlint/config-conventional": "^20.4.4",
-    "@eslint/js": "^9.39.3",
+    "@eslint/js": "^9.39.4",
     "@types/bootstrap": "^5.2.10",
     "@types/highlightjs": "^9.12.6",
     "@types/jsdom": "^28.0.0",
     "@types/masonry-layout": "^4.2.8",
     "@types/node": "^25.5.0",
     "@types/sortablejs": "^1.15.9",
-    "@vitest/coverage-istanbul": "^4.0.18",
-    "@vitest/coverage-v8": "^4.0.18",
+    "@vitest/coverage-istanbul": "^4.1.0",
+    "@vitest/coverage-v8": "^4.1.0",
     "autoprefixer": "^10.4.27",
-    "eslint": "^10.0.2",
+    "eslint": "^10.0.3",
     "husky": "^9.1.7",
     "jsdom": "^28.1.0",
     "postcss": "^8.5.8",
@@ -76,8 +76,8 @@
     "vite-plugin-compression": "^0.5.1",
     "vite-plugin-html": "^3.2.2",
     "vite-plugin-minify": "^2.1.0",
-    "vite-plugin-static-copy": "^3.2.0",
-    "vitest": "^4.0.18",
+    "vite-plugin-static-copy": "^3.3.0",
+    "vitest": "^4.1.0",
     "vitest-fetch-mock": "^0.4.5"
   },
   "husky": {

package.json

@@ -88,7 +88,7 @@
               {% endif %}
               <li><a class="dropdown-item" href="./login">{{ msgLoginUser }}</a></li>
             {% else %}
-              <li><a class="dropdown-item" href="./user/ucp">{{ msgUserControlDropDown }}</a></li>run
+              <li><a class="dropdown-item" href="./user/ucp">{{ msgUserControlDropDown }}</a></li>
               <li><a class="dropdown-item" href="./user/bookmarks">{{ msgBookmarks }}</a></li>
               <li>
                 <a class="dropdown-item d-flex align-items-center" href="./user/chat">

phpmyfaq/assets/templates/default/index.twig

@@ -19,6 +19,7 @@
 
 namespace phpMyFAQ\Auth;
 
+use Closure;
 use phpMyFAQ\Auth;
 use phpMyFAQ\Configuration;
 use phpMyFAQ\Core\Exception;
@@ -35,15 +36,23 @@
 class AuthSso extends Auth implements AuthDriverInterface
 {
     private readonly Request $request;
+    private readonly ?Closure $ldapFactory;
+    private readonly ?Closure $userFactory;
 
     /**
      * @inheritDoc
      */
-    public function __construct(Configuration $configuration)
-    {
+    public function __construct(
+        Configuration $configuration,
+        ?Request $request = null,
+        ?Closure $ldapFactory = null,
+        ?Closure $userFactory = null,
+    ) {
         parent::__construct($configuration);
 
-        $this->request = Request::createFromGlobals();
+        $this->request = $request ?? Request::createFromGlobals();
+        $this->ldapFactory = $ldapFactory;
+        $this->userFactory = $userFactory;
     }
 
     /**
@@ -54,12 +63,12 @@ public function create(string $login, #[SensitiveParameter] string $password, st
     {
         if ($this->configuration->isLdapActive()) {
             // LDAP/AD + SSO
-            $authLdap = new AuthLdap($this->configuration);
+            $authLdap = $this->createLdapAuth();
             return $authLdap->create($login, '', $domain);
         }
 
         // SSO without LDAP/AD
-        $user = new User($this->configuration);
+        $user = $this->createUser();
         $result = $user->createUser($login, '', $domain);
         $user->setStatus('active');
         $user->setAuthSource(AuthenticationSourceType::AUTH_SSO->value);
@@ -121,4 +130,22 @@ public function isValidLogin(string $login, ?array $optionalData = null): int
     {
         return $this->request->server->get('PHP_AUTH_USER') !== null ? 1 : 0;
     }
+
+    private function createLdapAuth(): AuthLdap
+    {
+        if ($this->ldapFactory instanceof Closure) {
+            return ($this->ldapFactory)();
+        }
+
+        return new AuthLdap($this->configuration);
+    }
+
+    private function createUser(): User
+    {
+        if ($this->userFactory instanceof Closure) {
+            return ($this->userFactory)();
+        }
+
+        return new User($this->configuration);
+    }
 }

phpmyfaq/src/phpMyFAQ/Auth/AuthSso.php

@@ -134,12 +134,6 @@ public static function computeAttachmentsPath(string $confAttachmentsPath, strin
             }
         }
 
-        $tmp = $rootDir . DIRECTORY_SEPARATOR . $confAttachmentsPath;
-
-        if (str_starts_with($tmp, $rootDir)) {
-            return $tmp;
-        }
-
-        return false;
+        return $rootDir . DIRECTORY_SEPARATOR . $confAttachmentsPath;
     }
 }