test: added more tests

Author: thorsten

CHANGELOG.md

@@ -24,6 +24,7 @@ This is a log of major user-visible changes in each phpMyFAQ release.
 - added Symfony Kernel for better application structure and extensibility (Thorsten)
 - added optional Redis support for configuration caching (Thorsten)
 - added LDAP configuration frontend (Thorsten)
+- added phpMyFAQ recent news widget to the admin dashboard (Thorsten)
 - added experimental support for API key authentication via OAuth2 (Thorsten)
 - added experimental per-tenant quota enforcement, and API request rate limits (Thorsten)
 - improved audit and activity log with comprehensive security event tracking (Thorsten)

docs/administration.md

@@ -1,27 +1,31 @@
 # 7. Manage phpMyFAQ
 
-The administration of phpMyFAQ is completely browser-based. The admin area can be found under this URL:
+The phpMyFAQ administration area is fully browser-based. You can access it at:
 
-`http://www.example.com/faq/admin/index.php`
+`https://www.example.com/faq/admin/index.php`
 
-You can also log in the public frontend, and after the successful login you'll see a link to administration backend,
-too.
+You can also log in through the public frontend. After a successful login, a link to the administration backend will be 
+available there as well.
 
-If you've lost your password, you can reset it. A new random password will be generated and sent to you via email.
-Please change it after your successful login with the generated password.
+If you have lost your password, you can reset it. phpMyFAQ will generate a new random password and send it to you by 
+email. After logging in with the generated password, you should change it immediately.
 
-After entering your username and password, you can log into the system. On the dashboard page you can see the following
-cards:
+Once you enter your username and password, you can log in to the system. The dashboard provides several useful cards, 
+including:
 
-- some statistics about visits, entries, news, and comments
-- the latest current number fetched from phpmyfaq.de
-- a nice diagram with the number of visitors of the last 30 days
-- a list on inactive FAQs
-- a button to verify the integrity of the phpMyFAQ installation. Then clicking on the button phpMyFAQ calculates a
-  SHA-1 hash for all files and checks it against a web service provided on phpmyfaq.de. With this service, it's possible
-  to see if someone changed files.
+* statistics about visits, entries, news, and comments
+* the latest current version number fetched from phpmyfaq.de
+* a chart showing the number of visitors over the last 30 days
+* a list of inactive FAQs
+* a list of the latest user registrations
+* information about the date of the most recently verified backup
+* a button to verify the integrity of the phpMyFAQ installation
 
-You can switch the current language in the administration backend, and you have an info box about the session timeout.
+When you click the integrity check button, phpMyFAQ calculates a SHA-1 hash for all files and compares it with a web 
+service provided by phpmyfaq.de. This makes it possible to detect whether any files have been modified.
+
+You can also switch the current language in the administration backend. In addition, an information box can display the 
+session timeout if this feature is enabled.
 
 ## 5.1 Users and Groups
 
@@ -81,7 +85,9 @@ To do this, enter the same file name for each entry in your **database, "faqcate
 
 ### 5.2.2 Add a new FAQ
 
-You can create a completely new FAQ by using the 'Add new FAQ' option. When doing so, it is essential to select the desired category within the 'FAQ metadata' tab to ensure the entry is correctly indexed and visible to users. For a detailed explanation of all available settings and metadata options, please refer to section 5.2.3.
+You can create a completely new FAQ by using the 'Add new FAQ' option. When doing so, it is essential to select the 
+desired category within the 'FAQ metadata' tab to ensure the entry is correctly indexed and visible to users. For a 
+detailed explanation of all available settings and metadata options, please refer to section 5.2.3.
 
 ### 5.2.3 FAQ Administration
 
@@ -188,31 +194,43 @@ Only the status will be changed - the FAQ will not be deleted from the database.
 
 ### 5.2.5 Orphaned FAQs
 
-Orphaned FAQs are records that are no longer assigned to any category. This typically happens when categories are deleted without moving the associated FAQs, or through incomplete data imports. As they lack a category assignment, these entries are hidden from users in the public frontend.
+Orphaned FAQs are records that are no longer assigned to any category. This typically happens when categories are 
+deleted without moving the associated FAQs, or through incomplete data imports. As they lack a category assignment, 
+these entries are hidden from users in the public frontend.
 
 Cross-Language Management
-Administrators can manage orphaned FAQs across all installed languages, without needing to switch their backend interface language. The list displays all orphaned entries in the system, including the full language name, and allows direct editing within the correct linguistic context.
+Administrators can manage orphaned FAQs across all installed languages, without needing to switch their backend 
+interface language. The list displays all orphaned entries in the system, including the full language name, and allows 
+direct editing within the correct linguistic context.
 
 How to Resolve Orphaned FAQs:
 To correct an orphaned FAQ entry, you must assign it to a valid category in the corresponding language:
 
-1. Open the FAQ: The orphaned FAQ list displays entries from all languages. Click on the desired entry to open the FAQ editor, which will automatically be set to the FAQ's language.
+1. Open the FAQ: The orphaned FAQ list displays entries from all languages. Click on the desired entry to open the FAQ 
+editor, which will automatically be set to the FAQ's language.
 
-2. Assign Category: Navigate to the "FAQ metadata" tab within the editor. The available categories in the dropdown list will automatically match the language of the FAQ you are editing, ensuring you can only select a category appropriate for that language.
+2. Assign Category: Navigate to the "FAQ metadata" tab within the editor. The available categories in the dropdown list 
+will automatically match the language of the FAQ you are editing, ensuring you can only select a category appropriate 
+for that language.
 
 3. Save Changes: Select a valid category and save the FAQ.
 
 Once saved, the entry will be visible in its new category and will automatically be removed from the Orphaned FAQ list.
 
 ### 5.2.6 Open Questions
 
-On the "Open Questions" page, you can see all open questions that visitors have posted in the currently selected administration language. 
-You can answer open questions directly or, if they are not visible in the public area due to visibility settings, you can activate them. 
+On the "Open Questions" page, you can see all open questions that visitors have posted in the currently selected 
+administration language. 
+You can answer open questions directly or, if they are not visible in the public area due to visibility settings, you 
+can activate them. 
 Additionally, you can delete them.
 
 Please note:
-Questions awaiting moderation in other languages are not automatically shown here. If questions exist in other active languages, a warning alert will be displayed at the bottom of the page indicating which languages have pending items and the respective counts.
-To process these other questions, you must change your current administration language using the language selector in the top menu.
+Questions awaiting moderation in other languages are not automatically shown here. If questions exist in other active 
+languages, a warning alert will be displayed at the bottom of the page indicating which languages have pending items 
+and the respective counts.
+To process these other questions, you must change your current administration language using the language selector in 
+the top menu.
 
 ### 5.2.7 Comment Administration
 
@@ -850,7 +868,8 @@ This page is only available if OpenSearch is enabled.
 ### 5.6.8 System information
 
 On this page, phpMyFAQ displays some relevant system information like PHP version, database version, or session path.
-Please use this information when reporting bugs.
+Please use this information when reporting bugs. Additionally, you can check the status of all translation files and see 
+if there are any missing translations.
 
 ## 5.7 Using Microsoft Entra ID
 

phpmyfaq/src/phpMyFAQ/Faq.php

@@ -436,11 +436,13 @@ public function renderFaqsByCategoryId(int $categoryId, string $orderBy = 'id',
                 $link->getSEOTitle($title),
             );
 
+            $category = new Category($this->configuration);
+
             $baseUrl = sprintf(
-                '%sindex.php?%saction=show&cat=%d&seite=%d',
+                '%scategory/%d/%s.html?seite=%d',
                 $this->configuration->getDefaultUrl(),
-                $sids === '' || $sids === '0' ? '' : $sids,
                 $categoryId,
+                TitleSlugifier::slug($category->getCategoryName($categoryId)),
                 $page,
             );
 

phpmyfaq/src/phpMyFAQ/Filesystem/Filesystem.php

@@ -150,7 +150,7 @@ public function copy(string $sourceFileName, string $destinationFileName): bool
 
         if (copy($sourceFileName, $destinationFileName) === false) {
             $error = error_get_last();
-            throw new Exception($error['message']);
+            throw new Exception($error['message'] ?? 'Copy operation failed.');
         }
 
         return true;

phpmyfaq/src/phpMyFAQ/Helper/CategoryHelper.php

@@ -25,6 +25,7 @@
 use phpMyFAQ\Core\Exception;
 use phpMyFAQ\Language\LanguageCodes;
 use phpMyFAQ\Link;
+use phpMyFAQ\Link\Util\TitleSlugifier;
 use phpMyFAQ\Strings;
 use phpMyFAQ\Translation;
 use phpMyFAQ\User;
@@ -95,14 +96,19 @@ public function buildCategoryList(
                 break;
             }
 
-            $name = Strings::htmlentities($node['name']);
+            $name = $node['name'];
             if ($categoryNumbers[$categoryId]['faqs'] > 0) {
-                $url = sprintf('%sindex.php?action=show&cat=%d', $this->configuration->getDefaultUrl(), $node['id']);
+                $url = sprintf(
+                    '%scategory/%d/%s.html',
+                    $this->configuration->getDefaultUrl(),
+                    $node['id'],
+                    TitleSlugifier::slug($name),
+                );
 
                 $link = new Link($url, $this->configuration);
-                $link->setTitle(Strings::htmlentities($node['name']));
-                $link->text = Strings::htmlentities($node['name']);
-                $link->tooltip = is_null($node['description']) ? '' : Strings::htmlentities($node['description']);
+                $link->setTitle($node['name']);
+                $link->text = $node['name'];
+                $link->tooltip = is_null($node['description']) ? '' : $node['description'];
                 $name = $link->toHtmlAnchor();
             }
 

tests/phpMyFAQ/CustomPageTest.php

@@ -273,6 +273,58 @@ public function testCountPages(): void
         $this->assertEquals(5, $count);
     }
 
+    public function testGetAllLanguagesPaginated(): void
+    {
+        $mockData = new stdClass();
+        $mockData->id = 10;
+        $mockData->lang = 'de';
+        $mockData->page_title = 'All Languages Page';
+        $mockData->slug = 'all-languages-page';
+        $mockData->content = '<p>Paginated content</p>';
+        $mockData->author_name = 'Author';
+        $mockData->author_email = 'author@example.org';
+        $mockData->active = 'y';
+        $mockData->created = '2026-01-12 12:00:00';
+        $mockData->updated = null;
+        $mockData->seo_title = null;
+        $mockData->seo_description = null;
+        $mockData->seo_robots = 'index,follow';
+
+        $this->mockRepository
+            ->expects($this->once())
+            ->method('getAllLanguagesPaginated')
+            ->with(false, 25, 0, 'created', 'DESC')
+            ->willReturn([$mockData]);
+
+        $result = $this->customPage->getAllLanguagesPaginated();
+
+        $this->assertCount(1, $result);
+        $this->assertSame('All Languages Page', $result[0]['page_title']);
+        $this->assertSame('de', $result[0]['lang']);
+    }
+
+    public function testCountAllLanguages(): void
+    {
+        $this->mockRepository
+            ->expects($this->once())
+            ->method('countAllLanguages')
+            ->with(true)
+            ->willReturn(3);
+
+        $this->assertSame(3, $this->customPage->countAllLanguages(true));
+    }
+
+    public function testGetExistingLanguages(): void
+    {
+        $this->mockRepository
+            ->expects($this->once())
+            ->method('getExistingLanguages')
+            ->with(23)
+            ->willReturn(['de', 'en', 'fr']);
+
+        $this->assertSame(['de', 'en', 'fr'], $this->customPage->getExistingLanguages(23));
+    }
+
     public function testSlugExists(): void
     {
         $this->mockRepository
@@ -326,6 +378,28 @@ public function testGenerateUniqueSlugWithExcludeId(): void
         $this->assertEquals('test-slug', $uniqueSlug);
     }
 
+    public function testCreateTranslation(): void
+    {
+        $page = new CustomPageEntity();
+        $page
+            ->setLanguage('de')
+            ->setPageTitle('Translated Page')
+            ->setSlug('translated-page')
+            ->setContent('<p>Translated content</p>')
+            ->setAuthorName('Test Author')
+            ->setAuthorEmail('test@example.org')
+            ->setActive(true)
+            ->setCreated(new DateTime());
+
+        $this->mockRepository
+            ->expects($this->once())
+            ->method('insertTranslation')
+            ->with($page, 11)
+            ->willReturn(true);
+
+        $this->assertTrue($this->customPage->createTranslation($page, 11));
+    }
+
     public function testGetByIdWithSeoFields(): void
     {
         $mockData = new stdClass();
@@ -355,4 +429,34 @@ public function testGetByIdWithSeoFields(): void
         $this->assertEquals('SEO Test Description', $result->getSeoDescription());
         $this->assertEquals('noindex,nofollow', $result->getSeoRobots());
     }
+
+    public function testGetByIdMapsUpdatedTimestamp(): void
+    {
+        $mockData = new stdClass();
+        $mockData->id = 2;
+        $mockData->lang = 'en';
+        $mockData->page_title = 'Updated Page';
+        $mockData->slug = 'updated-page';
+        $mockData->content = '<p>Updated content</p>';
+        $mockData->author_name = 'Test Author';
+        $mockData->author_email = 'test@example.org';
+        $mockData->active = 'y';
+        $mockData->created = '2026-01-12 12:00:00';
+        $mockData->updated = '2026-01-13 09:30:00';
+        $mockData->seo_title = null;
+        $mockData->seo_description = null;
+        $mockData->seo_robots = 'index,follow';
+
+        $this->mockRepository
+            ->expects($this->once())
+            ->method('getById')
+            ->with(2, 'en')
+            ->willReturn($mockData);
+
+        $result = $this->customPage->getById(2);
+
+        $this->assertInstanceOf(CustomPageEntity::class, $result);
+        $this->assertNotNull($result->getUpdated());
+        $this->assertSame('2026-01-13 09:30:00', $result->getUpdated()?->format('Y-m-d H:i:s'));
+    }
 }

tests/phpMyFAQ/Faq/QuestionServiceTest.php

@@ -23,6 +23,7 @@ class QuestionServiceTest extends TestCase
     private CurrentUser|MockObject $currentUser;
     private array $currentGroups;
     private QuestionService $questionService;
+    private string $databaseFile;
 
     /**
      * @throws Exception
@@ -40,9 +41,12 @@ protected function setUp(): void
             ->setCurrentLanguage('en')
             ->setMultiByteLanguage();
 
+        $this->databaseFile = PMF_TEST_DIR . '/question-service-' . uniqid('', true) . '.db';
+        copy(PMF_TEST_DIR . '/test.db', $this->databaseFile);
+
         // Create configuration with real database
         $dbHandle = new Sqlite3();
-        $dbHandle->connect(PMF_TEST_DIR . '/test.db', '', '');
+        $dbHandle->connect($this->databaseFile, '', '');
         $this->configuration = new Configuration($dbHandle);
 
         $language = new Language($this->configuration, $this->createStub(Session::class));
@@ -60,6 +64,12 @@ protected function setUp(): void
         $this->questionService = new QuestionService($this->configuration, $this->currentUser, $this->currentGroups);
     }
 
+    protected function tearDown(): void
+    {
+        parent::tearDown();
+        @unlink($this->databaseFile);
+    }
+
     /**
      * @throws Exception
      */