fix: corrected column length in faqforms table

Author: thorsten

phpmyfaq/src/phpMyFAQ/Instance/Database/Mysqli.php

@@ -208,7 +208,7 @@ class Mysqli extends Database implements Driver
             form_id INT(1) NOT NULL,
             input_id INT(11) NOT NULL,
             input_type VARCHAR(1000) NOT NULL,
-            input_label VARCHAR(100) NOT NULL,
+            input_label VARCHAR(500) NOT NULL,
             input_active INT(1) NOT NULL,
             input_required INT(1) NOT NULL,
             input_lang VARCHAR(11) NOT NULL)',

phpmyfaq/src/phpMyFAQ/Instance/Database/Pgsql.php

@@ -208,7 +208,7 @@ class Pgsql extends Database implements Driver
             form_id INTEGER NOT NULL,
             input_id INTEGER NOT NULL,
             input_type VARCHAR(1000) NOT NULL,
-            input_label VARCHAR(100) NOT NULL,
+            input_label VARCHAR(500) NOT NULL,
             input_active INTEGER NOT NULL,
             input_required INTEGER NOT NULL,
             input_lang VARCHAR(11) NOT NULL)',

phpmyfaq/src/phpMyFAQ/Instance/Database/Sqlite3.php

@@ -204,7 +204,7 @@ class Sqlite3 extends Database implements Driver
             form_id INTEGER NOT NULL,
             input_id INTEGER NOT NULL,
             input_type VARCHAR(1000) NOT NULL,
-            input_label VARCHAR(100) NOT NULL,
+            input_label VARCHAR(500) NOT NULL,
             input_active INTEGER NOT NULL,
             input_required INTEGER NOT NULL,
             input_lang VARCHAR(11) NOT NULL)',

phpmyfaq/src/phpMyFAQ/Instance/Database/Sqlsrv.php

@@ -204,7 +204,7 @@ class Sqlsrv extends Database implements Driver
             form_id INTEGER NOT NULL,
             input_id INTEGER NOT NULL,
             input_type NVARCHAR(1000) NOT NULL,
-            input_label NVARCHAR(100) NOT NULL,
+            input_label NVARCHAR(500) NOT NULL,
             input_active INTEGER NOT NULL,
             input_required INTEGER NOT NULL,
             input_lang NVARCHAR(11) NOT NULL)',

phpmyfaq/src/phpMyFAQ/Setup/Update.php

@@ -165,6 +165,7 @@ public function applyUpdates(): bool
         $this->applyUpdates400Alpha2();
         $this->applyUpdates400Alpha3();
         $this->applyUpdates400Beta2();
+        $this->applyUpdates405();
 
         // Optimize the tables
         $this->optimizeTables();
@@ -860,6 +861,67 @@ private function applyUpdates400Beta2(): void
         }
     }
 
+    private function applyUpdates405(): void
+    {
+        if (version_compare($this->version, '4.0.5', '<')) {
+            switch (Database::getType()) {
+                case 'mysqli':
+                    $this->queries[] = sprintf(
+                        'ALTER TABLE %sfaqforms CHANGE input_label input_label VARCHAR(500) NOT NULL',
+                        Database::getTablePrefix()
+                    );
+                    break;
+                case 'pgsql':
+                    $this->queries[] = sprintf(
+                        'ALTER TABLE %sfaqforms ALTER COLUMN input_label TYPE VARCHAR(500)',
+                        Database::getTablePrefix()
+                    );
+                    $this->queries[] = sprintf(
+                        'ALTER TABLE %sfaqforms ALTER COLUMN input_label SET NOT NULL',
+                        Database::getTablePrefix()
+                    );
+                    break;
+                case 'sqlite3':
+                    $this->queries[] = sprintf(
+                        'ALTER TABLE %sfaqforms RENAME TO %sfaqforms_old',
+                        Database::getTablePrefix(),
+                        Database::getTablePrefix()
+                    );
+                    $this->queries[] = sprintf(
+                        'CREATE TABLE %sfaqforms (
+                            form_id INTEGER NOT NULL,
+                            input_id INTEGER NOT NULL,
+                            input_type VARCHAR(1000) NOT NULL,
+                            input_label VARCHAR(500) NOT NULL,
+                            input_active INTEGER NOT NULL,
+                            input_required INTEGER NOT NULL,
+                            input_lang VARCHAR(11) NOT NULL
+                        )',
+                        Database::getTablePrefix()
+                    );
+                    $this->queries[] = sprintf(
+                        'INSERT INTO %sfaqforms 
+                            SELECT 
+                                form_id, input_id, input_type, input_label, input_active, input_required, input_lang 
+                            FROM %sfaqforms_old',
+                        Database::getTablePrefix(),
+                        Database::getTablePrefix()
+                    );
+                    $this->queries[] = sprintf(
+                        'DROP TABLE %sfaqforms_old;',
+                        Database::getTablePrefix()
+                    );
+                    break;
+                case 'sqlsrv':
+                    $this->queries[] = sprintf(
+                        'ALTER TABLE %sfaqforms ALTER COLUMN input_label NVARCHAR(500) NOT NULL',
+                        Database::getTablePrefix()
+                    );
+                    break;
+            }
+        }
+    }
+
     private function updateVersion(): void
     {
         $this->configuration->update(['main.currentApiVersion' => System::getApiVersion()]);