refactor: corrected some linting errors

Author: thorsten

phpmyfaq/src/phpMyFAQ/Auth/AuthHttp.php

@@ -89,8 +89,8 @@ public function checkCredentials(string $login, #[SensitiveParameter] $password,
         }
 
         return (
-            $this->request->server->get('PHP_AUTH_USER') === $login
-            && $this->request->server->get('PHP_AUTH_PW') === $password
+            hash_equals($login, (string) $this->request->server->get('PHP_AUTH_USER'))
+            && hash_equals($password, (string) $this->request->server->get('PHP_AUTH_PW'))
         );
     }
 

phpmyfaq/src/phpMyFAQ/Auth/AuthLdap.php

@@ -100,8 +100,8 @@ public function create(string $login, #[SensitiveParameter] string $password, st
 
         // Set user information from LDAP
         $user->setUserData([
-            'display_name' => $this->ldapCore->getCompleteName($login) ?: '',
-            'email' => $this->ldapCore->getMail($login) ?: '',
+            'display_name' => $this->ldapCore->getCompleteName($login) ?? '',
+            'email' => $this->ldapCore->getMail($login) ?? '',
         ]);
 
         // Handle group assignments if enabled

phpmyfaq/src/phpMyFAQ/Cache/CacheSettingsResolver.php

@@ -75,8 +75,8 @@ public function resolve(): CacheSettings
 
     private function normalizeRedisPrefix(string $redisPrefix): string
     {
-        $normalizedPrefix = preg_replace('/[^-+_.A-Za-z0-9]/', '_', $redisPrefix) ?? '';
+        $normalizedPrefix = preg_replace('/[^-+_.A-Za-z0-9]/', '_', subject: $redisPrefix) ?? '';
 
-        return trim($normalizedPrefix, '_') !== '' ? $normalizedPrefix : self::DEFAULT_REDIS_PREFIX;
+        return trim($normalizedPrefix, characters: '_') !== '' ? $normalizedPrefix : self::DEFAULT_REDIS_PREFIX;
     }
 }

phpmyfaq/src/phpMyFAQ/Configuration/Storage/DatabaseConfigurationStore.php

@@ -150,7 +150,7 @@ public function fetchValues(array $names): array
         $result = $this->databaseDriver->query($query);
         $rows = $this->databaseDriver->fetchAll($result);
 
-        $values = array_fill_keys($trimmedNames, null);
+        $values = array_fill_keys($trimmedNames, value: null);
         if (!is_array($rows)) {
             return $values;
         }

phpmyfaq/src/phpMyFAQ/Controller/Administration/Api/UpdateController.php

@@ -29,7 +29,6 @@
 use phpMyFAQ\Setup\EnvironmentConfigurator;
 use phpMyFAQ\Setup\Update;
 use phpMyFAQ\Setup\Upgrade;
-use phpMyFAQ\System;
 use phpMyFAQ\Translation;
 use Symfony\Component\HttpClient\HttpClient;
 use Symfony\Component\HttpFoundation\JsonResponse;

phpmyfaq/src/phpMyFAQ/Controller/Frontend/Api/TranslationController.php

@@ -34,7 +34,8 @@ final class TranslationController extends AbstractController
 {
     /**
      * @param ?Closure(string): void $setCurrentLanguage
-     * @param ?Closure(): array<mixed> $getTranslations
+     * @param ?Closure(): array      $getTranslations
+     * @throws \Exception
      */
     public function __construct(
         private readonly ?Closure $setCurrentLanguage = null,
@@ -57,7 +58,7 @@ public function translations(Request $request): JsonResponse
                 Translation::getInstance()->setCurrentLanguage($language);
             })($language);
 
-            return $this->json(($this->getTranslations ?? static fn(): array => Translation::getAll())());
+            return $this->json(($this->getTranslations ?? Translation::getAll(...))());
         } catch (Exception $exception) {
             return $this->json(['error' => $exception->getMessage()], Response::HTTP_INTERNAL_SERVER_ERROR);
         }

phpmyfaq/src/phpMyFAQ/Controller/Frontend/Api/UnauthorizedUserController.php

@@ -74,10 +74,7 @@ public function updatePassword(Request $request): JsonResponse
         $email = trim((string) Filter::filterEmail($data->email));
 
         if ($username !== '' && $username !== '0' && ($email !== '' && $email !== '0')) {
-            $user = ($this->currentUserFactory
-            ?? static fn(Configuration $configuration): CurrentUser => CurrentUser::getCurrentUser(
-                $configuration,
-            ))($this->configuration);
+            $user = ($this->currentUserFactory ?? CurrentUser::getCurrentUser(...))($this->configuration);
             $loginExist = $user->getUserByLogin($username);
 
             if ($loginExist && $email === $user->getUserData('email')) {

phpmyfaq/src/phpMyFAQ/Helper/SvgSanitizer.php

@@ -231,21 +231,21 @@ private function decodeAllEntities(string $content): string
             // Decode decimal entities (j → j)
             $decoded = preg_replace_callback(
                 '/&#(\d+);/',
-                static fn(array $matches): string => mb_chr((int) $matches[1], 'UTF-8'),
+                static fn(array $matches): string => mb_chr((int) $matches[1], encoding: 'UTF-8'),
                 $decoded,
             );
             // Decode hex entities (j → j)
             $decoded = preg_replace_callback(
                 '/&#x([0-9a-fA-F]+);/',
-                static fn(array $matches): string => mb_chr(hexdec($matches[1]), 'UTF-8'),
+                static fn(array $matches): string => mb_chr(hexdec($matches[1]), encoding: 'UTF-8'),
                 $decoded,
             );
             // Decode named HTML entities (&amp; → &, &lt; → <, etc.)
-            $decoded = html_entity_decode($decoded, ENT_QUOTES | ENT_HTML5, 'UTF-8');
+            $decoded = html_entity_decode($decoded, ENT_QUOTES | ENT_HTML5, encoding: 'UTF-8');
         }
 
         // Strip null bytes and control characters that could break regex matching
-        return preg_replace('/[\x00-\x08\x0b\x0c\x0e-\x1f\x7f]/', '', $decoded);
+        return preg_replace('/[\x00-\x08\x0b\x0c\x0e-\x1f\x7f]/', replacement: '', subject: $decoded);
     }
 
     /**

phpmyfaq/src/phpMyFAQ/Service/McpServer/McpSdkRuntime.php

@@ -19,26 +19,28 @@
 
 namespace phpMyFAQ\Service\McpServer;
 
+use Mcp\Server;
+use Mcp\Server\Transport\StdioTransport;
 use phpMyFAQ\Configuration;
 use RuntimeException;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 
-final class McpSdkRuntime implements McpServerRuntimeInterface
+final readonly class McpSdkRuntime implements McpServerRuntimeInterface
 {
     /**
      * @param array<string, mixed> $serverInfo
      */
     public function __construct(
-        private readonly Configuration $configuration,
-        private readonly FaqSearchTool $faqSearchTool,
-        private readonly array $serverInfo,
+        private Configuration $configuration,
+        private FaqSearchTool $faqSearchTool,
+        private array $serverInfo,
     ) {
     }
 
     public function runConsole(InputInterface $input, OutputInterface $output): void
     {
-        $this->buildServer()->run(new \Mcp\Server\Transport\StdioTransport());
+        $this->buildServer()->run(new StdioTransport());
     }
 
     public function getServerInfo(): array
@@ -67,34 +69,29 @@ public function faqSearch(
             'all_languages' => $all_languages,
         ]);
 
-        $decoded = json_decode($result['content'], true);
+        $decoded = json_decode($result['content'], associative: true);
 
         return json_last_error() === JSON_ERROR_NONE ? $decoded : $result['content'];
     }
 
-    private function buildServer(): \Mcp\Server
+    private function buildServer(): Server
     {
-        if (!class_exists(\Mcp\Server::class) || !class_exists(\Mcp\Server\Transport\StdioTransport::class)) {
+        if (!class_exists(Server::class) || !class_exists(StdioTransport::class)) {
             throw new RuntimeException(
                 'The mcp/sdk package is not installed or does not expose the expected server classes.',
             );
         }
 
         $definition = $this->faqSearchTool->getDefinition();
 
-        return \Mcp\Server::builder()
+        return Server::builder()
             ->setServerInfo(
                 (string) $this->serverInfo['name'],
                 (string) $this->serverInfo['version'],
                 (string) ($this->serverInfo['description'] ?? null),
             )
             ->addTool(
-                fn(
-                    string $query,
-                    ?int $category_id = null,
-                    int $limit = 10,
-                    bool $all_languages = false,
-                ): array|string => $this->faqSearch($query, $category_id, $limit, $all_languages),
+                $this->faqSearch(...),
                 $definition->name,
                 $definition->description,
                 null,