fix: corrected some issues in the update process

Author: thorsten

phpmyfaq/src/Bootstrap.php

@@ -95,6 +95,7 @@
 if (!file_exists(PMF_CONFIG_DIR . '/database.php') && !file_exists(PMF_LEGACY_CONFIG_DIR . '/database.php')) {
     $response = new RedirectResponse('./setup/');
     $response->send();
+    exit();
 } else {
     if (file_exists(PMF_CONFIG_DIR . '/database.php')) {
         $databaseFile = PMF_CONFIG_DIR . '/database.php';

phpmyfaq/src/phpMyFAQ/Controller/Api/SetupController.php

@@ -85,7 +85,7 @@ public function backup(Request $request): JsonResponse
         $installedVersion = Filter::filterVar($request->getContent(), FILTER_SANITIZE_SPECIAL_CHARS);
 
         $configPath = PMF_ROOT_DIR . '/content/core/config';
-        if (!version_compare(version1: $installedVersion, version2: '4.0.0-alpha') < 0) {
+        if (version_compare(version1: $installedVersion, version2: '4.0.0-alpha', operator: '<')) {
             $configPath = PMF_ROOT_DIR . '/config';
         }
 

phpmyfaq/src/phpMyFAQ/Setup/Installer.php

@@ -714,7 +714,9 @@ public function checkNoncriticalSettings(): array
     public function checkInitialRewriteBasePath(Request $request): bool
     {
         $basePath = $request->getBasePath();
-        $basePath = rtrim($basePath, 'setup');
+        if (str_ends_with($basePath, 'setup')) {
+            $basePath = substr($basePath, 0, -strlen('setup'));
+        }
 
         $htaccessPath = PMF_ROOT_DIR . '/.htaccess';
 

phpmyfaq/src/phpMyFAQ/Setup/Update.php

@@ -144,7 +144,9 @@ public function createConfigBackup(string $configDir): string
     public function checkInitialRewriteBasePath(Request $request): bool
     {
         $basePath = $request->getBasePath();
-        $basePath = rtrim($basePath, 'update');
+        if (str_ends_with($basePath, 'update')) {
+            $basePath = substr($basePath, 0, -strlen('update'));
+        }
 
         $htaccessPath = PMF_ROOT_DIR . '/.htaccess';