chore: Remove get-id module

Author: thetarnav

packages/debugger/src/dependency/collect.test.ts

@@ -8,11 +8,6 @@ import setup from '../main/setup.ts'
 import type {NodeID, Solid} from '../main/types.ts'
 import {type SerializedDGraph, collectDependencyGraph} from './collect.ts'
 
-let mockLAST_ID = 0
-test.beforeEach(() => {
-    mockLAST_ID = 0
-})
-test.vi.mock('../main/get-id.ts', () => ({getNewSdtId: () => '#' + mockLAST_ID++}))
 
 test.describe('collectDependencyGraph', () => {
     test.it('should collect dependency graph', () => {

packages/debugger/src/inspector/serialize.test.ts

@@ -7,9 +7,6 @@ import {ObjectType, getObjectById} from '../main/id.ts'
 import {encodeValue} from './serialize.ts'
 import {type EncodedValue, INFINITY, NAN, NEGATIVE_INFINITY, UNDEFINED, ValueType} from './types.ts'
 
-let mockLAST_ID = 0
-vi.mock('../main/get-id.ts', () => ({getNewSdtId: () => '#' + mockLAST_ID++}))
-
 type Expectations = [name: string, data: unknown, encoded: EncodedValue[]][]
 
 const div1 = document.createElement('div')
@@ -24,7 +21,6 @@ const [state] = createStore({a: 1, b: 2, c: 3})
 const mutable = createMutable({a: 1, b: 2, c: 3})
 
 describe('encodeValue Preview', () => {
-    mockLAST_ID = 0
 
     const encodePreviewExpectations: Expectations = [
         ['Infinity', Infinity, [[ValueType.Number, INFINITY]]],
@@ -86,7 +82,6 @@ describe('encodeValue Preview', () => {
 })
 
 describe('encodeValue Deep', () => {
-    mockLAST_ID = 0
 
     const encodeDeepExpectations: Expectations = [
         ['Array empty', [], [[ValueType.Array, []]]],
@@ -163,7 +158,6 @@ describe('encodeValue Deep', () => {
 })
 
 describe('save elements to a map', () => {
-    mockLAST_ID = 0
 
     const elMapExpectations: Expectations = [
         ['Element div', div1, [[ValueType.Element, '#0:div']]],
@@ -193,7 +187,6 @@ describe('save elements to a map', () => {
 })
 
 describe('encodeValue with repeated references', () => {
-    mockLAST_ID = 0
 
     const one: any = {a: 1}
     one.b = one
@@ -240,7 +233,6 @@ describe('encodeValue with repeated references', () => {
 })
 
 describe('finding stores in values', () => {
-    mockLAST_ID = 0
 
     const [state1] = createStore({a: 1})
     const [state2] = createStore({ref: state1})

packages/debugger/src/inspector/store.test.ts

@@ -2,7 +2,7 @@ import '../setup.ts'
 
 import {createRoot} from 'solid-js'
 import {createMutable, createStore, modifyMutable, produce, reconcile, unwrap} from 'solid-js/store'
-import {beforeEach, describe, expect, it, vi} from 'vitest'
+import {describe, expect, it, vi} from 'vitest'
 import {ObjectType, getSdtId} from '../main/id.ts'
 import setup from '../main/setup.ts'
 import {isSolidStore} from '../main/utils.ts'
@@ -21,12 +21,6 @@ const getOwnerStore = () => {
 const getNodeProp = (node: Solid.StoreNode, prop: string): StoreNodeProperty =>
     `${getSdtId(unwrap(node), ObjectType.StoreNode)}:${prop}`
 
-let mockLAST_ID = 0
-beforeEach(() => {
-    mockLAST_ID = 0
-})
-vi.mock('../main/get-id.ts', () => ({getNewSdtId: () => '#' + mockLAST_ID++}))
-
 type UpdateParams = Parameters<OnNodeUpdate>
 
 describe('observeStoreNode2', () => {

packages/debugger/src/main/get-id.ts

@@ -1,4 +1,3 @@
-import {getNewSdtId} from './get-id.ts'
 import {type NodeID, type Solid} from './types.ts'
 
 export const enum ObjectType {
@@ -36,6 +35,9 @@ const CleanupRegistry = new FinalizationRegistry((data: {map: ObjectType; id: No
     RefMapMap[data.map].delete(data.id)
 })
 
+let LastId = 0
+export const getNewSdtId = (): NodeID => `#${(LastId++).toString(36)}`
+
 export function getSdtId<T extends ObjectType>(obj: ValueMap[T], objType: T): NodeID {
     let id = WeakIdMap.get(obj)
     if (!id) {

packages/debugger/src/main/id.ts

@@ -14,12 +14,6 @@ test.beforeAll(() => {
     initRoots()
 })
 
-let mockLAST_ID = 0
-test.beforeEach(() => {
-    mockLAST_ID = 0
-})
-test.vi.mock('../main/get-id.ts', () => ({getNewSdtId: () => '#' + mockLAST_ID++}))
-
 test.describe('TreeWalkerMode.Owners', () => {
     test.it('default options', () => {
         {