refactor: split main driver file into focused modules

Resolves #24 - the main openstack.rb driver file had grown too large
with too many concerns in a single class.

Extract four new modules from Kitchen::Driver::Openstack:

- Config (openstack/config.rb): server naming logic including
  config_server_name, default_name, and server_name_prefix
- Networking (openstack/networking.rb): floating IP allocation and IP
  address resolution including attach_ip, attach_ip_from_pool, get_ip,
  get_public_private_ips, filter_ips, and parse_ips
- ServerHelper (openstack/server_helper.rb): server creation and
  resource finders including create_server, init_configuration,
  optional_config, find_image, find_flavor, find_network, and
  find_matching
- Helpers (openstack/helpers.rb): ohai hints, SSL validation, and
  server wait logic including add_ohai_hint, disable_ssl_validation,
  wait_for_server, and countdown

The main openstack.rb retains the class definition, create/destroy
lifecycle methods, Fog connection helpers, and default_config
declarations.

Additional changes:
- Fix Style/ClassVars offenses by replacing class variables with
  constants (IP_POOL_LOCK in Networking, DEFAULT_CREATION_TIMEOUT
  in Volume)
- Fix Style/FileRead by using File.read and updating the corresponding
  spec mock
- Remove obsolete --chefstyle flag from Rakefile (no longer supported
  by newer RuboCop; .rubocop.yml already loads cookstyle via require)
- Auto-correct all cookstyle offenses (string quoting, comment format,
  percent literal delimiters)
- Add Lance Albertson as author and Oregon State University copyright

Signed-off-by: Lance Albertson <lance@osuosl.org>

Author: ramereth

Gemfile

@@ -1,21 +1,21 @@
 # frozen_string_literal: true
 
-source "https://rubygems.org"
+source 'https://rubygems.org'
 
 # Specify your gem's dependencies in kitchen-openstack.gemspec
 gemspec
 
 group :test do
-  gem "rake"
-  gem "kitchen-inspec"
-  gem "rspec", "~> 3.2"
-  gem "countloc"
+  gem 'rake'
+  gem 'kitchen-inspec'
+  gem 'rspec', '~> 3.2'
+  gem 'countloc'
 end
 
 group :debug do
-  gem "pry"
+  gem 'pry'
 end
 
 group :cookstyle do
-  gem "cookstyle"
+  gem 'cookstyle'
 end

Rakefile

@@ -1,30 +1,30 @@
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
 
 RSpec::Core::RakeTask.new(:unit)
 
-desc "Run all test suites"
+desc 'Run all test suites'
 task test: [:unit]
 
-desc "Display LOC stats"
+desc 'Display LOC stats'
 task :stats do
   puts "\n## Production Code Stats"
-  sh "countloc -r lib"
+  sh 'countloc -r lib'
   puts "\n## Test Code Stats"
-  sh "countloc -r spec"
+  sh 'countloc -r spec'
 end
 
 begin
-  require "cookstyle"
-  require "rubocop/rake_task"
+  require 'cookstyle'
+  require 'rubocop/rake_task'
   RuboCop::RakeTask.new(:style) do |task|
-    task.options += ["--chefstyle", "--display-cop-names", "--no-color"]
+    task.options += ['--display-cop-names', '--no-color']
   end
 rescue LoadError
-  puts "cookstyle is not available.  gem install cookstyle to do style checking."
+  puts 'cookstyle is not available.  gem install cookstyle to do style checking.'
 end
 
-desc "Run all quality tasks"
-task quality: %i{style stats}
+desc 'Run all quality tasks'
+task quality: %i(style stats)
 
-task default: %i{test quality}
+task default: %i(test quality)

kitchen-openstack.gemspec

@@ -1,25 +1,25 @@
 # frozen_string_literal: true
 
-lib = File.expand_path("lib", __dir__)
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require "kitchen/driver/openstack_version"
+require 'kitchen/driver/openstack_version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "kitchen-openstack"
+  spec.name          = 'kitchen-openstack'
   spec.version       = Kitchen::Driver::OPENSTACK_VERSION
-  spec.authors       = ["Jonathan Hartman", "JJ Asghar"]
-  spec.email         = ["j@p4nt5.com", "jj@chef.io"]
-  spec.description   = "A Test Kitchen OpenStack Nova driver"
+  spec.authors       = ['Jonathan Hartman', 'JJ Asghar']
+  spec.email         = ['j@p4nt5.com', 'jj@chef.io']
+  spec.description   = 'A Test Kitchen OpenStack Nova driver'
   spec.summary       = spec.description
-  spec.homepage      = "https://github.com/test-kitchen/kitchen-openstack"
-  spec.license       = "Apache-2.0"
+  spec.homepage      = 'https://github.com/test-kitchen/kitchen-openstack'
+  spec.license       = 'Apache-2.0'
 
-  spec.files         = Dir["LICENSE", "README.md", "lib/**/*"]
-  spec.require_paths = ["lib"]
+  spec.files         = Dir['LICENSE', 'README.md', 'lib/**/*']
+  spec.require_paths = ['lib']
 
-  spec.required_ruby_version = ">= 3.1"
+  spec.required_ruby_version = '>= 3.1'
 
-  spec.add_dependency "test-kitchen", ">= 1.4.1", "< 5"
-  spec.add_dependency "fog-openstack", "~> 1.0"
-  spec.add_dependency "ohai"
+  spec.add_dependency 'test-kitchen', '>= 1.4.1', '< 5'
+  spec.add_dependency 'fog-openstack', '~> 1.0'
+  spec.add_dependency 'ohai'
 end