Add tests for ActivityStub Factory

Author: roxblnfk

composer.json

@@ -39,7 +39,7 @@
     "require": {
         "php": ">=8.1",
         "temporal/sdk": "^2.7",
-        "buggregator/trap": "*"
+        "buggregator/trap": "^1.3"
     },
     "require-dev": {
         "phpunit/phpunit": "^10.4",

src/Attribute/RetryPolicy.php

@@ -34,7 +34,7 @@ public function __construct(
         public readonly \DateInterval|string|int|null $initInterval = null,
         public readonly \DateInterval|string|int|null $maxInterval = null,
         public readonly ?float $backoff = null,
-        public readonly array $nonRetryables = []
+        public readonly array $nonRetryables = [],
     ) {
     }
 }

tests/Stub/Activity/AttributedWithoutInterface.php

@@ -0,0 +1,22 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Temporal\Sugar\Tests\Stub\Activity;
+
+use RuntimeException;
+use Temporal\Activity\ActivityInterface;
+use Temporal\Activity\ActivityMethod;
+use Temporal\Sugar\Attribute\RetryPolicy;
+use Temporal\Sugar\Attribute\TaskQueue;
+
+#[TaskQueue(name: 'test-queue')]
+#[RetryPolicy(attempts: 3, initInterval: 5, maxInterval: 500, backoff: 10, nonRetryables: [RuntimeException::class])]
+#[ActivityInterface]
+final class AttributedWithoutInterface
+{
+    #[ActivityMethod]
+    public function handle()
+    {
+    }
+}

tests/Unit/Factory/ActivityStubTest.php

@@ -0,0 +1,68 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Temporal\Sugar\Tests\Unit\Factory;
+
+use LogicException;
+use PHPUnit\Framework\TestCase;
+use RuntimeException;
+use Temporal\Sugar\Factory\ActivityStub;
+use Temporal\Sugar\Tests\Stub\Activity\AttributedWithoutInterface;
+use Temporal\Workflow;
+
+final class ActivityStubTest extends TestCase
+{
+    protected function setUp(): void
+    {
+        $stub = $this->createStub(Workflow\WorkflowContextInterface::class);
+        $stub->method('newActivityStub')
+            ->willReturnCallback(function ($class, $options) {
+                return (object)[
+                    'class' => $class,
+                    'options' => $options,
+                ];
+            });
+        Workflow::setCurrentContext($stub);
+        parent::setUp();
+    }
+
+    public function testDefaultsFromAttributes()
+    {
+        /** @var \Temporal\Activity\ActivityOptions $options */
+        $options = ActivityStub::activity(
+            activity: AttributedWithoutInterface::class,
+        )->options;
+
+        $this->assertSame('test-queue', $options->taskQueue);
+        $this->assertSame(3, $options->retryOptions->maximumAttempts);
+        $this->assertSame(10.0, $options->retryOptions->backoffCoefficient);
+        $this->assertSame([RuntimeException::class], $options->retryOptions->nonRetryableExceptions);
+        $this->assertSame('5.0', $options->retryOptions->initialInterval->format('%s.%f'));
+        $this->assertSame('500.0', $options->retryOptions->maximumInterval->format('%s.%f'));
+    }
+
+    public function testAttributeOverrides()
+    {
+        /** @var \Temporal\Activity\ActivityOptions $options */
+        $options = ActivityStub::activity(
+            activity: AttributedWithoutInterface::class,
+            taskQueue: 'test-queue-override',
+            retryAttempts: 0,
+            retryInitInterval: 10,
+            retryMaxInterval: 200,
+            retryBackoff: 5.0,
+            nonRetryables: [LogicException::class],
+        )->options;
+
+        $this->assertSame('test-queue-override', $options->taskQueue);
+        $this->assertSame(0, $options->retryOptions->maximumAttempts);
+        $this->assertSame(5.0, $options->retryOptions->backoffCoefficient);
+        $this->assertEquals(
+            [LogicException::class, RuntimeException::class],
+            $options->retryOptions->nonRetryableExceptions,
+        );
+        $this->assertSame('10.0', $options->retryOptions->initialInterval->format('%s.%f'));
+        $this->assertSame('200.0', $options->retryOptions->maximumInterval->format('%s.%f'));
+    }
+}

…ts/Unit/Internal/AttributeReaderTest.php …ternal/Attribute/AttributeReaderTest.phptests/Unit/Internal/AttributeReaderTest.php renamed to tests/Unit/Internal/Attribute/AttributeReaderTest.php tests/Unit/Internal/AttributeReaderTest.php renamed to tests/Unit/Internal/Attribute/AttributeReaderTest.php

@@ -2,18 +2,19 @@
 
 declare(strict_types=1);
 
-namespace Temporal\Sugar\Tests\Unit\Internal;
+namespace Temporal\Sugar\Tests\Unit\Internal\Attribute;
 
 use PHPUnit\Framework\TestCase;
 use Temporal\Sugar\Attribute\TaskQueue;
 use Temporal\Sugar\Internal\Attribute\AttributeReader;
+use Temporal\Sugar\Tests\Unit\Internal\Attribute;
 
 class AttributeReaderTest extends TestCase
 {
     public function testFromClass(): void
     {
         $result = AttributeReader::arrayFromClass(
-            Stub\Attributed\SimpleClass::class,
+            Attribute\Stub\Attributed\SimpleClass::class,
             [TaskQueue::class]
         );
 
@@ -27,7 +28,7 @@ public function testFromClass(): void
     public function testFromExtendedClassWithInheritanceWithMerge(): void
     {
         $result = AttributeReader::arrayFromClass(
-            Stub\Attributed\ExtendedAttributed::class,
+            Attribute\Stub\Attributed\ExtendedAttributed::class,
             [TaskQueue::class],
             merge: true,
         );
@@ -48,7 +49,7 @@ public function testFromExtendedClassWithInheritanceWithMerge(): void
     public function testFromInterfaceWithInheritance(): void
     {
         $result = AttributeReader::arrayFromClass(
-            Stub\Attributed\InterfaceAttributed::class,
+            Attribute\Stub\Attributed\InterfaceAttributed::class,
             [TaskQueue::class],
             merge: true,
         );

…l/Stub/Attributed/AbstractAttributed.php …e/Stub/Attributed/AbstractAttributed.phptests/Unit/Internal/Stub/Attributed/AbstractAttributed.php renamed to tests/Unit/Internal/Attribute/Stub/Attributed/AbstractAttributed.php tests/Unit/Internal/Stub/Attributed/AbstractAttributed.php renamed to tests/Unit/Internal/Attribute/Stub/Attributed/AbstractAttributed.php

@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Temporal\Sugar\Tests\Unit\Internal\Stub\Attributed;
+namespace Temporal\Sugar\Tests\Unit\Internal\Attribute\Stub\Attributed;
 
 use Temporal\Sugar\Attribute\TaskQueue;
 

…l/Stub/Attributed/ExtendedAttributed.php …e/Stub/Attributed/ExtendedAttributed.phptests/Unit/Internal/Stub/Attributed/ExtendedAttributed.php renamed to tests/Unit/Internal/Attribute/Stub/Attributed/ExtendedAttributed.php tests/Unit/Internal/Stub/Attributed/ExtendedAttributed.php renamed to tests/Unit/Internal/Attribute/Stub/Attributed/ExtendedAttributed.php

@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Temporal\Sugar\Tests\Unit\Internal\Stub\Attributed;
+namespace Temporal\Sugar\Tests\Unit\Internal\Attribute\Stub\Attributed;
 
 use Temporal\Sugar\Attribute\TaskQueue;
 

…/Stub/Attributed/InterfaceAttributed.php …/Stub/Attributed/InterfaceAttributed.phptests/Unit/Internal/Stub/Attributed/InterfaceAttributed.php renamed to tests/Unit/Internal/Attribute/Stub/Attributed/InterfaceAttributed.php tests/Unit/Internal/Stub/Attributed/InterfaceAttributed.php renamed to tests/Unit/Internal/Attribute/Stub/Attributed/InterfaceAttributed.php

@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Temporal\Sugar\Tests\Unit\Internal\Stub\Attributed;
+namespace Temporal\Sugar\Tests\Unit\Internal\Attribute\Stub\Attributed;
 
 use Temporal\Sugar\Attribute\TaskQueue;
 

…Attributed/ParentInterfaceAttributed.php …Attributed/ParentInterfaceAttributed.phptests/Unit/Internal/Stub/Attributed/ParentInterfaceAttributed.php renamed to tests/Unit/Internal/Attribute/Stub/Attributed/ParentInterfaceAttributed.php tests/Unit/Internal/Stub/Attributed/ParentInterfaceAttributed.php renamed to tests/Unit/Internal/Attribute/Stub/Attributed/ParentInterfaceAttributed.php

@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Temporal\Sugar\Tests\Unit\Internal\Stub\Attributed;
+namespace Temporal\Sugar\Tests\Unit\Internal\Attribute\Stub\Attributed;
 
 use Temporal\Sugar\Attribute\TaskQueue;
 

…uted/ParentParentInterfaceAttributed.php …uted/ParentParentInterfaceAttributed.phptests/Unit/Internal/Stub/Attributed/ParentParentInterfaceAttributed.php renamed to tests/Unit/Internal/Attribute/Stub/Attributed/ParentParentInterfaceAttributed.php tests/Unit/Internal/Stub/Attributed/ParentParentInterfaceAttributed.php renamed to tests/Unit/Internal/Attribute/Stub/Attributed/ParentParentInterfaceAttributed.php

@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Temporal\Sugar\Tests\Unit\Internal\Stub\Attributed;
+namespace Temporal\Sugar\Tests\Unit\Internal\Attribute\Stub\Attributed;
 
 use Temporal\Sugar\Attribute\TaskQueue;