Add the ability to create untyped activity stub

Author: roxblnfk

src/Factory/ActivityStub.php

@@ -14,6 +14,7 @@
 use Temporal\Support\Internal\Attribute\AttributeReader;
 use Temporal\Support\Internal\RetryOptions;
 use Temporal\Workflow;
+use Temporal\Workflow\ActivityStubInterface;
 use Throwable;
 
 final class ActivityStub
@@ -23,7 +24,7 @@ final class ActivityStub
      *
      * @template T of object
      *
-     * @param class-string<T> $class
+     * @param class-string<T>|null $class Activity class name. When not set, an untyped activity stub is created.
      * @param non-empty-string|null $taskQueue
      * @param int<0, max>|null $retryAttempts Maximum number of attempts. When exceeded the retries stop even
      *        if not expired yet. If not set or set to 0, it means unlimited, and rely on activity
@@ -57,10 +58,10 @@ final class ActivityStub
      * @param int $cancellationType Whether to wait for canceled activity to be completed (activity can be failed,
      *        completed, cancel accepted). {@see \Temporal\Activity\ActivityCancellationType}
      *
-     * @return T|ActivityProxy
+     * @return ($class is class-string ? T|ActivityProxy : ActivityStubInterface)
      */
     public static function activity(
-        string $class,
+        ?string $class = null,
         ?string $taskQueue = null,
         ?int $retryAttempts = null,
         \DateInterval|string|int|null $retryInitInterval = null,
@@ -74,7 +75,7 @@ public static function activity(
         \Stringable|string|null $activityId = null,
         int $cancellationType = 0,
     ): object {
-        $attributes = self::readAttributes($class);
+        $attributes = $class !== null ? self::readAttributes($class) : new AttributeCollection([]);
 
         // Retry options
         $retryOptions = RetryOptions::create(
@@ -99,7 +100,9 @@ public static function activity(
         $activityId === null or $options = $options->withActivityId((string)$activityId);
         $cancellationType === null or $options = $options->withCancellationType($cancellationType);
 
-        return Workflow::newActivityStub($class, $options);
+        return $class === null
+            ? Workflow::newUntypedActivityStub($options)
+            : Workflow::newActivityStub($class, $options);
     }
 
     /**

src/Internal/RetryOptions.php

@@ -48,9 +48,9 @@ public static function create(
         }
 
         $retryOptions = \Temporal\Common\RetryOptions::new();
-        $retryAttempts === 0 or $retryOptions = $retryOptions->withMaximumAttempts($retryAttempts);
-        $retryInitInterval === 0 or $retryOptions = $retryOptions->withInitialInterval($retryInitInterval);
-        $retryMaxInterval === 0 or $retryOptions = $retryOptions->withMaximumInterval($retryMaxInterval);
+        $retryAttempts > 0 and $retryOptions = $retryOptions->withMaximumAttempts($retryAttempts);
+        $retryInitInterval === null or $retryOptions = $retryOptions->withInitialInterval($retryInitInterval);
+        $retryMaxInterval === null or $retryOptions = $retryOptions->withMaximumInterval($retryMaxInterval);
         $retryBackoff >= 1.0 and $retryOptions = $retryOptions->withBackoffCoefficient($retryBackoff);
         $nonRetryables === [] or $retryOptions = $retryOptions->withNonRetryableExceptions($nonRetryables);
         return $retryOptions;

tests/Unit/Factory/ActivityStubTest.php

@@ -10,6 +10,7 @@
 use Temporal\Support\Factory\ActivityStub;
 use Temporal\Support\Tests\Stub\Activity\AttributedWithoutInterface;
 use Temporal\Workflow;
+use Temporal\Workflow\ActivityStubInterface;
 
 final class ActivityStubTest extends TestCase
 {
@@ -27,7 +28,7 @@ protected function setUp(): void
         parent::setUp();
     }
 
-    public function testDefaultsFromAttributes()
+    public function testDefaultsFromAttributes(): void
     {
         /** @var \Temporal\Activity\ActivityOptions $options */
         $options = ActivityStub::activity(
@@ -42,7 +43,7 @@ class: AttributedWithoutInterface::class,
         $this->assertSame('500.0', $options->retryOptions->maximumInterval->format('%s.%f'));
     }
 
-    public function testAttributeOverrides()
+    public function testAttributeOverrides(): void
     {
         /** @var \Temporal\Activity\ActivityOptions $options */
         $options = ActivityStub::activity(
@@ -65,4 +66,11 @@ class: AttributedWithoutInterface::class,
         $this->assertSame('10.0', $options->retryOptions->initialInterval->format('%s.%f'));
         $this->assertSame('200.0', $options->retryOptions->maximumInterval->format('%s.%f'));
     }
+
+    public function testUntypedActivity(): void
+    {
+        $activity = ActivityStub::activity();
+
+        self::assertInstanceOf(ActivityStubInterface::class, $activity);
+    }
 }