From c4f731896ae9b96638bd05f1add1a04775557ce9 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 3 Sep 2026 15:39:55 +0000 Subject: [PATCH 1/3] Initial plan From c809998cbc023e2938f69d3349f21bf1abc121cd Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 3 Sep 2026 15:41:35 +0000 Subject: [PATCH 2/3] Install consumer CI package locally Co-authored-by: arokem <118582+arokem@users.noreply.github.com> --- .github/workflows/ci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index da058ae..5ffa62f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -281,6 +281,7 @@ jobs: -DTRX_BUILD_TESTS=ON \ -DTRX_BUILD_EXAMPLES=ON \ -DTRX_ENABLE_NIFTI=ON \ + -DCMAKE_INSTALL_PREFIX="${GITHUB_WORKSPACE}/install" \ -DCMAKE_BUILD_TYPE=Release \ ${{ runner.os == 'Windows' && format('-DCMAKE_TOOLCHAIN_FILE={0}/vcpkg/scripts/buildsystems/vcpkg.cmake', github.workspace) || '' }} @@ -314,7 +315,7 @@ jobs: cmake -S "$consumer" -B "$consumer/build" \ -G Ninja \ -DCMAKE_BUILD_TYPE=Release \ - -DCMAKE_PREFIX_PATH="${GITHUB_WORKSPACE}/build" + -DCMAKE_PREFIX_PATH="${GITHUB_WORKSPACE}/install" - name: Build downstream consumer run: cmake --build ci-consumer/build --config Release \ No newline at end of file From 909dcf563fe4a77daf345e5b738324d8e8bbf0a2 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 3 Sep 2026 15:53:15 +0000 Subject: [PATCH 3/3] Fix consumer package dependency discovery Co-authored-by: arokem <118582+arokem@users.noreply.github.com> --- .github/workflows/ci.yml | 7 ++++++- cmake/trx-cppConfig.cmake.in | 3 ++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 5ffa62f..3dba1fe 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -312,10 +312,15 @@ jobs: } EOF + prefix_path="${GITHUB_WORKSPACE}/install" + if [[ "$RUNNER_OS" == "macOS" ]]; then + prefix_path="$(brew --prefix);${prefix_path}" + fi cmake -S "$consumer" -B "$consumer/build" \ -G Ninja \ -DCMAKE_BUILD_TYPE=Release \ - -DCMAKE_PREFIX_PATH="${GITHUB_WORKSPACE}/install" + -DCMAKE_PREFIX_PATH="$prefix_path" \ + ${{ runner.os == 'Windows' && format('-DCMAKE_TOOLCHAIN_FILE={0}/vcpkg/scripts/buildsystems/vcpkg.cmake', github.workspace) || '' }} - name: Build downstream consumer run: cmake --build ci-consumer/build --config Release \ No newline at end of file diff --git a/cmake/trx-cppConfig.cmake.in b/cmake/trx-cppConfig.cmake.in index 85e15bb..f8074e7 100644 --- a/cmake/trx-cppConfig.cmake.in +++ b/cmake/trx-cppConfig.cmake.in @@ -2,8 +2,9 @@ include(CMakeFindDependencyMacro) find_dependency(Eigen3) +find_dependency(libzip CONFIG) # mio and json11 are header-only and vendored; no package required -# libzip is a PRIVATE dependency — consumers do not need it +# libzip is a transitive dependency of the static library include("${CMAKE_CURRENT_LIST_DIR}/trx-cppTargets.cmake")