From 759a6b26f9836e28d801ff0d270637e9b2875b3d Mon Sep 17 00:00:00 2001 From: itsprade Date: Tue, 29 Sep 2026 17:37:53 +0530 Subject: [PATCH] fix(select): add inner padding to the dropdown The Select popup had no inner padding, so a highlighted option touched its edges. It now has the same 4px inset as Menu, Combobox and Autocomplete. Refs tailor-inc/platform-planning#1750 Co-Authored-By: Claude Opus 5.5 (cherry picked from commit e7b094fd8e8a067e89c20ea17a872ee481a832ab) --- .changeset/snug-lists-breathe.md | 5 +++++ .../src__components__select__select.test.tsx.snap | 6 +++--- packages/core/src/components/select/select.tsx | 2 +- 3 files changed, 9 insertions(+), 4 deletions(-) create mode 100644 .changeset/snug-lists-breathe.md diff --git a/.changeset/snug-lists-breathe.md b/.changeset/snug-lists-breathe.md new file mode 100644 index 000000000..3334ec3ad --- /dev/null +++ b/.changeset/snug-lists-breathe.md @@ -0,0 +1,5 @@ +--- +"@tailor-platform/app-shell": patch +--- + +`Select`'s dropdown now has a 4px inner gap, like `Menu`, `Combobox` and `Autocomplete`, so the highlighted option no longer touches the dropdown's edges. diff --git a/packages/core/__snapshots__/src__components__select__select.test.tsx.snap b/packages/core/__snapshots__/src__components__select__select.test.tsx.snap index 2e3872057..5d98e1442 100644 --- a/packages/core/__snapshots__/src__components__select__select.test.tsx.snap +++ b/packages/core/__snapshots__/src__components__select__select.test.tsx.snap @@ -2,10 +2,10 @@ exports[`Select > snapshots > closed select with placeholder 1`] = `""`; -exports[`Select > snapshots > disabled item 1`] = `"
Apple
Banana
"`; +exports[`Select > snapshots > disabled item 1`] = `"
Apple
Banana
"`; exports[`Select > snapshots > disabled select 1`] = `""`; -exports[`Select > snapshots > open select 1`] = `"
Apple
Banana
"`; +exports[`Select > snapshots > open select 1`] = `"
Apple
Banana
"`; -exports[`Select > snapshots > with groups and separator 1`] = `"
Apple
Carrot
"`; +exports[`Select > snapshots > with groups and separator 1`] = `"
Apple
Carrot
"`; diff --git a/packages/core/src/components/select/select.tsx b/packages/core/src/components/select/select.tsx index 8d2780c9a..be830a07a 100644 --- a/packages/core/src/components/select/select.tsx +++ b/packages/core/src/components/select/select.tsx @@ -100,7 +100,7 @@ function SelectContent({