From dcba2c17fb7346580f062c905cc15065c78606ba Mon Sep 17 00:00:00 2001 From: systemfsoftware-bot <318394648+systemfsoftware-bot@users.noreply.github.com> Date: Fri, 13 Nov 2026 00:43:58 -0500 Subject: [PATCH 1/2] ci: run mutation on main, not before the merge (SYS-1411) --- .github/workflows/ci.yml | 6 +++++- .../mutation-runs-on-main-not-before-the-merge.md | 10 ++++++++++ package.json | 2 +- 3 files changed, 16 insertions(+), 2 deletions(-) create mode 100644 docs/solutions/tooling-decisions/mutation-runs-on-main-not-before-the-merge.md diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 3f6af0060..693f9a417 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -38,9 +38,13 @@ jobs: restore-keys: | turbo-${{ runner.os }}-dist- turbo-${{ runner.os }}- - # Root package.json `check:ci` is the one definition. Never re-enumerate its steps here. + # Root package.json `check:ci` is the one definition of the pre-merge gate. Never re-enumerate its steps here. - name: Gate run: pnpm check:ci + # Mutation testing runs on main, never before the merge (owner, SYS-1411): run 43368492402's gate sat 44 min in it. + - name: Mutation + if: github.ref == 'refs/heads/main' + run: pnpm mutation e2e: name: e2e diff --git a/docs/solutions/tooling-decisions/mutation-runs-on-main-not-before-the-merge.md b/docs/solutions/tooling-decisions/mutation-runs-on-main-not-before-the-merge.md new file mode 100644 index 000000000..383e9f104 --- /dev/null +++ b/docs/solutions/tooling-decisions/mutation-runs-on-main-not-before-the-merge.md @@ -0,0 +1,10 @@ +--- +problem_type: tooling_decision +--- + +# Mutation Runs on Main, Not Before the Merge + +SYS-1411. `check:ci` ran `pnpm mutation` (Stryker, break threshold 100) on every pull request. In are-the-types-wrong-effect +run 43368492402 (job 131698452263, `ubuntu-latest`), the format, lint, typecheck, test and dist gates finished in about +50 s, the first package's mutation run took 9 min 12 s, and the job then sat in a second mutation run until it was +cancelled at 44 min. `check:ci` now holds the pre-merge gate, and `ci.yml` runs `pnpm mutation` on main only. diff --git a/package.json b/package.json index 69f37e313..aef78a730 100644 --- a/package.json +++ b/package.json @@ -20,7 +20,7 @@ "scripts": { "attw": "turbo --concurrency=${TURBO_CONCURRENCY:-50%} attw", "build": "turbo --concurrency=${TURBO_CONCURRENCY:-50%} build", - "check:ci": "s=0; pnpm format:check || s=1; TURBO_CONCURRENCY=${TURBO_CONCURRENCY:-100%} pnpm gate:tasks || s=1; pnpm gate:dist || s=1; pnpm mutation || s=1; exit $s", + "check:ci": "s=0; pnpm format:check || s=1; TURBO_CONCURRENCY=${TURBO_CONCURRENCY:-100%} pnpm gate:tasks || s=1; pnpm gate:dist || s=1; exit $s", "clean": "turbo clean", "format": "./bin/dprint fmt", "format:check": "./bin/dprint check", From c0b01499b6a0706999f93f8a326b061d22ce0840 Mon Sep 17 00:00:00 2001 From: systemfsoftware-bot <318394648+systemfsoftware-bot@users.noreply.github.com> Date: Fri, 13 Nov 2026 00:44:39 -0500 Subject: [PATCH 2/2] ci: keep mutation out of the pre-merge gate (SYS-1411) --- .github/workflows/ci.yml | 4 ---- ...-the-merge.md => mutation-does-not-run-inside-check-ci.md} | 4 ++-- 2 files changed, 2 insertions(+), 6 deletions(-) rename docs/solutions/tooling-decisions/{mutation-runs-on-main-not-before-the-merge.md => mutation-does-not-run-inside-check-ci.md} (71%) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 693f9a417..fda84141b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -41,10 +41,6 @@ jobs: # Root package.json `check:ci` is the one definition of the pre-merge gate. Never re-enumerate its steps here. - name: Gate run: pnpm check:ci - # Mutation testing runs on main, never before the merge (owner, SYS-1411): run 43368492402's gate sat 44 min in it. - - name: Mutation - if: github.ref == 'refs/heads/main' - run: pnpm mutation e2e: name: e2e diff --git a/docs/solutions/tooling-decisions/mutation-runs-on-main-not-before-the-merge.md b/docs/solutions/tooling-decisions/mutation-does-not-run-inside-check-ci.md similarity index 71% rename from docs/solutions/tooling-decisions/mutation-runs-on-main-not-before-the-merge.md rename to docs/solutions/tooling-decisions/mutation-does-not-run-inside-check-ci.md index 383e9f104..58466a8e3 100644 --- a/docs/solutions/tooling-decisions/mutation-runs-on-main-not-before-the-merge.md +++ b/docs/solutions/tooling-decisions/mutation-does-not-run-inside-check-ci.md @@ -2,9 +2,9 @@ problem_type: tooling_decision --- -# Mutation Runs on Main, Not Before the Merge +# Mutation Does Not Run Inside check:ci SYS-1411. `check:ci` ran `pnpm mutation` (Stryker, break threshold 100) on every pull request. In are-the-types-wrong-effect run 43368492402 (job 131698452263, `ubuntu-latest`), the format, lint, typecheck, test and dist gates finished in about 50 s, the first package's mutation run took 9 min 12 s, and the job then sat in a second mutation run until it was -cancelled at 44 min. `check:ci` now holds the pre-merge gate, and `ci.yml` runs `pnpm mutation` on main only. +cancelled at 44 min. `check:ci` no longer runs mutation; the shared `reusable-mutation.yml` (SYS-1417) owns it.