diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 3f6af0060..fda84141b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -38,7 +38,7 @@ jobs: restore-keys: | turbo-${{ runner.os }}-dist- turbo-${{ runner.os }}- - # Root package.json `check:ci` is the one definition. Never re-enumerate its steps here. + # Root package.json `check:ci` is the one definition of the pre-merge gate. Never re-enumerate its steps here. - name: Gate run: pnpm check:ci diff --git a/docs/solutions/tooling-decisions/mutation-does-not-run-inside-check-ci.md b/docs/solutions/tooling-decisions/mutation-does-not-run-inside-check-ci.md new file mode 100644 index 000000000..58466a8e3 --- /dev/null +++ b/docs/solutions/tooling-decisions/mutation-does-not-run-inside-check-ci.md @@ -0,0 +1,10 @@ +--- +problem_type: tooling_decision +--- + +# Mutation Does Not Run Inside check:ci + +SYS-1411. `check:ci` ran `pnpm mutation` (Stryker, break threshold 100) on every pull request. In are-the-types-wrong-effect +run 43368492402 (job 131698452263, `ubuntu-latest`), the format, lint, typecheck, test and dist gates finished in about +50 s, the first package's mutation run took 9 min 12 s, and the job then sat in a second mutation run until it was +cancelled at 44 min. `check:ci` no longer runs mutation; the shared `reusable-mutation.yml` (SYS-1417) owns it. diff --git a/package.json b/package.json index 69f37e313..aef78a730 100644 --- a/package.json +++ b/package.json @@ -20,7 +20,7 @@ "scripts": { "attw": "turbo --concurrency=${TURBO_CONCURRENCY:-50%} attw", "build": "turbo --concurrency=${TURBO_CONCURRENCY:-50%} build", - "check:ci": "s=0; pnpm format:check || s=1; TURBO_CONCURRENCY=${TURBO_CONCURRENCY:-100%} pnpm gate:tasks || s=1; pnpm gate:dist || s=1; pnpm mutation || s=1; exit $s", + "check:ci": "s=0; pnpm format:check || s=1; TURBO_CONCURRENCY=${TURBO_CONCURRENCY:-100%} pnpm gate:tasks || s=1; pnpm gate:dist || s=1; exit $s", "clean": "turbo clean", "format": "./bin/dprint fmt", "format:check": "./bin/dprint check",