Skip to content

Commit fe0e31f

Browse files
committed
Merge bitcoin#34053: lint: Remove confusing, redundant, and brittle lint-spelling
fa904fc lint: Remove confusing, redundant, and brittle lint-spelling (MarcoFalke) Pull request description: `codespell` was a fun experiment. However, it has many issues, when used in this project: * The number of false-positives and true-positives are in the same ballpark. There are also many false-negatives, so the overall net-benefit is questionable. * There is often confusion around spelling errors leading to a failing CI (they do not, which was intended). * LLMs released this year are capable to detect typos with less false-positives and less false-negatives, so the `codespell` integration is a bit redundant in that sense. Fix all issues by removing it. Going forward, anyone is free to continue to use `codespell`, or any LLM, or any other tool, locally. Also, DrahtBot has the LLM typo linter integrated in the summary comment. I think the options are plenty, and are more than sufficient for now. ACKs for top commit: l0rinc: ACK fa904fc rkrux: ACK fa904fc pablomartin4btc: ACK fa904fc Tree-SHA512: 5e2008a77c2c313605f30d73286111eba034a2a6bb2a0a48e2f77ec6ccc7afaa274e00bbfcb727be0ac5e547b8ae9c801d30c43589b0cad2099565e6716b9ec7
2 parents e5c600d + fa904fc commit fe0e31f

4 files changed

Lines changed: 0 additions & 74 deletions

File tree

ci/lint/01_install.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ command -v python3
4040
python3 --version
4141

4242
${CI_RETRY_EXE} pip3 install \
43-
codespell==2.4.1 \
4443
lief==0.16.6 \
4544
mypy==1.18.2 \
4645
pyzmq==27.1.0 \

test/lint/README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ or `--help`:
5050
| [`lint-python.py`](/test/lint/lint-python.py) | [pyzmq](https://github.com/zeromq/pyzmq)
5151
| [`lint-python-dead-code.py`](/test/lint/lint-python-dead-code.py) | [vulture](https://github.com/jendrikseipp/vulture)
5252
| [`lint-shell.py`](/test/lint/lint-shell.py) | [ShellCheck](https://github.com/koalaman/shellcheck)
53-
| [`lint-spelling.py`](/test/lint/lint-spelling.py) | [codespell](https://github.com/codespell-project/codespell)
5453
| `py_lint` | [ruff](https://github.com/astral-sh/ruff)
5554
| markdown link check | [mlc](https://github.com/becheran/mlc)
5655

test/lint/lint-spelling.py

Lines changed: 0 additions & 43 deletions
This file was deleted.

test/lint/spelling.ignore-words.txt

Lines changed: 0 additions & 29 deletions
This file was deleted.

0 commit comments

Comments
 (0)