forked from thomhurst/TUnit
-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathhook_changes.patch
More file actions
332 lines (308 loc) · 14.1 KB
/
Copy pathhook_changes.patch
File metadata and controls
332 lines (308 loc) · 14.1 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
diff --git a/TUnit.Engine/Services/HookCollectionService.cs b/TUnit.Engine/Services/HookCollectionService.cs
index 4db0f322b..719bf888a 100644
--- a/TUnit.Engine/Services/HookCollectionService.cs
+++ b/TUnit.Engine/Services/HookCollectionService.cs
@@ -2,12 +2,14 @@ using System.Collections.Concurrent;
using System.Reflection;
using TUnit.Core;
using TUnit.Core.Hooks;
+using TUnit.Engine.Helpers;
using TUnit.Engine.Interfaces;
namespace TUnit.Engine.Services;
internal sealed class HookCollectionService : IHookCollectionService
{
+ private readonly EventReceiverOrchestrator _eventReceiverOrchestrator;
private readonly ConcurrentDictionary<Type, IReadOnlyList<Func<TestContext, CancellationToken, Task>>> _beforeTestHooksCache = new();
private readonly ConcurrentDictionary<Type, IReadOnlyList<Func<TestContext, CancellationToken, Task>>> _afterTestHooksCache = new();
private readonly ConcurrentDictionary<Type, IReadOnlyList<Func<TestContext, CancellationToken, Task>>> _beforeEveryTestHooksCache = new();
@@ -18,6 +20,35 @@ internal sealed class HookCollectionService : IHookCollectionService
// Cache for complete hook chains to avoid repeated lookups
private readonly ConcurrentDictionary<Type, CompleteHookChain> _completeHookChainCache = new();
+ // Cache for processed hooks to avoid re-processing event receivers
+ private readonly ConcurrentDictionary<object, bool> _processedHooks = new();
+
+ public HookCollectionService(EventReceiverOrchestrator eventReceiverOrchestrator)
+ {
+ _eventReceiverOrchestrator = eventReceiverOrchestrator;
+ }
+
+ private async Task ProcessHookRegistrationAsync(HookMethod hookMethod, CancellationToken cancellationToken = default)
+ {
+ // Only process each hook once
+ if (!_processedHooks.TryAdd(hookMethod, true))
+ {
+ return;
+ }
+
+ try
+ {
+ var context = new HookRegisteredContext(hookMethod);
+
+ await _eventReceiverOrchestrator.InvokeHookRegistrationEventReceiversAsync(context, cancellationToken);
+ }
+ catch (Exception)
+ {
+ // Ignore errors during hook registration event processing to avoid breaking hook execution
+ // The EventReceiverOrchestrator already logs errors internally
+ }
+ }
+
private sealed class CompleteHookChain
{
public IReadOnlyList<Func<TestContext, CancellationToken, Task>> BeforeTestHooks { get; init; } = [
@@ -34,9 +65,19 @@ internal sealed class HookCollectionService : IHookCollectionService
];
}
- public ValueTask<IReadOnlyList<Func<TestContext, CancellationToken, Task>>> CollectBeforeTestHooksAsync(Type testClassType)
+ public async ValueTask<IReadOnlyList<Func<TestContext, CancellationToken, Task>>> CollectBeforeTestHooksAsync(Type testClassType)
{
- var hooks = _beforeTestHooksCache.GetOrAdd(testClassType, type =>
+ if (_beforeTestHooksCache.TryGetValue(testClassType, out var cachedHooks))
+ {
+ return cachedHooks;
+ }
+
+ var hooks = await BuildBeforeTestHooksAsync(testClassType);
+ _beforeTestHooksCache.TryAdd(testClassType, hooks);
+ return hooks;
+ }
+
+ private async Task<IReadOnlyList<Func<TestContext, CancellationToken, Task>>> BuildBeforeTestHooksAsync(Type type)
{
var hooksByType = new List<(Type type, List<(int order, int registrationIndex, Func<TestContext, CancellationToken, Task> hook)> hooks)>();
@@ -50,7 +91,7 @@ internal sealed class HookCollectionService : IHookCollectionService
{
foreach (var hook in sourceHooks)
{
- var hookFunc = CreateInstanceHookDelegate(hook);
+ var hookFunc = await CreateInstanceHookDelegateAsync(hook);
typeHooks.Add((hook.Order, hook.RegistrationIndex, hookFunc));
}
}
@@ -63,7 +104,7 @@ internal sealed class HookCollectionService : IHookCollectionService
{
foreach (var hook in openTypeHooks)
{
- var hookFunc = CreateInstanceHookDelegate(hook);
+ var hookFunc = await CreateInstanceHookDelegateAsync(hook);
typeHooks.Add((hook.Order, hook.RegistrationIndex, hookFunc));
}
}
@@ -89,14 +130,21 @@ internal sealed class HookCollectionService : IHookCollectionService
}
return finalHooks;
- });
-
- return new ValueTask<IReadOnlyList<Func<TestContext, CancellationToken, Task>>>(hooks);
}
- public ValueTask<IReadOnlyList<Func<TestContext, CancellationToken, Task>>> CollectAfterTestHooksAsync(Type testClassType)
+ public async ValueTask<IReadOnlyList<Func<TestContext, CancellationToken, Task>>> CollectAfterTestHooksAsync(Type testClassType)
{
- var hooks = _afterTestHooksCache.GetOrAdd(testClassType, type =>
+ if (_afterTestHooksCache.TryGetValue(testClassType, out var cachedHooks))
+ {
+ return cachedHooks;
+ }
+
+ var hooks = await BuildAfterTestHooksAsync(testClassType);
+ _afterTestHooksCache.TryAdd(testClassType, hooks);
+ return hooks;
+ }
+
+ private async Task<IReadOnlyList<Func<TestContext, CancellationToken, Task>>> BuildAfterTestHooksAsync(Type type)
{
var hooksByType = new List<(Type type, List<(int order, int registrationIndex, Func<TestContext, CancellationToken, Task> hook)> hooks)>();
@@ -110,7 +158,7 @@ internal sealed class HookCollectionService : IHookCollectionService
{
foreach (var hook in sourceHooks)
{
- var hookFunc = CreateInstanceHookDelegate(hook);
+ var hookFunc = await CreateInstanceHookDelegateAsync(hook);
typeHooks.Add((hook.Order, hook.RegistrationIndex, hookFunc));
}
}
@@ -123,7 +171,7 @@ internal sealed class HookCollectionService : IHookCollectionService
{
foreach (var hook in openTypeHooks)
{
- var hookFunc = CreateInstanceHookDelegate(hook);
+ var hookFunc = await CreateInstanceHookDelegateAsync(hook);
typeHooks.Add((hook.Order, hook.RegistrationIndex, hookFunc));
}
}
@@ -148,21 +196,28 @@ internal sealed class HookCollectionService : IHookCollectionService
}
return finalHooks;
- });
-
- return new ValueTask<IReadOnlyList<Func<TestContext, CancellationToken, Task>>>(hooks);
}
- public ValueTask<IReadOnlyList<Func<TestContext, CancellationToken, Task>>> CollectBeforeEveryTestHooksAsync(Type testClassType)
+ public async ValueTask<IReadOnlyList<Func<TestContext, CancellationToken, Task>>> CollectBeforeEveryTestHooksAsync(Type testClassType)
{
- var hooks = _beforeEveryTestHooksCache.GetOrAdd(testClassType, type =>
+ if (_beforeEveryTestHooksCache.TryGetValue(testClassType, out var cachedHooks))
+ {
+ return cachedHooks;
+ }
+
+ var hooks = await BuildBeforeEveryTestHooksAsync(testClassType);
+ _beforeEveryTestHooksCache.TryAdd(testClassType, hooks);
+ return hooks;
+ }
+
+ private async Task<IReadOnlyList<Func<TestContext, CancellationToken, Task>>> BuildBeforeEveryTestHooksAsync(Type type)
{
var allHooks = new List<(int order, int registrationIndex, Func<TestContext, CancellationToken, Task> hook)>();
// Collect all global BeforeEvery hooks
foreach (var hook in Sources.BeforeEveryTestHooks)
{
- var hookFunc = CreateStaticHookDelegate(hook);
+ var hookFunc = await CreateStaticHookDelegateAsync(hook);
allHooks.Add((hook.Order, hook.RegistrationIndex, hookFunc));
}
@@ -171,21 +226,28 @@ internal sealed class HookCollectionService : IHookCollectionService
.ThenBy(h => h.registrationIndex)
.Select(h => h.hook)
.ToList();
- });
-
- return new ValueTask<IReadOnlyList<Func<TestContext, CancellationToken, Task>>>(hooks);
}
- public ValueTask<IReadOnlyList<Func<TestContext, CancellationToken, Task>>> CollectAfterEveryTestHooksAsync(Type testClassType)
+ public async ValueTask<IReadOnlyList<Func<TestContext, CancellationToken, Task>>> CollectAfterEveryTestHooksAsync(Type testClassType)
{
- var hooks = _afterEveryTestHooksCache.GetOrAdd(testClassType, type =>
+ if (_afterEveryTestHooksCache.TryGetValue(testClassType, out var cachedHooks))
+ {
+ return cachedHooks;
+ }
+
+ var hooks = await BuildAfterEveryTestHooksAsync(testClassType);
+ _afterEveryTestHooksCache.TryAdd(testClassType, hooks);
+ return hooks;
+ }
+
+ private async Task<IReadOnlyList<Func<TestContext, CancellationToken, Task>>> BuildAfterEveryTestHooksAsync(Type type)
{
var allHooks = new List<(int order, int registrationIndex, Func<TestContext, CancellationToken, Task> hook)>();
// Collect all global AfterEvery hooks
foreach (var hook in Sources.AfterEveryTestHooks)
{
- var hookFunc = CreateStaticHookDelegate(hook);
+ var hookFunc = await CreateStaticHookDelegateAsync(hook);
allHooks.Add((hook.Order, hook.RegistrationIndex, hookFunc));
}
@@ -194,9 +256,6 @@ internal sealed class HookCollectionService : IHookCollectionService
.ThenBy(h => h.registrationIndex)
.Select(h => h.hook)
.ToList();
- });
-
- return new ValueTask<IReadOnlyList<Func<TestContext, CancellationToken, Task>>>(hooks);
}
public ValueTask<IReadOnlyList<Func<ClassHookContext, CancellationToken, Task>>> CollectBeforeClassHooksAsync(Type testClassType)
@@ -512,19 +571,37 @@ internal sealed class HookCollectionService : IHookCollectionService
return new ValueTask<IReadOnlyList<Func<AssemblyHookContext, CancellationToken, Task>>>(hooks);
}
- private static Func<TestContext, CancellationToken, Task> CreateInstanceHookDelegate(InstanceHookMethod hook)
+ private async Task<Func<TestContext, CancellationToken, Task>> CreateInstanceHookDelegateAsync(InstanceHookMethod hook)
{
+ // Process hook registration event receivers
+ await ProcessHookRegistrationAsync(hook);
+
return async (context, cancellationToken) =>
{
- await hook.ExecuteAsync(context, cancellationToken);
+ var timeoutAction = HookTimeoutHelper.CreateTimeoutHookAction(
+ (ctx, ct) => hook.ExecuteAsync(ctx, ct),
+ context,
+ hook.Timeout,
+ hook.Name,
+ cancellationToken);
+
+ await timeoutAction();
};
}
- private static Func<TestContext, CancellationToken, Task> CreateStaticHookDelegate(StaticHookMethod<TestContext> hook)
+ private async Task<Func<TestContext, CancellationToken, Task>> CreateStaticHookDelegateAsync(StaticHookMethod<TestContext> hook)
{
+ // Process hook registration event receivers
+ await ProcessHookRegistrationAsync(hook);
+
return async (context, cancellationToken) =>
{
- await hook.ExecuteAsync(context, cancellationToken);
+ var timeoutAction = HookTimeoutHelper.CreateTimeoutHookAction(
+ hook,
+ context,
+ cancellationToken);
+
+ await timeoutAction();
};
}
@@ -532,7 +609,12 @@ internal sealed class HookCollectionService : IHookCollectionService
{
return async (context, cancellationToken) =>
{
- await hook.ExecuteAsync(context, cancellationToken);
+ var timeoutAction = HookTimeoutHelper.CreateTimeoutHookAction(
+ hook,
+ context,
+ cancellationToken);
+
+ await timeoutAction();
};
}
@@ -540,7 +622,12 @@ internal sealed class HookCollectionService : IHookCollectionService
{
return async (context, cancellationToken) =>
{
- await hook.ExecuteAsync(context, cancellationToken);
+ var timeoutAction = HookTimeoutHelper.CreateTimeoutHookAction(
+ hook,
+ context,
+ cancellationToken);
+
+ await timeoutAction();
};
}
@@ -548,7 +635,12 @@ internal sealed class HookCollectionService : IHookCollectionService
{
return async (context, cancellationToken) =>
{
- await hook.ExecuteAsync(context, cancellationToken);
+ var timeoutAction = HookTimeoutHelper.CreateTimeoutHookAction(
+ hook,
+ context,
+ cancellationToken);
+
+ await timeoutAction();
};
}
@@ -556,7 +648,12 @@ internal sealed class HookCollectionService : IHookCollectionService
{
return async (context, cancellationToken) =>
{
- await hook.ExecuteAsync(context, cancellationToken);
+ var timeoutAction = HookTimeoutHelper.CreateTimeoutHookAction(
+ hook,
+ context,
+ cancellationToken);
+
+ await timeoutAction();
};
}
@@ -564,7 +661,12 @@ internal sealed class HookCollectionService : IHookCollectionService
{
return async (context, cancellationToken) =>
{
- await hook.ExecuteAsync(context, cancellationToken);
+ var timeoutAction = HookTimeoutHelper.CreateTimeoutHookAction(
+ hook,
+ context,
+ cancellationToken);
+
+ await timeoutAction();
};
}