Skip to content

Commit 64cd092

Browse files
committed
Fix awful typo in fix for VD-1301 vulnerability.
Thank you @karlp.
1 parent 7098bed commit 64cd092

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

src/modbus.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -866,7 +866,7 @@ int modbus_reply(modbus_t *ctx, const uint8_t *req,
866866
int nb = (req[offset + 3] << 8) + req[offset + 4];
867867
int nb_bytes = req[offset + 5];
868868

869-
if (nb < 1 || MODBUS_MAX_WRITE_REGISTERS < nb || nb_bytes * 8 < nb) {
869+
if (nb < 1 || MODBUS_MAX_WRITE_REGISTERS < nb || nb_bytes != 2 * nb) {
870870
if (ctx->debug) {
871871
fprintf(stderr,
872872
"Illegal number of values %d in write_registers (max %d)\n",

0 commit comments

Comments
 (0)