From 7d46e7c69553ca4b254da5d8cb210c7261772d9f Mon Sep 17 00:00:00 2001 From: Claude Date: Wed, 21 Oct 2026 10:17:15 +0000 Subject: [PATCH] test: migrate `stats/base/dists/triangular/pdf` to ULP-based assertions Migrate the remaining relative tolerance test cases in `test.factory.js` to ULP difference testing, matching the already migrated `test.pdf.js` and `test.native.js` in this package. The measured maximum ULP difference across all three fixture sets (small, medium, and large range; 3000 values) is zero, so the minimum required ULP value is 0. Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01JXoRr3mZZKDUogNbuRfHXz --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../dists/triangular/pdf/test/test.factory.js | 33 +++---------------- 1 file changed, 4 insertions(+), 29 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/triangular/pdf/test/test.factory.js b/lib/node_modules/@stdlib/stats/base/dists/triangular/pdf/test/test.factory.js index 72d08649912a..4ec119eb96ed 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/triangular/pdf/test/test.factory.js +++ b/lib/node_modules/@stdlib/stats/base/dists/triangular/pdf/test/test.factory.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var factory = require( './../lib/factory.js' ); @@ -180,9 +179,7 @@ tape( 'if provided valid parameters, the created function returns `2/(b-a)` in c tape( 'the created function evaluates the pdf for `x` given small range `b - a`', function test( t ) { var expected; - var delta; var pdf; - var tol; var a; var b; var c; @@ -198,22 +195,14 @@ tape( 'the created function evaluates the pdf for `x` given small range `b - a`' for ( i = 0; i < x.length; i++ ) { pdf = factory( a[i], b[i], c[i] ); y = pdf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', a: '+a[i]+', b: '+b[i]+', c: '+c[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. c: '+c[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } t.end(); }); tape( 'the created function evaluates the pdf for `x` given a medium range `b - a`', function test( t ) { var expected; - var delta; var pdf; - var tol; var a; var b; var c; @@ -229,22 +218,14 @@ tape( 'the created function evaluates the pdf for `x` given a medium range `b - for ( i = 0; i < x.length; i++ ) { pdf = factory( a[i], b[i], c[i] ); y = pdf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', a: '+a[i]+', b: '+b[i]+', c: '+c[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. c: '+c[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } t.end(); }); tape( 'the created function evaluates the pdf for `x` given a large range `b - a`', function test( t ) { var expected; - var delta; var pdf; - var tol; var a; var b; var c; @@ -260,13 +241,7 @@ tape( 'the created function evaluates the pdf for `x` given a large range `b - a for ( i = 0; i < x.length; i++ ) { pdf = factory( a[i], b[i], c[i] ); y = pdf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', a: '+a[i]+', b: '+b[i]+', c: '+c[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. c: '+c[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } t.end(); });