From 70b1ebdd7fc560ec66f93f37c036bf283c4895b7 Mon Sep 17 00:00:00 2001 From: Claude Date: Wed, 14 Oct 2026 18:22:44 +0000 Subject: [PATCH] test: migrate `constants/float32/ln-sqrt-two-pi` to ULP-based assertions Replace the relative tolerance assertion in the package's test suite with a ULP difference assertion using `@stdlib/number/float32/base/assert/is-almost-same-value`. The computed value is exactly equal to the exported constant, so the minimum required ULP bound is `0`. Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01GkXfXrD8gfxspXedgyNAXa --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../float32/ln-sqrt-two-pi/test/test.js | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/lib/node_modules/@stdlib/constants/float32/ln-sqrt-two-pi/test/test.js b/lib/node_modules/@stdlib/constants/float32/ln-sqrt-two-pi/test/test.js index 32a0edf53cd8..614b9855a96e 100644 --- a/lib/node_modules/@stdlib/constants/float32/ln-sqrt-two-pi/test/test.js +++ b/lib/node_modules/@stdlib/constants/float32/ln-sqrt-two-pi/test/test.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/number/float32/base/assert/is-almost-same-value' ); var lnf = require( '@stdlib/math/base/special/lnf' ); var sqrtf = require( '@stdlib/math/base/special/sqrtf' ); -var absf = require( '@stdlib/math/base/special/absf' ); var FLOAT32_TWO_PI = require( '@stdlib/constants/float32/two-pi' ); -var EPS = require( '@stdlib/constants/float32/eps' ); var FLOAT32_LN_SQRT_TWO_PI = require( './../lib' ); @@ -43,16 +42,7 @@ tape( 'export is a single-precision floating-point number equal to 0.91893851757 }); tape( 'export equals ln(sqrt(2π))', function test( t ) { - var delta; - var tol; - var v; - - v = lnf( sqrtf( FLOAT32_TWO_PI ) ); - - delta = absf( v - FLOAT32_LN_SQRT_TWO_PI ); - tol = EPS * FLOAT32_LN_SQRT_TWO_PI; - - t.ok( delta <= tol, 'equals ln(sqrt(2π)) within tolerance '+tol ); - + var v = lnf( sqrtf( FLOAT32_TWO_PI ) ); + t.strictEqual( isAlmostSameValue( v, FLOAT32_LN_SQRT_TWO_PI, 0 ), true, 'returns expected value' ); t.end(); });