From 7510f0212a109a614941ff7dbf8b1e7ed4d4e85e Mon Sep 17 00:00:00 2001 From: Claude Date: Tue, 13 Oct 2026 09:11:32 +0000 Subject: [PATCH 1/2] test: migrate `stats/base/dists/lognormal/kurtosis` to ULP-based assertions Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Sonnet 5.5 Claude-Session: https://claude.ai/code/session_01GGZLZ7tFwcNGz5oNkh3QJT --- .../base/dists/lognormal/kurtosis/test/test.js | 15 ++++----------- .../dists/lognormal/kurtosis/test/test.native.js | 15 ++++----------- 2 files changed, 8 insertions(+), 22 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/lognormal/kurtosis/test/test.js b/lib/node_modules/@stdlib/stats/base/dists/lognormal/kurtosis/test/test.js index aee88f7fb4a0..6b39180a64e7 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/lognormal/kurtosis/test/test.js +++ b/lib/node_modules/@stdlib/stats/base/dists/lognormal/kurtosis/test/test.js @@ -22,10 +22,9 @@ var tape = require( 'tape' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var kurtosis = require( './../lib' ); @@ -76,26 +75,20 @@ tape( 'if provided a nonpositive `sigma`, the function returns `NaN`', function tape( 'the function returns the excess kurtosis of a lognormal distribution', function test( t ) { var expected; - var delta; var sigma; - var tol; + var ULP; var mu; var y; var i; + ULP = 16; expected = data.expected; mu = data.mu; sigma = data.sigma; for ( i = 0; i < mu.length; i++ ) { y = kurtosis( mu[i], sigma[i] ); if ( expected[i] !== null ) { - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'mu:'+mu[i]+', sigma: '+sigma[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 10.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. mu: '+mu[i]+'. sigma: '+sigma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], ULP ), true, 'returns expected value' ); } } t.end(); diff --git a/lib/node_modules/@stdlib/stats/base/dists/lognormal/kurtosis/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/lognormal/kurtosis/test/test.native.js index 305ee549209c..7978117871db 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/lognormal/kurtosis/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/lognormal/kurtosis/test/test.native.js @@ -24,10 +24,9 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); var tryRequire = require( '@stdlib/utils/try-require' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); // FIXTURES // @@ -88,26 +87,20 @@ tape( 'if provided a nonpositive `sigma`, the function returns `NaN`', opts, fun tape( 'the function returns the excess kurtosis of a lognormal distribution', opts, function test( t ) { var expected; - var delta; var sigma; - var tol; + var ULP; var mu; var y; var i; + ULP = 16; expected = data.expected; mu = data.mu; sigma = data.sigma; for ( i = 0; i < mu.length; i++ ) { y = kurtosis( mu[i], sigma[i] ); if ( expected[i] !== null ) { - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'mu:'+mu[i]+', sigma: '+sigma[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 160.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. mu: '+mu[i]+'. sigma: '+sigma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], ULP ), true, 'returns expected value' ); } } t.end(); From 016966cbf6f565ff7ffc0b0d088d6d947d6faf8c Mon Sep 17 00:00:00 2001 From: Athan Date: Tue, 13 Oct 2026 12:28:05 +0200 Subject: [PATCH 2/2] Apply batched suggestions from code review Co-authored-by: Athan Signed-off-by: Athan --- .../@stdlib/stats/base/dists/lognormal/kurtosis/test/test.js | 4 +--- .../stats/base/dists/lognormal/kurtosis/test/test.native.js | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/lognormal/kurtosis/test/test.js b/lib/node_modules/@stdlib/stats/base/dists/lognormal/kurtosis/test/test.js index 6b39180a64e7..897e52be9a62 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/lognormal/kurtosis/test/test.js +++ b/lib/node_modules/@stdlib/stats/base/dists/lognormal/kurtosis/test/test.js @@ -76,19 +76,17 @@ tape( 'if provided a nonpositive `sigma`, the function returns `NaN`', function tape( 'the function returns the excess kurtosis of a lognormal distribution', function test( t ) { var expected; var sigma; - var ULP; var mu; var y; var i; - ULP = 16; expected = data.expected; mu = data.mu; sigma = data.sigma; for ( i = 0; i < mu.length; i++ ) { y = kurtosis( mu[i], sigma[i] ); if ( expected[i] !== null ) { - t.strictEqual( isAlmostSameValue( y, expected[ i ], ULP ), true, 'returns expected value' ); + t.strictEqual( isAlmostSameValue( y, expected[ i ], 16 ), true, 'returns expected value' ); } } t.end(); diff --git a/lib/node_modules/@stdlib/stats/base/dists/lognormal/kurtosis/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/lognormal/kurtosis/test/test.native.js index 7978117871db..ec9ea24d0dbd 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/lognormal/kurtosis/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/lognormal/kurtosis/test/test.native.js @@ -88,19 +88,17 @@ tape( 'if provided a nonpositive `sigma`, the function returns `NaN`', opts, fun tape( 'the function returns the excess kurtosis of a lognormal distribution', opts, function test( t ) { var expected; var sigma; - var ULP; var mu; var y; var i; - ULP = 16; expected = data.expected; mu = data.mu; sigma = data.sigma; for ( i = 0; i < mu.length; i++ ) { y = kurtosis( mu[i], sigma[i] ); if ( expected[i] !== null ) { - t.strictEqual( isAlmostSameValue( y, expected[ i ], ULP ), true, 'returns expected value' ); + t.strictEqual( isAlmostSameValue( y, expected[ i ], 16 ), true, 'returns expected value' ); } } t.end();