From 136883144598891777ab3e746becc7de65e0d719 Mon Sep 17 00:00:00 2001 From: Athan Reines Date: Fri, 9 Oct 2026 22:30:52 +0000 Subject: [PATCH] test: migrate `stats/base/dists/t/variance` to ULP-based assertions Replaces the computed relative tolerance comparison in the native test fixture loop with a ULP-based assertion. The measured minimum required ULP difference over the full fixture set is zero for both the JavaScript and C implementations, which is consistent with the exact assertions already used in `test/test.js`. Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01JJ2JUhP1NnZRW3mrjB7UpH --- .../stats/base/dists/t/variance/test/test.native.js | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/t/variance/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/t/variance/test/test.native.js index d678788cc4d6..db8cd00c0c14 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/t/variance/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/t/variance/test/test.native.js @@ -23,9 +23,8 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); var tryRequire = require( '@stdlib/utils/try-require' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var PINF = require( '@stdlib/constants/float64/pinf' ); @@ -88,8 +87,6 @@ tape( 'if provided `1 < v <= 2`, the function returns `Infinity`', opts, functio tape( 'the function evaluates the variance for a Student\'s t-distribution', opts, function test( t ) { var expected; - var delta; - var tol; var v; var y; var i; @@ -98,13 +95,7 @@ tape( 'the function evaluates the variance for a Student\'s t-distribution', opt v = data.v; for ( i = 0; i < v.length; i++ ) { y = variance( v[ i ] ); - if ( y === expected[ i ] ) { - t.strictEqual( y, expected[ i ], 'v: ' + v[ i ] + ', y: ' + y + ', expected: ' + expected[ i ] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 2.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. v: ' + v[ i ] + '. y: ' + y + '. E: ' + expected[ i ] + '. Δ: ' + delta + '. tol: ' + tol + '.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } t.end(); });