From 66158c9408c7ddcb1dc9b6e650f29e1958c0ccb0 Mon Sep 17 00:00:00 2001 From: Claude Date: Fri, 9 Oct 2026 21:10:02 +0000 Subject: [PATCH 1/2] test: migrate `math/base/utils/absolute-difference` to ULP-based assertions Co-Authored-By: Claude Sonnet 5.5 Claude-Session: https://claude.ai/code/session_011F4VrJVWCbjPGYF6XKrJtA --- .../utils/absolute-difference/test/test.js | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/lib/node_modules/@stdlib/math/base/utils/absolute-difference/test/test.js b/lib/node_modules/@stdlib/math/base/utils/absolute-difference/test/test.js index 52e25e85cbf1..442370f5b605 100644 --- a/lib/node_modules/@stdlib/math/base/utils/absolute-difference/test/test.js +++ b/lib/node_modules/@stdlib/math/base/utils/absolute-difference/test/test.js @@ -21,15 +21,19 @@ // MODULES // var tape = require( 'tape' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var isPositiveZero = require( '@stdlib/math/base/assert/is-positive-zero' ); +var isAlmostSameValue = require( '@stdlib/number/float64/base/assert/is-almost-same-value' ); var diff = require( './../lib' ); +// VARIABLES // + +var ULP = 1; + + // TESTS // tape( 'main export is a function', function test( t ) { @@ -112,22 +116,16 @@ tape( 'if `x` and/or `y` is `NaN`, the function returns `NaN`', function test( t }); tape( 'the function computes the absolute difference', function test( t ) { - var delta; - var tol; var d; d = diff( 2.0, 5.0 ); t.strictEqual( d, 3.0, 'returns 3' ); d = diff( -1.0, 3.14 ); - delta = abs( d - 4.14 ); - tol = EPS * 4.14; - t.ok( delta <= tol, 'returns ~4.14' ); + t.strictEqual( isAlmostSameValue( d, 4.14, ULP ), true, 'returns expected value' ); d = diff( 10.1, -2.05 ); - delta = abs( d - 12.15 ); - tol = EPS * 12.15; - t.ok( delta <= tol, 'returns ~12.05' ); + t.strictEqual( isAlmostSameValue( d, 12.15, ULP ), true, 'returns expected value' ); d = diff( -0.0, 0.0 ); t.strictEqual( isPositiveZero( d ), true, 'returns expected value' ); From 36fdc4d11e880ff339bda5da0ad03ec96a02d36d Mon Sep 17 00:00:00 2001 From: Athan Date: Sun, 11 Oct 2026 14:37:47 +0200 Subject: [PATCH 2/2] Apply batched suggestions from code review Co-authored-by: Athan Signed-off-by: Athan --- .../math/base/utils/absolute-difference/test/test.js | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/lib/node_modules/@stdlib/math/base/utils/absolute-difference/test/test.js b/lib/node_modules/@stdlib/math/base/utils/absolute-difference/test/test.js index 442370f5b605..06c54258000f 100644 --- a/lib/node_modules/@stdlib/math/base/utils/absolute-difference/test/test.js +++ b/lib/node_modules/@stdlib/math/base/utils/absolute-difference/test/test.js @@ -29,11 +29,6 @@ var isAlmostSameValue = require( '@stdlib/number/float64/base/assert/is-almost-s var diff = require( './../lib' ); -// VARIABLES // - -var ULP = 1; - - // TESTS // tape( 'main export is a function', function test( t ) { @@ -122,10 +117,10 @@ tape( 'the function computes the absolute difference', function test( t ) { t.strictEqual( d, 3.0, 'returns 3' ); d = diff( -1.0, 3.14 ); - t.strictEqual( isAlmostSameValue( d, 4.14, ULP ), true, 'returns expected value' ); + t.strictEqual( isAlmostSameValue( d, 4.14, 1 ), true, 'returns expected value' ); d = diff( 10.1, -2.05 ); - t.strictEqual( isAlmostSameValue( d, 12.15, ULP ), true, 'returns expected value' ); + t.strictEqual( isAlmostSameValue( d, 12.15, 1 ), true, 'returns expected value' ); d = diff( -0.0, 0.0 ); t.strictEqual( isPositiveZero( d ), true, 'returns expected value' );