From 0237ea62a036e362eaf3487f379fb01cf4da3d60 Mon Sep 17 00:00:00 2001 From: Claude Date: Wed, 7 Oct 2026 06:33:42 +0000 Subject: [PATCH] test: migrate `stats/base/dists/gamma/mgf` to ULP-based assertions Replace computed relative tolerance comparisons with ULP-based assertions using `@stdlib/assert/is-almost-same-value`. The ULP bounds were tightened to the measured minimums over the full 1000-case fixture sets: 3259 (`both_large`), 10882 (`large_shape`), and 2062 (`large_rate`). The JavaScript and native implementations require identical bounds. Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_013vj7gTBcnhuXinFm5GiE5g --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../base/dists/gamma/mgf/test/test.factory.js | 33 +++---------------- .../base/dists/gamma/mgf/test/test.mgf.js | 33 +++---------------- .../base/dists/gamma/mgf/test/test.native.js | 33 +++---------------- 3 files changed, 12 insertions(+), 87 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/gamma/mgf/test/test.factory.js b/lib/node_modules/@stdlib/stats/base/dists/gamma/mgf/test/test.factory.js index b31edb8afbe1..4b90c6970d7e 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/gamma/mgf/test/test.factory.js +++ b/lib/node_modules/@stdlib/stats/base/dists/gamma/mgf/test/test.factory.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var factory = require( './../lib/factory.js' ); @@ -141,11 +140,9 @@ tape( 'if provided `alpha < 0`, the created function always returns `NaN`', func tape( 'the created function evaluates the mgf for `x` given large `alpha` and `beta`', function test( t ) { var expected; - var delta; var alpha; var beta; var mgf; - var tol; var x; var y; var i; @@ -157,24 +154,16 @@ tape( 'the created function evaluates the mgf for `x` given large `alpha` and `b for ( i = 0; i < x.length; i++ ) { mgf = factory( alpha[i], beta[i] ); y = mgf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', alpha: '+alpha[i]+', beta: '+beta[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 3000.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. alpha: '+alpha[i]+'. beta: '+beta[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 3259 ), true, 'returns expected value' ); } t.end(); }); tape( 'the created function evaluates the mgf for `x` given a large shape parameter `alpha`', function test( t ) { var expected; - var delta; var alpha; var beta; var mgf; - var tol; var x; var y; var i; @@ -186,24 +175,16 @@ tape( 'the created function evaluates the mgf for `x` given a large shape parame for ( i = 0; i < x.length; i++ ) { mgf = factory( alpha[i], beta[i] ); y = mgf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', alpha: '+alpha[i]+', beta: '+beta[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 6500.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. alpha: '+alpha[i]+'. beta: '+beta[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 10882 ), true, 'returns expected value' ); } t.end(); }); tape( 'the created function evaluates the mgf for `x` given a large rate parameter `beta`', function test( t ) { var expected; - var delta; var alpha; var beta; var mgf; - var tol; var x; var y; var i; @@ -215,13 +196,7 @@ tape( 'the created function evaluates the mgf for `x` given a large rate paramet for ( i = 0; i < x.length; i++ ) { mgf = factory( alpha[i], beta[i] ); y = mgf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', alpha: '+alpha[i]+', beta: '+beta[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1200.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. alpha: '+alpha[i]+'. beta: '+beta[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 2062 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/gamma/mgf/test/test.mgf.js b/lib/node_modules/@stdlib/stats/base/dists/gamma/mgf/test/test.mgf.js index 6d6d0286138a..ec049a38063c 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/gamma/mgf/test/test.mgf.js +++ b/lib/node_modules/@stdlib/stats/base/dists/gamma/mgf/test/test.mgf.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var mgf = require( './../lib' ); @@ -104,10 +103,8 @@ tape( 'if provided a nonpositive `beta`, the function returns `NaN`', function t tape( 'the function evaluates the MGF for `x` given large `alpha` and `beta`', function test( t ) { var expected; - var delta; var alpha; var beta; - var tol; var x; var y; var i; @@ -118,23 +115,15 @@ tape( 'the function evaluates the MGF for `x` given large `alpha` and `beta`', f beta = bothLarge.beta; for ( i = 0; i < x.length; i++ ) { y = mgf( x[i], alpha[i], beta[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', alpha: '+alpha[i]+', beta: '+beta[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 3000.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. alpha: '+alpha[i]+'. beta: '+beta[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 3259 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the MGF for `x` given large shape parameter `alpha`', function test( t ) { var expected; - var delta; var alpha; var beta; - var tol; var x; var y; var i; @@ -145,23 +134,15 @@ tape( 'the function evaluates the MGF for `x` given large shape parameter `alpha beta = largeShape.beta; for ( i = 0; i < x.length; i++ ) { y = mgf( x[i], alpha[i], beta[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', alpha: '+alpha[i]+', beta: '+beta[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 6500.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. alpha: '+alpha[i]+'. beta: '+beta[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 10882 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the MGF for `x` given large rate parameter `beta`', function test( t ) { var expected; - var delta; var alpha; var beta; - var tol; var x; var y; var i; @@ -172,13 +153,7 @@ tape( 'the function evaluates the MGF for `x` given large rate parameter `beta`' beta = largeRate.beta; for ( i = 0; i < x.length; i++ ) { y = mgf( x[i], alpha[i], beta[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', alpha: '+alpha[i]+', beta: '+beta[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 2200.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. alpha: '+alpha[i]+'. beta: '+beta[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 2062 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/gamma/mgf/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/gamma/mgf/test/test.native.js index 04624a430e24..8c838d6ecd6a 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/gamma/mgf/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/gamma/mgf/test/test.native.js @@ -22,12 +22,11 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var tryRequire = require( '@stdlib/utils/try-require' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); // FIXTURES // @@ -113,10 +112,8 @@ tape( 'if provided a nonpositive `beta`, the function returns `NaN`', opts, func tape( 'the function evaluates the MGF for `x` given large `alpha` and `beta`', opts, function test( t ) { var expected; - var delta; var alpha; var beta; - var tol; var x; var y; var i; @@ -127,23 +124,15 @@ tape( 'the function evaluates the MGF for `x` given large `alpha` and `beta`', o beta = bothLarge.beta; for ( i = 0; i < x.length; i++ ) { y = mgf( x[i], alpha[i], beta[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', alpha: '+alpha[i]+', beta: '+beta[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 3000.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. alpha: '+alpha[i]+'. beta: '+beta[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 3259 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the MGF for `x` given large shape parameter `alpha`', opts, function test( t ) { var expected; - var delta; var alpha; var beta; - var tol; var x; var y; var i; @@ -154,23 +143,15 @@ tape( 'the function evaluates the MGF for `x` given large shape parameter `alpha beta = largeShape.beta; for ( i = 0; i < x.length; i++ ) { y = mgf( x[i], alpha[i], beta[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', alpha: '+alpha[i]+', beta: '+beta[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 6500.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. alpha: '+alpha[i]+'. beta: '+beta[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 10882 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the MGF for `x` given large rate parameter `beta`', opts, function test( t ) { var expected; - var delta; var alpha; var beta; - var tol; var x; var y; var i; @@ -181,13 +162,7 @@ tape( 'the function evaluates the MGF for `x` given large rate parameter `beta`' beta = largeRate.beta; for ( i = 0; i < x.length; i++ ) { y = mgf( x[i], alpha[i], beta[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', alpha: '+alpha[i]+', beta: '+beta[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 2200.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. alpha: '+alpha[i]+'. beta: '+beta[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 2062 ), true, 'returns expected value' ); } t.end(); });