From 0808c2c5248fb9fa3f5b24c838220cbabf9e52ae Mon Sep 17 00:00:00 2001 From: Claude Date: Mon, 5 Oct 2026 22:27:57 +0000 Subject: [PATCH] test: migrate `stats/base/dists/discrete-uniform/quantile` to ULP-based assertions Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01VdWTZQyfuCaFizioXQ6JKf --- .../quantile/test/test.factory.js | 33 +++---------------- .../quantile/test/test.native.js | 33 +++---------------- .../quantile/test/test.quantile.js | 33 +++---------------- 3 files changed, 12 insertions(+), 87 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/discrete-uniform/quantile/test/test.factory.js b/lib/node_modules/@stdlib/stats/base/dists/discrete-uniform/quantile/test/test.factory.js index 2c429a67806e..f005b408481c 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/discrete-uniform/quantile/test/test.factory.js +++ b/lib/node_modules/@stdlib/stats/base/dists/discrete-uniform/quantile/test/test.factory.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var factory = require( './../lib/factory.js' ); @@ -132,8 +131,6 @@ tape( 'if provided `a > b`, the created function always returns `NaN`', function tape( 'the created function evaluates the quantile for `p` given a small range `b - a`', function test( t ) { var expected; var quantile; - var delta; - var tol; var a; var b; var i; @@ -147,13 +144,7 @@ tape( 'the created function evaluates the quantile for `p` given a small range ` for ( i = 0; i < p.length; i++ ) { quantile = factory( a[i], b[i] ); y = quantile( p[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', a: '+a[i]+', b: '+b[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } t.end(); }); @@ -161,8 +152,6 @@ tape( 'the created function evaluates the quantile for `p` given a small range ` tape( 'the created function evaluates the quantile for `p` given a medium range `b - a`', function test( t ) { var expected; var quantile; - var delta; - var tol; var a; var b; var i; @@ -176,13 +165,7 @@ tape( 'the created function evaluates the quantile for `p` given a medium range for ( i = 0; i < p.length; i++ ) { quantile = factory( a[i], b[i] ); y = quantile( p[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', a: '+a[i]+', b: '+b[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } t.end(); }); @@ -190,8 +173,6 @@ tape( 'the created function evaluates the quantile for `p` given a medium range tape( 'the created function evaluates the quantile for `p` given a large range `b - a`', function test( t ) { var expected; var quantile; - var delta; - var tol; var a; var b; var i; @@ -205,13 +186,7 @@ tape( 'the created function evaluates the quantile for `p` given a large range ` for ( i = 0; i < p.length; i++ ) { quantile = factory( a[i], b[i] ); y = quantile( p[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', a: '+a[i]+', b: '+b[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/discrete-uniform/quantile/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/discrete-uniform/quantile/test/test.native.js index 0c06f6cb3ff1..54a8525420a7 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/discrete-uniform/quantile/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/discrete-uniform/quantile/test/test.native.js @@ -22,9 +22,8 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var tryRequire = require( '@stdlib/utils/try-require' ); @@ -79,8 +78,6 @@ tape( 'if provided `a > b`, the function returns `NaN`', opts, function test( t tape( 'the function evaluates the quantile for `p` given a small range `b - a`', opts, function test( t ) { var expected; - var delta; - var tol; var a; var b; var i; @@ -93,21 +90,13 @@ tape( 'the function evaluates the quantile for `p` given a small range `b - a`', b = smallRange.b; for ( i = 0; i < p.length; i++ ) { y = quantile( p[i], a[i], b[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', a: '+a[i]+', b: '+b[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the quantile for `p` given a medium range `b - a`', opts, function test( t ) { var expected; - var delta; - var tol; var a; var b; var i; @@ -120,21 +109,13 @@ tape( 'the function evaluates the quantile for `p` given a medium range `b - a`' b = mediumRange.b; for ( i = 0; i < p.length; i++ ) { y = quantile( p[i], a[i], b[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', a: '+a[i]+', b: '+b[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the quantile for `p` given a large range `b - a`', opts, function test( t ) { var expected; - var delta; - var tol; var a; var b; var i; @@ -147,13 +128,7 @@ tape( 'the function evaluates the quantile for `p` given a large range `b - a`', b = largeRange.b; for ( i = 0; i < p.length; i++ ) { y = quantile( p[i], a[i], b[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', a: '+a[i]+', b: '+b[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/discrete-uniform/quantile/test/test.quantile.js b/lib/node_modules/@stdlib/stats/base/dists/discrete-uniform/quantile/test/test.quantile.js index 67ffc297b1e4..976d55f79916 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/discrete-uniform/quantile/test/test.quantile.js +++ b/lib/node_modules/@stdlib/stats/base/dists/discrete-uniform/quantile/test/test.quantile.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var quantile = require( './../lib' ); @@ -91,8 +90,6 @@ tape( 'if provided a non-integer value for `a` or `b`, the function returns `NaN tape( 'the function evaluates the quantile for `p` given a small range `b - a`', function test( t ) { var expected; - var delta; - var tol; var a; var b; var i; @@ -105,21 +102,13 @@ tape( 'the function evaluates the quantile for `p` given a small range `b - a`', b = smallRange.b; for ( i = 0; i < p.length; i++ ) { y = quantile( p[i], a[i], b[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', a: '+a[i]+', b: '+b[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the quantile for `p` given a medium range `b - a`', function test( t ) { var expected; - var delta; - var tol; var a; var b; var i; @@ -132,21 +121,13 @@ tape( 'the function evaluates the quantile for `p` given a medium range `b - a`' b = mediumRange.b; for ( i = 0; i < p.length; i++ ) { y = quantile( p[i], a[i], b[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', a: '+a[i]+', b: '+b[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the quantile for `p` given a large range `b - a`', function test( t ) { var expected; - var delta; - var tol; var a; var b; var i; @@ -159,13 +140,7 @@ tape( 'the function evaluates the quantile for `p` given a large range `b - a`', b = largeRange.b; for ( i = 0; i < p.length; i++ ) { y = quantile( p[i], a[i], b[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', a: '+a[i]+', b: '+b[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } t.end(); });