From 3518a7d82fa34d5a38cf1a1a12bc8f110e308fc0 Mon Sep 17 00:00:00 2001 From: Claude Date: Mon, 5 Oct 2026 14:32:33 +0000 Subject: [PATCH] test: migrate `stats/base/dists/geometric/kurtosis` to ULP-based assertions Replace relative tolerance comparisons with `isAlmostSameValue` ULP difference assertions in both the JavaScript and native test suites. The measured minimum ULP bound over the full 1000-element Julia fixture set is `0` for both the JavaScript and C implementations. Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01UKXg9xt5vVqACoGUcUUVdh --- .../base/dists/geometric/kurtosis/test/test.js | 13 ++----------- .../dists/geometric/kurtosis/test/test.native.js | 13 ++----------- 2 files changed, 4 insertions(+), 22 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/geometric/kurtosis/test/test.js b/lib/node_modules/@stdlib/stats/base/dists/geometric/kurtosis/test/test.js index 9776289c051f..a62a7a7ee87f 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/geometric/kurtosis/test/test.js +++ b/lib/node_modules/@stdlib/stats/base/dists/geometric/kurtosis/test/test.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var kurtosis = require( './../lib' ); @@ -68,8 +67,6 @@ tape( 'if provided a success probability `p` outside of `[0,1]`, the function re tape( 'the function returns the excess kurtosis of a geometric distribution', function test( t ) { var expected; - var delta; - var tol; var i; var p; var y; @@ -78,13 +75,7 @@ tape( 'the function returns the excess kurtosis of a geometric distribution', fu p = data.p; for ( i = 0; i < expected.length; i++ ) { y = kurtosis( p[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/geometric/kurtosis/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/geometric/kurtosis/test/test.native.js index acfc29bfd8ba..41e4fa5633e2 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/geometric/kurtosis/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/geometric/kurtosis/test/test.native.js @@ -23,11 +23,10 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); var tryRequire = require( '@stdlib/utils/try-require' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); // VARIABLES // @@ -77,8 +76,6 @@ tape( 'if provided a success probability `p` outside of `[0,1]`, the function re tape( 'the function returns the excess kurtosis of a geometric distribution', opts, function test( t ) { var expected; - var delta; - var tol; var i; var p; var y; @@ -87,13 +84,7 @@ tape( 'the function returns the excess kurtosis of a geometric distribution', op p = data.p; for ( i = 0; i < expected.length; i++ ) { y = kurtosis( p[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } t.end(); });