From cdaf81984b3bd9ca69dd70b39c8fc0b71b1005bc Mon Sep 17 00:00:00 2001 From: Athan Reines Date: Sun, 4 Oct 2026 22:26:59 +0000 Subject: [PATCH] test: migrate `stats/base/dists/signrank/pdf` to ULP-based assertions Replaces relative tolerance assertions with ULP difference assertions via `@stdlib/assert/is-almost-same-value`. The measured maximum ULP difference over the fixture set is `5` for both the JavaScript and C implementations, so assertions use a bound of `5` ULP. Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01WTXXsug1J6NE1rFcUbkowy --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../base/dists/signrank/pdf/test/test.factory.js | 13 ++----------- .../base/dists/signrank/pdf/test/test.native.js | 13 ++----------- .../stats/base/dists/signrank/pdf/test/test.pdf.js | 13 ++----------- 3 files changed, 6 insertions(+), 33 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/signrank/pdf/test/test.factory.js b/lib/node_modules/@stdlib/stats/base/dists/signrank/pdf/test/test.factory.js index f8cbdd306616..fc7afb523cf5 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/signrank/pdf/test/test.factory.js +++ b/lib/node_modules/@stdlib/stats/base/dists/signrank/pdf/test/test.factory.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var factory = require( './../lib/factory.js' ); @@ -123,9 +122,7 @@ tape( 'the created function returns `0` if provided a non-integer for `x`', func tape( 'the created function evaluates the PDF for `x` given `n` observations', function test( t ) { var expected; - var delta; var pdf; - var tol; var i; var n; var x; @@ -137,13 +134,7 @@ tape( 'the created function evaluates the PDF for `x` given `n` observations', f for ( i = 0; i < x.length; i++ ) { pdf = factory( n[i] ); y = pdf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', n: '+n[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 20.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. n: '+n[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 5 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/signrank/pdf/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/signrank/pdf/test/test.native.js index 16e2df38edd7..1e9739326cbe 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/signrank/pdf/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/signrank/pdf/test/test.native.js @@ -22,12 +22,11 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var tryRequire = require( '@stdlib/utils/try-require' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var data = require( './fixtures/r/data.json' ); @@ -96,8 +95,6 @@ tape( 'the function returns `0` if provided a non-integer for `x`', opts, functi tape( 'the function evaluates the PDF for `x` given `n` observations', opts, function test( t ) { var expected; - var delta; - var tol; var i; var x; var y; @@ -108,13 +105,7 @@ tape( 'the function evaluates the PDF for `x` given `n` observations', opts, fun n = data.n; for ( i = 0; i < x.length; i++ ) { y = pdf( x[i], n[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', n: '+n[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 80.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. n: '+n[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 5 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/signrank/pdf/test/test.pdf.js b/lib/node_modules/@stdlib/stats/base/dists/signrank/pdf/test/test.pdf.js index 2df34e28735c..6191445a52a4 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/signrank/pdf/test/test.pdf.js +++ b/lib/node_modules/@stdlib/stats/base/dists/signrank/pdf/test/test.pdf.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var pdf = require( './../lib' ); @@ -94,8 +93,6 @@ tape( 'the function returns `0` if provided a non-integer for `x`', function tes tape( 'the function evaluates the PDF for `x` given `n` observations', function test( t ) { var expected; - var delta; - var tol; var i; var x; var y; @@ -106,13 +103,7 @@ tape( 'the function evaluates the PDF for `x` given `n` observations', function n = data.n; for ( i = 0; i < x.length; i++ ) { y = pdf( x[i], n[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', n: '+n[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 20.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. n: '+n[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 5 ), true, 'returns expected value' ); } t.end(); });